Re: [U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code

2015-05-26 Thread Stefano Babic 
On 23/05/2015 09:17, Axel Lin wrote:
 The break after return is unreachable code, remove it.
 
 Signed-off-by: Axel Lin axel@ingics.com
 ---
  drivers/pwm/pwm-imx-util.c | 4 
  1 file changed, 4 deletions(-)
 
 diff --git a/drivers/pwm/pwm-imx-util.c b/drivers/pwm/pwm-imx-util.c
 index 79d86028..f92c370 100644
 --- a/drivers/pwm/pwm-imx-util.c
 +++ b/drivers/pwm/pwm-imx-util.c
 @@ -21,16 +21,12 @@ struct pwm_regs *pwm_id_to_reg(int pwm_id)
   switch (pwm_id) {
   case 0:
   return (struct pwm_regs *)PWM1_BASE_ADDR;
 - break;
   case 1:
   return (struct pwm_regs *)PWM2_BASE_ADDR;
 - break;
   case 2:
   return (struct pwm_regs *)PWM3_BASE_ADDR;
 - break;
   case 3:
   return (struct pwm_regs *)PWM4_BASE_ADDR;
 - break;
   default:
   printf(unknown pwm_id: %d\n, pwm_id);
   break;
 
Applied to u-boot-imx, thanks!

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code

2015-05-25 Thread Heiko Schocher 

Hello Axel,

Am 23.05.2015 09:17, schrieb Axel Lin:

The break after return is unreachable code, remove it.

Signed-off-by: Axel Lin axel@ingics.com
---
  drivers/pwm/pwm-imx-util.c | 4 
  1 file changed, 4 deletions(-)


Acked-by: Heiko Schocher h...@denx.de

bye,
Heiko


diff --git a/drivers/pwm/pwm-imx-util.c b/drivers/pwm/pwm-imx-util.c
index 79d86028..f92c370 100644
--- a/drivers/pwm/pwm-imx-util.c
+++ b/drivers/pwm/pwm-imx-util.c
@@ -21,16 +21,12 @@ struct pwm_regs *pwm_id_to_reg(int pwm_id)
switch (pwm_id) {
case 0:
return (struct pwm_regs *)PWM1_BASE_ADDR;
-   break;
case 1:
return (struct pwm_regs *)PWM2_BASE_ADDR;
-   break;
case 2:
return (struct pwm_regs *)PWM3_BASE_ADDR;
-   break;
case 3:
return (struct pwm_regs *)PWM4_BASE_ADDR;
-   break;
default:
printf(unknown pwm_id: %d\n, pwm_id);
break;



--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code

2015-05-23 Thread Axel Lin 
The break after return is unreachable code, remove it.

Signed-off-by: Axel Lin axel@ingics.com
---
 drivers/pwm/pwm-imx-util.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/pwm/pwm-imx-util.c b/drivers/pwm/pwm-imx-util.c
index 79d86028..f92c370 100644
--- a/drivers/pwm/pwm-imx-util.c
+++ b/drivers/pwm/pwm-imx-util.c
@@ -21,16 +21,12 @@ struct pwm_regs *pwm_id_to_reg(int pwm_id)
switch (pwm_id) {
case 0:
return (struct pwm_regs *)PWM1_BASE_ADDR;
-   break;
case 1:
return (struct pwm_regs *)PWM2_BASE_ADDR;
-   break;
case 2:
return (struct pwm_regs *)PWM3_BASE_ADDR;
-   break;
case 3:
return (struct pwm_regs *)PWM4_BASE_ADDR;
-   break;
default:
printf(unknown pwm_id: %d\n, pwm_id);
break;
-- 
2.1.0



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code

2015-05-23 Thread Stefano Babic 


On 23/05/2015 09:17, Axel Lin wrote:
 The break after return is unreachable code, remove it.
 
 Signed-off-by: Axel Lin axel@ingics.com
 ---
  drivers/pwm/pwm-imx-util.c | 4 
  1 file changed, 4 deletions(-)
 
 diff --git a/drivers/pwm/pwm-imx-util.c b/drivers/pwm/pwm-imx-util.c
 index 79d86028..f92c370 100644
 --- a/drivers/pwm/pwm-imx-util.c
 +++ b/drivers/pwm/pwm-imx-util.c
 @@ -21,16 +21,12 @@ struct pwm_regs *pwm_id_to_reg(int pwm_id)
   switch (pwm_id) {
   case 0:
   return (struct pwm_regs *)PWM1_BASE_ADDR;
 - break;
   case 1:
   return (struct pwm_regs *)PWM2_BASE_ADDR;
 - break;
   case 2:
   return (struct pwm_regs *)PWM3_BASE_ADDR;
 - break;
   case 3:
   return (struct pwm_regs *)PWM4_BASE_ADDR;
 - break;
   default:
   printf(unknown pwm_id: %d\n, pwm_id);
   break;
 

Acked-by: Stefano Babic sba...@denx.de

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot