Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-04 Thread Simon Glass
Hi Siarhei, On 3 February 2015 at 20:23, Simon Glass s...@chromium.org wrote: Hi Siarhei, On 3 February 2015 at 18:58, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Tue, 3 Feb 2015 17:55:52 -0700 Simon Glass s...@chromium.org wrote: Hi, On 2 February 2015 at 22:29, Simon Glass

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-04 Thread Simon Glass
Hi Siarhei, On 3 February 2015 at 18:58, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Tue, 3 Feb 2015 17:55:52 -0700 Simon Glass s...@chromium.org wrote: Hi, On 2 February 2015 at 22:29, Simon Glass s...@chromium.org wrote: Hi, On 2 February 2015 at 01:07, Hans de Goede

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-04 Thread Siarhei Siamashka
On Tue, 3 Feb 2015 17:55:52 -0700 Simon Glass s...@chromium.org wrote: Hi, On 2 February 2015 at 22:29, Simon Glass s...@chromium.org wrote: Hi, On 2 February 2015 at 01:07, Hans de Goede hdego...@redhat.com wrote: Hi Simon, Siarhei, On 01-02-15 21:59, Simon Glass wrote: Hi

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-03 Thread Simon Glass
Hi, On 2 February 2015 at 22:29, Simon Glass s...@chromium.org wrote: Hi, On 2 February 2015 at 01:07, Hans de Goede hdego...@redhat.com wrote: Hi Simon, Siarhei, On 01-02-15 21:59, Simon Glass wrote: Hi Siarhei, On 1 February 2015 at 11:37, Siarhei Siamashka

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-02 Thread Simon Glass
Hi, On 2 February 2015 at 01:07, Hans de Goede hdego...@redhat.com wrote: Hi Simon, Siarhei, On 01-02-15 21:59, Simon Glass wrote: Hi Siarhei, On 1 February 2015 at 11:37, Siarhei Siamashka siarhei.siamas...@gmail.com snip A comprehensive FEL usage guide is supposed to be in the

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-02 Thread Hans de Goede
Hi Simon, Siarhei, On 01-02-15 21:59, Simon Glass wrote: Hi Siarhei, On 1 February 2015 at 11:37, Siarhei Siamashka siarhei.siamas...@gmail.com snip A comprehensive FEL usage guide is supposed to be in the linux-sunxi wiki. But it might be not very up to date with the mainline u-boot usage.

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-01 Thread Simon Glass
Hi Siarhei, On 1 February 2015 at 09:45, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Sun, 1 Feb 2015 09:29:53 -0700 Simon Glass s...@chromium.org wrote: Hi, On 30 January 2015 at 10:53, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Mon, 29 Dec 2014 09:15:36 -0700

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-01 Thread Siarhei Siamashka
On Sun, 1 Feb 2015 09:29:53 -0700 Simon Glass s...@chromium.org wrote: Hi, On 30 January 2015 at 10:53, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Mon, 29 Dec 2014 09:15:36 -0700 Simon Glass s...@chromium.org wrote: Hi Ian, On 28 December 2014 at 02:19, Ian Campbell

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-01 Thread Simon Glass
Hi, On 30 January 2015 at 10:53, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Mon, 29 Dec 2014 09:15:36 -0700 Simon Glass s...@chromium.org wrote: Hi Ian, On 28 December 2014 at 02:19, Ian Campbell i...@hellion.org.uk wrote: On Tue, 2014-12-23 at 12:04 -0700, Simon Glass wrote:

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-01 Thread Siarhei Siamashka
On Sun, 1 Feb 2015 10:00:43 -0700 Simon Glass s...@chromium.org wrote: Hi Siarhei, On 1 February 2015 at 09:45, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Sun, 1 Feb 2015 09:29:53 -0700 Simon Glass s...@chromium.org wrote: Hi, On 30 January 2015 at 10:53, Siarhei

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-02-01 Thread Simon Glass
Hi Siarhei, On 1 February 2015 at 11:37, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Sun, 1 Feb 2015 10:00:43 -0700 Simon Glass s...@chromium.org wrote: Hi Siarhei, On 1 February 2015 at 09:45, Siarhei Siamashka siarhei.siamas...@gmail.com wrote: On Sun, 1 Feb 2015 09:29:53

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2015-01-30 Thread Siarhei Siamashka
On Mon, 29 Dec 2014 09:15:36 -0700 Simon Glass s...@chromium.org wrote: Hi Ian, On 28 December 2014 at 02:19, Ian Campbell i...@hellion.org.uk wrote: On Tue, 2014-12-23 at 12:04 -0700, Simon Glass wrote: +void board_init_f(ulong dummy) +{ [...] + /* Clear the BSS. */ +

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2014-12-29 Thread Simon Glass
Hi Ian, On 28 December 2014 at 02:19, Ian Campbell i...@hellion.org.uk wrote: On Tue, 2014-12-23 at 12:04 -0700, Simon Glass wrote: +void board_init_f(ulong dummy) +{ [...] + /* Clear the BSS. */ + memset(__bss_start, 0, __bss_end - __bss_start); + + board_init_r(NULL, 0);

Re: [U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2014-12-28 Thread Ian Campbell
On Tue, 2014-12-23 at 12:04 -0700, Simon Glass wrote: +void board_init_f(ulong dummy) +{ [...] + /* Clear the BSS. */ + memset(__bss_start, 0, __bss_end - __bss_start); + + board_init_r(NULL, 0); The previous (__weak) version of board_init_f also sets gd, which you've also

[U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

2014-12-23 Thread Simon Glass
The current sunxi implementation uses gdata, which is going away. It also sets up DRAM before board_init_f() in SPL. There is really no reason to do much in s_init() since board_init_f() is called immediately afterwards. The only change is that we need our own implementation of board_init_f()