Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

Hi Tom, On 8 December 2015 at 16:58, Tom Rini wrote: > > On Tue, Dec 08, 2015 at 04:42:17PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Dec 8, 2015 4:28 PM, "Tom Rini" wrote: > > > > > > On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: >

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

On Wed, Dec 09, 2015 at 04:58:12PM -0700, Simon Glass wrote: > Hi Tom, > > On 8 December 2015 at 16:58, Tom Rini wrote: > > > > On Tue, Dec 08, 2015 at 04:42:17PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Dec 8, 2015 4:28 PM, "Tom Rini"

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

Hi Tom, On 7 December 2015 at 20:26, Tom Rini wrote: > Coverity notes that we do not ensure when we copy in the product/vendor > strings that they have NULL termination. In this case the answer is to > increase the buffer we have and then set the last entry to NULL. > >

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: > Hi Tom, > > On 7 December 2015 at 20:26, Tom Rini wrote: > > Coverity notes that we do not ensure when we copy in the product/vendor > > strings that they have NULL termination. In this case the answer is to > >

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

Hi Tom, On Dec 8, 2015 4:28 PM, "Tom Rini" wrote: > > On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On 7 December 2015 at 20:26, Tom Rini wrote: > > > Coverity notes that we do not ensure when we copy in the

Re: [U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

On Tue, Dec 08, 2015 at 04:42:17PM -0700, Simon Glass wrote: > Hi Tom, > > On Dec 8, 2015 4:28 PM, "Tom Rini" wrote: > > > > On Tue, Dec 08, 2015 at 12:35:23PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On 7 December 2015 at 20:26, Tom Rini

[U-Boot] [PATCH 3/3] sandbox: sandbox_flash.c: Ensure NUL-termination on product/vendor strings

Coverity notes that we do not ensure when we copy in the product/vendor strings that they have NULL termination. In this case the answer is to increase the buffer we have and then set the last entry to NULL. Reported-by: Coverity (CID 131095) Cc: Simon Glass Signed-off-by: