Re: [U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place

[Chin Liang See]

Hi,

On Tue, 2015-09-08 at 17:51 +0530, Jagan Teki wrote:
> On 8 September 2015 at 06:48, Chin Liang See  wrote:
> > Ensure the intended SCLK frequency not exceeding the maximum
> > frequency. If that happen, SCLK will set to maximum frequency.
> >
> > Signed-off-by: Chin Liang See 
> > Cc: Dinh Nguyen 
> > Cc: Dinh Nguyen 
> > Cc: Marek Vasut 
> > Cc: Stefan Roese 
> > Cc: Vikas Manocha 
> > Cc: Jagannadh Teki 
> > Cc: Pavel Machek 
> > ---
> >  drivers/spi/cadence_qspi.c |5 +
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
> > index 8c0f7dd..f430b5d 100644
> > --- a/drivers/spi/cadence_qspi.c
> > +++ b/drivers/spi/cadence_qspi.c
> > @@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, 
> > uint hz)
> > struct cadence_spi_priv *priv = dev_get_priv(bus);
> > int err;
> >
> > +   if (hz > plat->max_hz) {
> > +   hz = plat->max_hz;
> > +   puts("SF: Default to maximum supported SCLK frequency\n");
> 
> This print mayn't require just assign plat->max_hz enough.

Sure, I can update that.

Thanks
Chin Liang

> 
> Reviewed-by: Jagan Teki 
> 
> > +   }
> > +
> > /* Disable QSPI */
> > cadence_qspi_apb_controller_disable(priv->regbase);
> 
> thanks!


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place

[Jagan Teki]

On 8 September 2015 at 06:48, Chin Liang See  wrote:
> Ensure the intended SCLK frequency not exceeding the maximum
> frequency. If that happen, SCLK will set to maximum frequency.
>
> Signed-off-by: Chin Liang See 
> Cc: Dinh Nguyen 
> Cc: Dinh Nguyen 
> Cc: Marek Vasut 
> Cc: Stefan Roese 
> Cc: Vikas Manocha 
> Cc: Jagannadh Teki 
> Cc: Pavel Machek 
> ---
>  drivers/spi/cadence_qspi.c |5 +
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
> index 8c0f7dd..f430b5d 100644
> --- a/drivers/spi/cadence_qspi.c
> +++ b/drivers/spi/cadence_qspi.c
> @@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, 
> uint hz)
> struct cadence_spi_priv *priv = dev_get_priv(bus);
> int err;
>
> +   if (hz > plat->max_hz) {
> +   hz = plat->max_hz;
> +   puts("SF: Default to maximum supported SCLK frequency\n");

This print mayn't require just assign plat->max_hz enough.

Reviewed-by: Jagan Teki 

> +   }
> +
> /* Disable QSPI */
> cadence_qspi_apb_controller_disable(priv->regbase);

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place

[Chin Liang See]

Ensure the intended SCLK frequency not exceeding the maximum
frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by: Chin Liang See 
Cc: Dinh Nguyen 
Cc: Dinh Nguyen 
Cc: Marek Vasut 
Cc: Stefan Roese 
Cc: Vikas Manocha 
Cc: Jagannadh Teki 
Cc: Pavel Machek 
---
 drivers/spi/cadence_qspi.c |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
index 8c0f7dd..f430b5d 100644
--- a/drivers/spi/cadence_qspi.c
+++ b/drivers/spi/cadence_qspi.c
@@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint 
hz)
struct cadence_spi_priv *priv = dev_get_priv(bus);
int err;
 
+   if (hz > plat->max_hz) {
+   hz = plat->max_hz;
+   puts("SF: Default to maximum supported SCLK frequency\n");
+   }
+
/* Disable QSPI */
cadence_qspi_apb_controller_disable(priv->regbase);
 
-- 
1.7.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 3/4] spi: cadence_qspi: Ensure check for max frequency in place

[Chin Liang See]

Ensure the intended SCLK frequency not exceeding the maximum
frequency. If that happen, SCLK will set to maximum frequency.

Signed-off-by: Chin Liang See 
Cc: Dinh Nguyen 
Cc: Dinh Nguyen 
Cc: Marek Vasut 
Cc: Stefan Roese 
Cc: Vikas Manocha 
Cc: Jagannadh Teki 
Cc: Pavel Machek 
---
 drivers/spi/cadence_qspi.c |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
index a00af87..52c29d5 100644
--- a/drivers/spi/cadence_qspi.c
+++ b/drivers/spi/cadence_qspi.c
@@ -123,6 +123,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint 
hz)
struct cadence_spi_priv *priv = dev_get_priv(bus);
int err;
 
+   if (hz > plat->max_hz) {
+   hz = plat->max_hz;
+   puts("SF: Default to maximum supported SCLK frequency\n");
+   }
+
/* Disable QSPI */
cadence_qspi_apb_controller_disable(priv->regbase);
 
-- 
1.7.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot