Re: [U-Boot] [PATCH 41/71] serial: arm: Implement CONFIG_SERIAL_MULTI into atmel serial driver

2012-09-18 Thread Andreas Bießmann
Dear Marek Vasut, On 17.09.2012 01:21, Marek Vasut wrote: Implement support for CONFIG_SERIAL_MULTI into atmel serial driver. This driver was so far only usable directly, but this patch also adds support for the multi method. This allows using more than one serial driver alongside the atmel

Re: [U-Boot] [PATCH 41/71] serial: arm: Implement CONFIG_SERIAL_MULTI into atmel serial driver

2012-09-17 Thread Andreas Bießmann
Dear Marek Vasut, I have to admit that when reading this patch I got attention of your UDM-serial.txt for the first time. However when reading this patch some questions come to my mind. On 17.09.12 01:21, Marek Vasut wrote: Implement support for CONFIG_SERIAL_MULTI into atmel serial driver.

Re: [U-Boot] [PATCH 41/71] serial: arm: Implement CONFIG_SERIAL_MULTI into atmel serial driver

2012-09-17 Thread Marek Vasut
Dear Andreas Bießmann, Dear Marek Vasut, I have to admit that when reading this patch I got attention of your UDM-serial.txt for the first time. However when reading this patch some questions come to my mind. [...] -void serial_setbrg(void) +static void atmel_serial_setbrg(void)

Re: [U-Boot] [PATCH 41/71] serial: arm: Implement CONFIG_SERIAL_MULTI into atmel serial driver

2012-09-17 Thread Andreas Bießmann
Dear Marek Vasut, On 17.09.2012 12:00, Marek Vasut wrote: Dear Andreas Bießmann, Dear Marek Vasut, I have to admit that when reading this patch I got attention of your UDM-serial.txt for the first time. However when reading this patch some questions come to my mind. [...] -void

Re: [U-Boot] [PATCH 41/71] serial: arm: Implement CONFIG_SERIAL_MULTI into atmel serial driver

2012-09-17 Thread Marek Vasut
Dear Andreas Bießmann, [...] They have multiple drivers so far and a default_serial_console call. That is indeed stupid, but fixing this is not part of this patchset, but a subsequent one. This one is only a preparation, trying not to break anything and unify the drivers under the

[U-Boot] [PATCH 41/71] serial: arm: Implement CONFIG_SERIAL_MULTI into atmel serial driver

2012-09-16 Thread Marek Vasut
Implement support for CONFIG_SERIAL_MULTI into atmel serial driver. This driver was so far only usable directly, but this patch also adds support for the multi method. This allows using more than one serial driver alongside the atmel driver. Also, add a weak implementation of