Re: [U-Boot] [PATCH V5 2/2] imx: mx27 move GPIO_PORTx to gpio.h

2015-05-15 Thread Simon Glass
On 14 May 2015 at 17:29, Peng Fan wrote: > These GPIO_PORTx macros should be in gpio.h, but not in imx-regs.h. > > Also, imx-regs.h and iomux-v3.h has same macro defintion for > GPIO_PORTx, and both of them are included in mxc_i2c.c(include > mxc_i2c.h). This will incur build warnings with macro r

[U-Boot] [PATCH V5 2/2] imx: mx27 move GPIO_PORTx to gpio.h

2015-05-14 Thread Peng Fan
These GPIO_PORTx macros should be in gpio.h, but not in imx-regs.h. Also, imx-regs.h and iomux-v3.h has same macro defintion for GPIO_PORTx, and both of them are included in mxc_i2c.c(include mxc_i2c.h). This will incur build warnings with macro redefinition. Since iomux-v3.h is not compatible wi