Re: [U-Boot] [PATCH v2] vboot: Do not use hashed-strings offset

2018-06-14 Thread Simon Glass
On 9 June 2018 at 09:45, Teddy Reed  wrote:
> The hashed-strings signature property includes two uint32_t values.
> The first is unneeded as there should never be a start offset into the
> strings region. The second, the size, is needed because the added
> signature node appends to this region.
>
> See tools/image-host.c, where a static 0 value is used for the offset.
>
> Signed-off-by: Teddy Reed 
> ---
>  common/image-sig.c | 7 +--
>  tools/image-host.c | 1 +
>  2 files changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v2] vboot: Do not use hashed-strings offset

2018-06-09 Thread Teddy Reed
The hashed-strings signature property includes two uint32_t values.
The first is unneeded as there should never be a start offset into the
strings region. The second, the size, is needed because the added
signature node appends to this region.

See tools/image-host.c, where a static 0 value is used for the offset.

Signed-off-by: Teddy Reed 
---
 common/image-sig.c | 7 +--
 tools/image-host.c | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/common/image-sig.c b/common/image-sig.c
index f65d883..ad571f9 100644
--- a/common/image-sig.c
+++ b/common/image-sig.c
@@ -372,8 +372,11 @@ int fit_config_check_sig(const void *fit, int noffset, int 
required_keynode,
/* Add the strings */
strings = fdt_getprop(fit, noffset, "hashed-strings", NULL);
if (strings) {
-   fdt_regions[count].offset = fdt_off_dt_strings(fit) +
-   fdt32_to_cpu(strings[0]);
+   /*
+* The strings region offset must be a static 0x0.
+* This is set in tool/image-host.c
+*/
+   fdt_regions[count].offset = fdt_off_dt_strings(fit);
fdt_regions[count].size = fdt32_to_cpu(strings[1]);
count++;
}
diff --git a/tools/image-host.c b/tools/image-host.c
index 8e43671..be2d59b 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -135,6 +135,7 @@ static int fit_image_write_sig(void *fit, int noffset, 
uint8_t *value,
 
ret = fdt_setprop(fit, noffset, "hashed-nodes",
   region_prop, region_proplen);
+   /* This is a legacy offset, it is unused, and must remain 0. */
strdata[0] = 0;
strdata[1] = cpu_to_fdt32(string_size);
if (!ret) {
-- 
2.7.4
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot