Re: [U-Boot] [PATCH v2 0/8] basic rockchip rk3188 support

[Heiko Stübner]

Hi Simon,

Am Mittwoch, 27. Juli 2016, 21:42:47 schrieb Simon Glass:
> On 22 July 2016 at 15:51, Heiko Stuebner  wrote:
> > Second version. Simon already applied the cleanup patches from my
> > first version. I've tried to address Simons comments and hopefully
> > haven't overlooked any.
> > 
> > SPL is still missing, so following Simons comment from earlier
> > it cannot go in yet, but maybe the first two cleanups can.
> 
> Re the first patch, if you can resend it as a 'move' patch then I can
> apply it. Please base on u-boot-rockchip/master.

ok, I can do that :-)

> For rk3188, yes I would prefer to wait until we have the proper SPL.
> It sounds like you are close? I don't have an rk3188 board - I could
> get a TV box with that chip but I'm not sure if it would work for
> development.

I wouldn't call it close, but it's moving along somewhat and we figure out the 
special requirements step by step. As for yout getting a box, I guess the 
worst part is finding serial pin testpoints. For booting the rk3188 seems to be 
the easiest of them all - if you plug in a suitably prepared card, it will 
always prefer this one over everything else.


Heiko

> > changes in v2:
> > - move clock drivers to subdirectory
> > - use already available log2 function in clock drivers
> > - SPDX header in clock bindings
> > - showcase rk3188 arch code and rock board
> > 
> > Heiko Stuebner (10):
> >   rockchip: move clock drivers into a subdirectory
> >   rockchip: remove log2 reimplementation from clock drivers
> >   rockchip: rk3188: Add header files for PMU and GRF
> >   rockchip: rk3188: Add pinctrl driver
> >   rockchip: rk3188: Bring in rk3066/rk3188 clock bindings
> >   rockchip: rk3188: Add clock driver
> >   rockchip: rk3188: add core support
> >   rockchip: rk3188: Radxa Rock board
> >   add unfinished SPL support
> >   hacks to make my rock netboot a fit image
> >  
> >  arch/arm/dts/Makefile   |   1 +
> >  arch/arm/dts/rk3188-radxarock.dts   | 406 +++
> >  arch/arm/dts/rk3188.dtsi| 631 ++
> >  arch/arm/dts/rk3xxx.dtsi| 431 
> >  arch/arm/include/asm/arch-rockchip/cru_rk3188.h | 183 +
> >  arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 589 
> >  arch/arm/include/asm/arch-rockchip/pmu_rk3188.h |  36 +
> >  arch/arm/mach-rockchip/Kconfig  |  11 +
> >  arch/arm/mach-rockchip/Makefile |   2 +
> >  arch/arm/mach-rockchip/rk3188-board-spl.c   | 190 ++
> >  arch/arm/mach-rockchip/rk3188/Kconfig   |  20 +
> >  arch/arm/mach-rockchip/rk3188/Makefile  |  10 +
> >  arch/arm/mach-rockchip/rk3188/clk_rk3188.c  |  17 +
> >  arch/arm/mach-rockchip/rk3188/reset_rk3188.c|  47 ++
> >  arch/arm/mach-rockchip/rk3188/sdram_rk3188.c| 839
> >  +++ arch/arm/mach-rockchip/rk3188/syscon_rk3188.c  
> >  |  24 +
> >  board/radxa/rock/Kconfig|  15 +
> >  board/radxa/rock/MAINTAINERS|   6 +
> >  board/radxa/rock/Makefile   |   7 +
> >  board/radxa/rock/rock.c |  32 +
> >  configs/rock_defconfig  |  80 +++
> >  drivers/clk/Makefile|   3 +-
> >  drivers/clk/clk_rk3036.c| 386 ---
> >  drivers/clk/clk_rk3288.c| 851
> >   drivers/clk/rockchip/Makefile  
> >  |   9 +
> >  drivers/clk/rockchip/clk_rk3036.c   | 382 +++
> >  drivers/clk/rockchip/clk_rk3188.c   | 493 ++
> >  drivers/clk/rockchip/clk_rk3288.c   | 847
> >  +++ drivers/pinctrl/Kconfig
> >  |   9 +
> >  drivers/pinctrl/rockchip/Makefile   |   1 +
> >  drivers/pinctrl/rockchip/pinctrl_rk3188.c   | 613 +
> >  drivers/usb/host/dwc2.c |   4 +-
> >  include/configs/rk3188_common.h | 109 +++
> >  include/configs/rock.h  |  66 ++
> >  include/dt-bindings/clock/rk3066a-cru.h |  32 +
> >  include/dt-bindings/clock/rk3188-cru-common.h   | 248 +++
> >  include/dt-bindings/clock/rk3188-cru.h  |  48 ++
> >  tools/rkcommon.c|   1 +
> >  38 files changed, 6438 insertions(+), 1241 deletions(-)
> >  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
> >  create mode 100644 arch/arm/dts/rk3188.dtsi
> >  create mode 100644 arch/arm/dts/rk3xxx.dtsi
> >  create mode 100644 arch/arm/include/asm/arch-rockchip/cru_rk3188.h
> >  create mode 100644 arch/arm/include/asm/arch-rockchip/grf_rk3188.h
> >  create mode 100644 arch/arm/include/asm/arch-rockchip/pmu_rk3188.h
> >  create mode 100644 arch/arm/mach-rockchip/rk3188-board-spl.c
> >  create mode 100644 arch/arm/mach-rockchip/rk3188/Kconfig
> >  

Re: [U-Boot] [PATCH v2 0/8] basic rockchip rk3188 support

[Simon Glass]

Hi Heiko,

On 22 July 2016 at 15:51, Heiko Stuebner  wrote:
> Second version. Simon already applied the cleanup patches from my
> first version. I've tried to address Simons comments and hopefully
> haven't overlooked any.
>
> SPL is still missing, so following Simons comment from earlier
> it cannot go in yet, but maybe the first two cleanups can.

Re the first patch, if you can resend it as a 'move' patch then I can
apply it. Please base on u-boot-rockchip/master.

For rk3188, yes I would prefer to wait until we have the proper SPL.
It sounds like you are close? I don't have an rk3188 board - I could
get a TV box with that chip but I'm not sure if it would work for
development.

>
> changes in v2:
> - move clock drivers to subdirectory
> - use already available log2 function in clock drivers
> - SPDX header in clock bindings
> - showcase rk3188 arch code and rock board
>
> Heiko Stuebner (10):
>   rockchip: move clock drivers into a subdirectory
>   rockchip: remove log2 reimplementation from clock drivers
>   rockchip: rk3188: Add header files for PMU and GRF
>   rockchip: rk3188: Add pinctrl driver
>   rockchip: rk3188: Bring in rk3066/rk3188 clock bindings
>   rockchip: rk3188: Add clock driver
>   rockchip: rk3188: add core support
>   rockchip: rk3188: Radxa Rock board
>   add unfinished SPL support
>   hacks to make my rock netboot a fit image
>
>  arch/arm/dts/Makefile   |   1 +
>  arch/arm/dts/rk3188-radxarock.dts   | 406 +++
>  arch/arm/dts/rk3188.dtsi| 631 ++
>  arch/arm/dts/rk3xxx.dtsi| 431 
>  arch/arm/include/asm/arch-rockchip/cru_rk3188.h | 183 +
>  arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 589 
>  arch/arm/include/asm/arch-rockchip/pmu_rk3188.h |  36 +
>  arch/arm/mach-rockchip/Kconfig  |  11 +
>  arch/arm/mach-rockchip/Makefile |   2 +
>  arch/arm/mach-rockchip/rk3188-board-spl.c   | 190 ++
>  arch/arm/mach-rockchip/rk3188/Kconfig   |  20 +
>  arch/arm/mach-rockchip/rk3188/Makefile  |  10 +
>  arch/arm/mach-rockchip/rk3188/clk_rk3188.c  |  17 +
>  arch/arm/mach-rockchip/rk3188/reset_rk3188.c|  47 ++
>  arch/arm/mach-rockchip/rk3188/sdram_rk3188.c| 839 +++
>  arch/arm/mach-rockchip/rk3188/syscon_rk3188.c   |  24 +
>  board/radxa/rock/Kconfig|  15 +
>  board/radxa/rock/MAINTAINERS|   6 +
>  board/radxa/rock/Makefile   |   7 +
>  board/radxa/rock/rock.c |  32 +
>  configs/rock_defconfig  |  80 +++
>  drivers/clk/Makefile|   3 +-
>  drivers/clk/clk_rk3036.c| 386 ---
>  drivers/clk/clk_rk3288.c| 851 
> 
>  drivers/clk/rockchip/Makefile   |   9 +
>  drivers/clk/rockchip/clk_rk3036.c   | 382 +++
>  drivers/clk/rockchip/clk_rk3188.c   | 493 ++
>  drivers/clk/rockchip/clk_rk3288.c   | 847 +++
>  drivers/pinctrl/Kconfig |   9 +
>  drivers/pinctrl/rockchip/Makefile   |   1 +
>  drivers/pinctrl/rockchip/pinctrl_rk3188.c   | 613 +
>  drivers/usb/host/dwc2.c |   4 +-
>  include/configs/rk3188_common.h | 109 +++
>  include/configs/rock.h  |  66 ++
>  include/dt-bindings/clock/rk3066a-cru.h |  32 +
>  include/dt-bindings/clock/rk3188-cru-common.h   | 248 +++
>  include/dt-bindings/clock/rk3188-cru.h  |  48 ++
>  tools/rkcommon.c|   1 +
>  38 files changed, 6438 insertions(+), 1241 deletions(-)
>  create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>  create mode 100644 arch/arm/dts/rk3188.dtsi
>  create mode 100644 arch/arm/dts/rk3xxx.dtsi
>  create mode 100644 arch/arm/include/asm/arch-rockchip/cru_rk3188.h
>  create mode 100644 arch/arm/include/asm/arch-rockchip/grf_rk3188.h
>  create mode 100644 arch/arm/include/asm/arch-rockchip/pmu_rk3188.h
>  create mode 100644 arch/arm/mach-rockchip/rk3188-board-spl.c
>  create mode 100644 arch/arm/mach-rockchip/rk3188/Kconfig
>  create mode 100644 arch/arm/mach-rockchip/rk3188/Makefile
>  create mode 100644 arch/arm/mach-rockchip/rk3188/clk_rk3188.c
>  create mode 100644 arch/arm/mach-rockchip/rk3188/reset_rk3188.c
>  create mode 100644 arch/arm/mach-rockchip/rk3188/sdram_rk3188.c
>  create mode 100644 arch/arm/mach-rockchip/rk3188/syscon_rk3188.c
>  create mode 100644 board/radxa/rock/Kconfig
>  create mode 100644 board/radxa/rock/MAINTAINERS
>  create mode 100644 board/radxa/rock/Makefile
>  create mode 100644 board/radxa/rock/rock.c
>  create mode 100644 configs/rock_defconfig
>  delete mode 100644 drivers/clk/clk_rk3036.c
>  delete 

[U-Boot] [PATCH v2 0/8] basic rockchip rk3188 support

[Heiko Stuebner]

Second version. Simon already applied the cleanup patches from my
first version. I've tried to address Simons comments and hopefully
haven't overlooked any.

SPL is still missing, so following Simons comment from earlier
it cannot go in yet, but maybe the first two cleanups can.

changes in v2:
- move clock drivers to subdirectory
- use already available log2 function in clock drivers
- SPDX header in clock bindings
- showcase rk3188 arch code and rock board

Heiko Stuebner (10):
  rockchip: move clock drivers into a subdirectory
  rockchip: remove log2 reimplementation from clock drivers
  rockchip: rk3188: Add header files for PMU and GRF
  rockchip: rk3188: Add pinctrl driver
  rockchip: rk3188: Bring in rk3066/rk3188 clock bindings
  rockchip: rk3188: Add clock driver
  rockchip: rk3188: add core support
  rockchip: rk3188: Radxa Rock board
  add unfinished SPL support
  hacks to make my rock netboot a fit image

 arch/arm/dts/Makefile   |   1 +
 arch/arm/dts/rk3188-radxarock.dts   | 406 +++
 arch/arm/dts/rk3188.dtsi| 631 ++
 arch/arm/dts/rk3xxx.dtsi| 431 
 arch/arm/include/asm/arch-rockchip/cru_rk3188.h | 183 +
 arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 589 
 arch/arm/include/asm/arch-rockchip/pmu_rk3188.h |  36 +
 arch/arm/mach-rockchip/Kconfig  |  11 +
 arch/arm/mach-rockchip/Makefile |   2 +
 arch/arm/mach-rockchip/rk3188-board-spl.c   | 190 ++
 arch/arm/mach-rockchip/rk3188/Kconfig   |  20 +
 arch/arm/mach-rockchip/rk3188/Makefile  |  10 +
 arch/arm/mach-rockchip/rk3188/clk_rk3188.c  |  17 +
 arch/arm/mach-rockchip/rk3188/reset_rk3188.c|  47 ++
 arch/arm/mach-rockchip/rk3188/sdram_rk3188.c| 839 +++
 arch/arm/mach-rockchip/rk3188/syscon_rk3188.c   |  24 +
 board/radxa/rock/Kconfig|  15 +
 board/radxa/rock/MAINTAINERS|   6 +
 board/radxa/rock/Makefile   |   7 +
 board/radxa/rock/rock.c |  32 +
 configs/rock_defconfig  |  80 +++
 drivers/clk/Makefile|   3 +-
 drivers/clk/clk_rk3036.c| 386 ---
 drivers/clk/clk_rk3288.c| 851 
 drivers/clk/rockchip/Makefile   |   9 +
 drivers/clk/rockchip/clk_rk3036.c   | 382 +++
 drivers/clk/rockchip/clk_rk3188.c   | 493 ++
 drivers/clk/rockchip/clk_rk3288.c   | 847 +++
 drivers/pinctrl/Kconfig |   9 +
 drivers/pinctrl/rockchip/Makefile   |   1 +
 drivers/pinctrl/rockchip/pinctrl_rk3188.c   | 613 +
 drivers/usb/host/dwc2.c |   4 +-
 include/configs/rk3188_common.h | 109 +++
 include/configs/rock.h  |  66 ++
 include/dt-bindings/clock/rk3066a-cru.h |  32 +
 include/dt-bindings/clock/rk3188-cru-common.h   | 248 +++
 include/dt-bindings/clock/rk3188-cru.h  |  48 ++
 tools/rkcommon.c|   1 +
 38 files changed, 6438 insertions(+), 1241 deletions(-)
 create mode 100644 arch/arm/dts/rk3188-radxarock.dts
 create mode 100644 arch/arm/dts/rk3188.dtsi
 create mode 100644 arch/arm/dts/rk3xxx.dtsi
 create mode 100644 arch/arm/include/asm/arch-rockchip/cru_rk3188.h
 create mode 100644 arch/arm/include/asm/arch-rockchip/grf_rk3188.h
 create mode 100644 arch/arm/include/asm/arch-rockchip/pmu_rk3188.h
 create mode 100644 arch/arm/mach-rockchip/rk3188-board-spl.c
 create mode 100644 arch/arm/mach-rockchip/rk3188/Kconfig
 create mode 100644 arch/arm/mach-rockchip/rk3188/Makefile
 create mode 100644 arch/arm/mach-rockchip/rk3188/clk_rk3188.c
 create mode 100644 arch/arm/mach-rockchip/rk3188/reset_rk3188.c
 create mode 100644 arch/arm/mach-rockchip/rk3188/sdram_rk3188.c
 create mode 100644 arch/arm/mach-rockchip/rk3188/syscon_rk3188.c
 create mode 100644 board/radxa/rock/Kconfig
 create mode 100644 board/radxa/rock/MAINTAINERS
 create mode 100644 board/radxa/rock/Makefile
 create mode 100644 board/radxa/rock/rock.c
 create mode 100644 configs/rock_defconfig
 delete mode 100644 drivers/clk/clk_rk3036.c
 delete mode 100644 drivers/clk/clk_rk3288.c
 create mode 100644 drivers/clk/rockchip/Makefile
 create mode 100644 drivers/clk/rockchip/clk_rk3036.c
 create mode 100644 drivers/clk/rockchip/clk_rk3188.c
 create mode 100644 drivers/clk/rockchip/clk_rk3288.c
 create mode 100644 drivers/pinctrl/rockchip/pinctrl_rk3188.c
 create mode 100644 include/configs/rk3188_common.h
 create mode 100644 include/configs/rock.h
 create mode 100644 include/dt-bindings/clock/rk3066a-cru.h
 create mode 100644 include/dt-bindings/clock/rk3188-cru-common.h
 create mode 100644