Re: [U-Boot] [PATCH v2 01/10] board_f: Add a mach_cpu_init callback

[Simon Glass]

On 9 September 2016 at 07:44, Paul Burton  wrote:
> Currently we have a mismash of architectures which use arch_cpu_init
> from architecture-wide code (arc, avr32, blackfin, mips, nios2, xtensa)
> and architectures which use arch_cpu_init from machine/SoC level code
> (arm, x86).
>
> In order to clean this mess up & allow for both use cases, introduce a
> new mach_cpu_init callback which is run immediately after arch_cpu_init.
> This will allow for architectures to have arch-wide code without needing
> individual machines to all implement their own arch_cpu_init with a call
> to some common function.
>
> Signed-off-by: Paul Burton 
>
> ---
>
> Changes in v2:
> - Use a weak function, make it generic not MIPS-specific
>
>  common/board_f.c | 6 ++
>  1 file changed, 6 insertions(+)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 01/10] board_f: Add a mach_cpu_init callback

[Paul Burton]

Currently we have a mismash of architectures which use arch_cpu_init
from architecture-wide code (arc, avr32, blackfin, mips, nios2, xtensa)
and architectures which use arch_cpu_init from machine/SoC level code
(arm, x86).

In order to clean this mess up & allow for both use cases, introduce a
new mach_cpu_init callback which is run immediately after arch_cpu_init.
This will allow for architectures to have arch-wide code without needing
individual machines to all implement their own arch_cpu_init with a call
to some common function.

Signed-off-by: Paul Burton 

---

Changes in v2:
- Use a weak function, make it generic not MIPS-specific

 common/board_f.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/common/board_f.c b/common/board_f.c
index da381db..9ef998f 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -290,6 +290,11 @@ __weak int arch_cpu_init(void)
return 0;
 }
 
+__weak int mach_cpu_init(void)
+{
+   return 0;
+}
+
 #ifdef CONFIG_SANDBOX
 static int setup_ram_buf(void)
 {
@@ -860,6 +865,7 @@ static init_fnc_t init_sequence_f[] = {
x86_fsp_init,
 #endif
arch_cpu_init,  /* basic arch cpu dependent setup */
+   mach_cpu_init,  /* SoC/machine dependent CPU setup */
initf_dm,
arch_cpu_init_dm,
mark_bootstage, /* need timer, go after init dm */
-- 
2.9.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot