Re: [U-Boot] [PATCH v2 01/11] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init

[Wadim Egorov]

Hi Philipp,

Am 18.07.2018 um 11:05 schrieb Dr. Philipp Tomsich:
> Janine,
>
>> On 18 Jul 2018, at 10:46, Janine Hagemann  wrote:
>>
>> At start-up, the regulators have to be enabled. Let's use
>> regulators_enable_boot_on() to enable the regulators needed
>> for boot.
>>
>> Signed-off-by: Wadim Egorov 
>> Signed-off-by: Janine Hagemann 
> An equivalent change from Carlo has already been applied to U-Boot master.
> Please review whether there’s additional changes needed, otherwise I’ll just
> skip this one when processing.
I don't see this patch on master. Anyway, Carlos patch enables the
regulators only for the google veyrons.

Regards,
Wadim

>
> Thanks,
> Philipp.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 01/11] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init

[Dr. Philipp Tomsich]

Janine,

> On 18 Jul 2018, at 10:46, Janine Hagemann  wrote:
> 
> At start-up, the regulators have to be enabled. Let's use
> regulators_enable_boot_on() to enable the regulators needed
> for boot.
> 
> Signed-off-by: Wadim Egorov 
> Signed-off-by: Janine Hagemann 

An equivalent change from Carlo has already been applied to U-Boot master.
Please review whether there’s additional changes needed, otherwise I’ll just
skip this one when processing.

Thanks,
Philipp.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 01/11] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init

[Janine Hagemann]

At start-up, the regulators have to be enabled. Let's use
regulators_enable_boot_on() to enable the regulators needed
for boot.

Signed-off-by: Wadim Egorov 
Signed-off-by: Janine Hagemann 
---
v2: No changes
---
 arch/arm/mach-rockchip/rk3288-board.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/mach-rockchip/rk3288-board.c 
b/arch/arm/mach-rockchip/rk3288-board.c
index 8c128d4..759bfbe 100644
--- a/arch/arm/mach-rockchip/rk3288-board.c
+++ b/arch/arm/mach-rockchip/rk3288-board.c
@@ -159,6 +159,12 @@ err:
 #else
int ret;
 
+   ret = regulators_enable_boot_on(false);
+   if (ret) {
+   debug("%s: Cannot enable boot on regulator\n", __func__);
+   return ret;
+   }
+
/* We do some SoC one time setting here */
if (!fdt_node_check_compatible(gd->fdt_blob, 0, "google,veyron")) {
ret = veyron_init();
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot