Re: [U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-10 Thread Benoît Thébaudeau
Hi Stefano, On Saturday, November 10, 2012 8:42:24 AM, Stefano Babic wrote: On 08/11/2012 21:27, Benoît Thébaudeau wrote: The EHCI definitions in i.MX31's imx-regs.h are MXC-generic, so move them to ehci-fsl.h so that all MXC SoCs can use them. Signed-off-by: Benoît Thébaudeau

Re: [U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-10 Thread Albert ARIBAUD
Hi Benoît, On Sat, 10 Nov 2012 13:37:12 +0100 (CET), Benoît Thébaudeau benoit.thebaud...@advansee.com wrote: Hi Stefano, On Saturday, November 10, 2012 8:42:24 AM, Stefano Babic wrote: On 08/11/2012 21:27, Benoît Thébaudeau wrote: The EHCI definitions in i.MX31's imx-regs.h are

Re: [U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-10 Thread Albert ARIBAUD
I'll let Stefano give a definitive answer of course, but I personally prefer that comments be moved before the defines. Note: I mean that each comment should precede its corresponding define, of course; I don't want all these comments lumped together in a single block. Amicalement, -- Albert.

Re: [U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-10 Thread Benoît Thébaudeau
On Saturday, November 10, 2012 1:47:51 PM, Albert ARIBAUD wrote: I'll let Stefano give a definitive answer of course, but I personally prefer that comments be moved before the defines. Note: I mean that each comment should precede its corresponding define, of course; I don't want all

Re: [U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-10 Thread stefano babic
Am 10/11/2012 13:37, schrieb Benoît Thébaudeau: Hi Stefano, On Saturday, November 10, 2012 8:42:24 AM, Stefano Babic wrote: On 08/11/2012 21:27, Benoît Thébaudeau wrote: The EHCI definitions in i.MX31's imx-regs.h are MXC-generic, so move them to ehci-fsl.h so that all MXC SoCs can use

Re: [U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-09 Thread Stefano Babic
On 08/11/2012 21:27, Benoît Thébaudeau wrote: The EHCI definitions in i.MX31's imx-regs.h are MXC-generic, so move them to ehci-fsl.h so that all MXC SoCs can use them. Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com Cc: Marek Vasut ma...@denx.de Cc: Stefano Babic

[U-Boot] [PATCH v2 01/13] mx31: Move EHCI definitions to ehci-fsl.h

2012-11-08 Thread Benoît Thébaudeau
The EHCI definitions in i.MX31's imx-regs.h are MXC-generic, so move them to ehci-fsl.h so that all MXC SoCs can use them. Signed-off-by: Benoît Thébaudeau benoit.thebaud...@advansee.com Cc: Marek Vasut ma...@denx.de Cc: Stefano Babic sba...@denx.de --- Changes for v2: None.