[U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread dirk . eibach
From: Dirk Eibach eib...@gdsys.de Signed-off-by: Dirk Eibach dirk.eib...@gdsys.cc --- Changes in v2: - fpga_state has been moved to arch_global_data - include cmd_fpgad in iocon - use multibus soft-i2c in iocon board/gdsys/405ep/iocon.c | 253 ++---

Re: [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread Wolfgang Denk
Dear dirk.eib...@gdsys.cc, In message 1367847325-21463-6-git-send-email-dirk.eib...@gdsys.cc you wrote: From: Dirk Eibach eib...@gdsys.de Signed-off-by: Dirk Eibach dirk.eib...@gdsys.cc --- Changes in v2: - fpga_state has been moved to arch_global_data - include cmd_fpgad in iocon -

Re: [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread Dirk Eibach
Dear Wolfgang, Dear dirk.eib...@gdsys.cc, In message 1367847325-21463-6-git-send-email-dirk.eib...@gdsys.cc you wrote: From: Dirk Eibach eib...@gdsys.de Signed-off-by: Dirk Eibach dirk.eib...@gdsys.cc --- Changes in v2: - fpga_state has been moved to arch_global_data - include cmd_fpgad in

Re: [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread Wolfgang Denk
Dear Dirk Eibach, In message 49d89b84e14cf375d9e113fcc15ce...@gdsys.cc you wrote: Please fix the checkpatch errors. if we are talking about: CHECK: Blank lines aren't necessary before a close brace '}' #491: FILE: include/configs/iocon.h:141: + +#define CONFIG_SYS_CH7301_I2C

Re: [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread Dirk Eibach
Hi Wolfgang, Dear Dirk Eibach, In message 49d89b84e14cf375d9e113fcc15ce...@gdsys.cc you wrote: Please fix the checkpatch errors. if we are talking about: CHECK: Blank lines aren't necessary before a close brace '}' #491: FILE: include/configs/iocon.h:141: + +#define CONFIG_SYS_CH7301_I2C

Re: [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread Wolfgang Denk
Dear Dirk, In message 3628fded6de7e6b4286d3444a7e5e...@gdsys.cc you wrote: total: 3 errors, 0 warnings, 509 lines checked OK, thanks, that makes sense. Which version of checkpatch are you using? Latest u-boot master checkpatch/patman does not show these (at least not for me). It does

Re: [U-Boot] [PATCH v2 05/10] powerpc/ppc4xx: Support gdsys multichannel iocon hardware

2013-05-06 Thread Joe Hershberger
Hi Wolfgang, On Mon, May 6, 2013 at 2:15 PM, Wolfgang Denk w...@denx.de wrote: Dear Dirk, In message 3628fded6de7e6b4286d3444a7e5e...@gdsys.cc you wrote: total: 3 errors, 0 warnings, 509 lines checked OK, thanks, that makes sense. Which version of checkpatch are you using? Latest u-boot