Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
Hi Marek, On 14-09-2012 19:21, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt [...] +#include common.h +#include nand.h +#include

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Scott Wood
On 09/17/2012 11:57:57 AM, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves,

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
On 09/17/12 10:03, Scott Wood wrote: On 09/17/2012 11:57:57 AM, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Scott Wood
On 09/17/2012 12:08:17 PM, Tom Rini wrote: On 09/17/12 10:03, Scott Wood wrote: Weak symbols are not OK for configuring printf out of the SPL, as you'll still have all the format strings and caller code in the binary. It should be a macro (or an inline function that replaces the standard

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, José Miguel Gonçalves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos?

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, José Miguel Gonçalves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves wrote: On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, Jos? Miguel Gon?alves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos?

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 19:27, Tom Rini wrote: On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves wrote: On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, Jos? Miguel Gon?alves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16,

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 11:34, José Miguel Gonçalves wrote: On 17-09-2012 19:27, Tom Rini wrote: On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves wrote: On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-16 Thread José Miguel Gonçalves
On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by:

[U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros instead of magic numbers ---

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Marek Vasut
Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt [...] +#include common.h +#include nand.h +#include asm/io.h +#include asm/arch/s3c24xx_cpu.h

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread José Miguel Gonçalves
On 14-09-2012 19:21, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt [...] +#include common.h +#include nand.h +#include asm/io.h

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 06:29:00PM +0100, Jos?? Miguel Gon??alves wrote: NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: Jos?? Miguel Gon??alves jose.goncal...@inov.pt [snip] +#ifdef CONFIG_SPL_BUILD +#define printf(arg...) do

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: Jos? Miguel Gon?alves

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Scott Wood
On Fri, Sep 14, 2012 at 08:21:11PM +0200, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt [...] +#include common.h

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 02:24:48PM -0500, Scott Wood wrote: On Fri, Sep 14, 2012 at 08:21:11PM +0200, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: Jos? Miguel

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Scott Wood
On Fri, Sep 14, 2012 at 01:20:32PM -0700, Tom Rini wrote: On Fri, Sep 14, 2012 at 02:24:48PM -0500, Scott Wood wrote: On Fri, Sep 14, 2012 at 08:21:11PM +0200, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only