Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-05-30 Thread Rik Smith
Chin Liang See clsee at altera.com writes: To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within include/configs folder. Signed-off-by: Chin Liang See clsee at altera.com Cc: Artem Bityutskiy

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-05-30 Thread Masahiro Yamada
Hi Rik, On Fri, 30 May 2014 10:50:39 + (UTC) Rik Smith rsm...@optos.com wrote: Chin Liang See clsee at altera.com writes: To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Chin Liang See
On Mon, 2014-03-03 at 18:03 -0600, Scott Wood wrote: On Fri, 2014-02-21 at 14:51 -0600, Chin Liang See wrote: To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within include/configs folder.

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Chin Liang See
Hi Masahiro, On Tue, 2014-03-04 at 19:31 +0900, Masahiro Yamada wrote: Hello Scott, Chin, +/* this is a helper macro that allows us to + * format the bank into the proper bits for the controller */ +#define BANK(x) ((x) 24) + +/* Interrupts are cleared by writing a 1 to the

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Scott Wood
On Wed, 2014-03-05 at 11:34 -0600, Chin Liang See wrote: On Mon, 2014-03-03 at 18:03 -0600, Scott Wood wrote: On Fri, 2014-02-21 at 14:51 -0600, Chin Liang See wrote: To add the Denali NAND driver support into U-Boot. It required information such as register base address from

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Chin Liang See
On Wed, 2014-03-05 at 12:23 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 11:34 -0600, Chin Liang See wrote: On Mon, 2014-03-03 at 18:03 -0600, Scott Wood wrote: On Fri, 2014-02-21 at 14:51 -0600, Chin Liang See wrote: To add the Denali NAND driver support into U-Boot. It required

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Scott Wood
On Wed, 2014-03-05 at 17:01 -0600, Chin Liang See wrote: On Wed, 2014-03-05 at 12:23 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 11:34 -0600, Chin Liang See wrote: On Mon, 2014-03-03 at 18:03 -0600, Scott Wood wrote: On Fri, 2014-02-21 at 14:51 -0600, Chin Liang See wrote: Why

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Chin Liang See
On Wed, 2014-03-05 at 17:04 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 17:01 -0600, Chin Liang See wrote: On Wed, 2014-03-05 at 12:23 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 11:34 -0600, Chin Liang See wrote: On Mon, 2014-03-03 at 18:03 -0600, Scott Wood wrote: On Fri,

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Scott Wood
On Wed, 2014-03-05 at 17:09 -0600, Chin Liang See wrote: On Wed, 2014-03-05 at 17:04 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 17:01 -0600, Chin Liang See wrote: On Wed, 2014-03-05 at 12:23 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 11:34 -0600, Chin Liang See wrote: On

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-05 Thread Chin Liang See
On Wed, 2014-03-05 at 17:11 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 17:09 -0600, Chin Liang See wrote: On Wed, 2014-03-05 at 17:04 -0600, Scott Wood wrote: On Wed, 2014-03-05 at 17:01 -0600, Chin Liang See wrote: On Wed, 2014-03-05 at 12:23 -0600, Scott Wood wrote: On Wed,

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-04 Thread Masahiro Yamada
Hello Scott, Chin, +/* this is a helper macro that allows us to + * format the bank into the proper bits for the controller */ +#define BANK(x) ((x) 24) + +/* Interrupts are cleared by writing a 1 to the appropriate status bit */ +static inline void clear_interrupt(uint32_t

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-04 Thread Scott Wood
On Tue, 2014-03-04 at 19:31 +0900, Masahiro Yamada wrote: Hello Scott, Chin, +/* this is a helper macro that allows us to + * format the bank into the proper bits for the controller */ +#define BANK(x) ((x) 24) + +/* Interrupts are cleared by writing a 1 to the appropriate

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-04 Thread Chin Liang See
On Fri, 2014-02-28 at 11:37 +0100, Michal Simek wrote: +/* lld_nand.h */ +/* + * NAND Flash Controller Device Driver + * Copyright (c) 2009, Intel Corporation and its suppliers. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-04 Thread Chin Liang See
Hi Masahiro, On Fri, 2014-02-28 at 21:57 +0900, Masahiro Yamada wrote: Hello Chin, Where do you set nand-ecc.strength? I believe this is only applicable for NAND_ECC_HW_SYNDROME mode. We are using the NAND_ECC_HW (without the syndrome). Wonder you hit error during run?

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-04 Thread Michal Simek
On 03/05/2014 12:57 AM, Chin Liang See wrote: On Fri, 2014-02-28 at 11:37 +0100, Michal Simek wrote: +/* lld_nand.h */ +/* + * NAND Flash Controller Device Driver + * Copyright (c) 2009, Intel Corporation and its suppliers. + * + * This program is free software; you can redistribute it

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-03-03 Thread Scott Wood
On Fri, 2014-02-21 at 14:51 -0600, Chin Liang See wrote: To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within include/configs folder. Signed-off-by: Chin Liang See cl...@altera.com Cc: Artem

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-28 Thread Michal Simek
+/* lld_nand.h */ +/* + * NAND Flash Controller Device Driver + * Copyright (c) 2009, Intel Corporation and its suppliers. + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-28 Thread Masahiro Yamada
Hello Chin, Where do you set nand-ecc.strength? I believe this is only applicable for NAND_ECC_HW_SYNDROME mode. We are using the NAND_ECC_HW (without the syndrome). Wonder you hit error during run? No, it must always be set for hardware ECC. Note the lack of a break;

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-27 Thread Masahiro Yamada
Hello Chin, + + nand-ecc.mode = NAND_ECC_HW; + nand-ecc.size = CONFIG_NAND_DENALI_ECC_SIZE; + nand-ecc.read_oob = denali_read_oob; + nand-ecc.write_oob = denali_write_oob; + nand-ecc.read_page = denali_read_page; + nand-ecc.read_page_raw = denali_read_page_raw; +

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-27 Thread Chin Liang See
Hi Michal, On Mon, 2014-02-24 at 08:48 +0100, Michal Simek wrote: On 02/21/2014 09:51 PM, Chin Liang See wrote: To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within include/configs folder.

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-27 Thread Chin Liang See
Hi Masahiro, On Thu, 2014-02-27 at 23:35 +0900, Masahiro Yamada wrote: Hello Chin, + + nand-ecc.mode = NAND_ECC_HW; + nand-ecc.size = CONFIG_NAND_DENALI_ECC_SIZE; + nand-ecc.read_oob = denali_read_oob; + nand-ecc.write_oob = denali_write_oob; + nand-ecc.read_page =

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-27 Thread Scott Wood
On Thu, 2014-02-27 at 15:02 -0600, Chin Liang See wrote: Hi Masahiro, On Thu, 2014-02-27 at 23:35 +0900, Masahiro Yamada wrote: Hello Chin, + + nand-ecc.mode = NAND_ECC_HW; + nand-ecc.size = CONFIG_NAND_DENALI_ECC_SIZE; + nand-ecc.read_oob = denali_read_oob; +

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-27 Thread Chin Liang See
Hi Scott, On Thu, 2014-02-27 at 16:32 -0600, Scott Wood wrote: On Thu, 2014-02-27 at 15:02 -0600, Chin Liang See wrote: Hi Masahiro, On Thu, 2014-02-27 at 23:35 +0900, Masahiro Yamada wrote: Hello Chin, + + nand-ecc.mode = NAND_ECC_HW; + nand-ecc.size =

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-24 Thread Masahiro Yamada
Hello Michal, These files were imported from Linux Kernel. (drivers/mtd/nand/denali.[ch]) I guess Chin does not want to change the code unless it is really necessary. (And I like this way. We can easily find which parts were adjusted by diffing.) But, good catch! I think your feedback is

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-24 Thread Michal Simek
Hi Masahiro. On 02/24/2014 09:06 AM, Masahiro Yamada wrote: Hello Michal, These files were imported from Linux Kernel. (drivers/mtd/nand/denali.[ch]) then they should be fixed too. Or better fix kernel driver first and then add these changes to u-boot. Checkpatch in the u-boot is just the

Re: [U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-23 Thread Michal Simek
On 02/21/2014 09:51 PM, Chin Liang See wrote: To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within include/configs folder. Signed-off-by: Chin Liang See cl...@altera.com Cc: Artem Bityutskiy

[U-Boot] [PATCH v2 1/2] nand/denali: Adding Denali NAND driver support

2014-02-21 Thread Chin Liang See
To add the Denali NAND driver support into U-Boot. It required information such as register base address from configuration header file within include/configs folder. Signed-off-by: Chin Liang See cl...@altera.com Cc: Artem Bityutskiy artem.bityuts...@linux.intel.com Cc: David Woodhouse