Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Mark, On 2/6/19 5:42 PM, Jonas Mark (BT-FIR/ENG1) wrote: >> If I understand the original issue you had correctly, could it also have >> been fixed by renaming splash node in FIT image? > Yes, that's we actually started with. But once we started adding more > files to that FIT image we saw the

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Tomas, > >> So my initial question still stands, could existing implementation be > >> kept as fallback? > >> > >> + if (!splash_file) > >> + splash_file = location->name; > >> > >> location->name has worked fine for those cases, so it would be nice > >> location->to > >> keep that

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

On 2/5/19 5:29 PM, Mark Jonas wrote: > From: Leo Ruan > > The splash image could be loaded from different sources (e.g. sf, mmc) > with different formats (e.g. raw, file-system). These sources are > structured by a board dependent object 'splash_location'. To decide > where is the splash image

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Mark, On 2/6/19 4:30 PM, Jonas Mark (BT-FIR/ENG1) wrote: > >> So my initial question still stands, could existing implementation be kept >> as fallback? >> >> +if (!splash_file) >> +splash_file = location->name; >> >> location->name has worked fine for those cases, so it would

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Tomas, > > I conclude that no upstream board is actually affected. They would only > be affecte if they would use SPLASH_STORAGE_FIT. > > You are right, indeed upstream boards should be ok. However, some > other non upstream boards I know of would be affected. > > So my initial question

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Thomas, On 06/02/19 14:44, Melin Tomas wrote: > Hi Mark, > >>> Could fallback here instead be "location->name" as before, keeping >>> compability with the current implementation? I.e. >>> >>> + if (!splash_file) >>> + splash_file = location->name; >> Can you point me to the 3

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Mark, >> Could fallback here instead be "location->name" as before, keeping >> compability with the current implementation? I.e. >> >> +if (!splash_file) >> +splash_file = location->name; > Can you point me to the 3 upstream boards which are relying on this? > > Is it

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi Tomas, > > + /* Get the splash image node */ > > + splash_file = env_get("splashfile"); > > + if (!splash_file) > > + splash_file = SPLASH_SOURCE_DEFAULT_FILE_NAME; > > + > > + node_offset = fit_image_get_node(fit_header, splash_file); > > It looks like this will break

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

Hi, On 2/5/19 5:29 PM, Mark Jonas wrote: > From: Leo Ruan > > > common/splash_source.c | 10 -- > doc/README.splashprepare | 9 ++--- > 2 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/common/splash_source.c b/common/splash_source.c > index 62763b9..e1e73db

Re: [U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

On 05/02/19 16:29, Mark Jonas wrote: > From: Leo Ruan > > The splash image could be loaded from different sources (e.g. sf, mmc) > with different formats (e.g. raw, file-system). These sources are > structured by a board dependent object 'splash_location'. To decide > where is the splash image

[U-Boot] [PATCH v2 1/2] splash: Use splashfile instead of location->name

From: Leo Ruan The splash image could be loaded from different sources (e.g. sf, mmc) with different formats (e.g. raw, file-system). These sources are structured by a board dependent object 'splash_location'. To decide where is the splash image loaded, following environment variables are used