Re: [U-Boot] [PATCH v2 2/6] cbfs: Move declarations above functions

2019-08-18 Thread Bin Meng
On Fri, Aug 16, 2019 at 10:42 PM Bin Meng wrote: > > On Thu, Aug 15, 2019 at 9:56 AM Simon Glass wrote: > > > > At present this file has a function at the top, above declarations. This > > is normally avoided, so fix it. > > > > Signed-off-by: Simon Glass > > Reviewed-by: Bin Meng > > --- > >

Re: [U-Boot] [PATCH v2 2/6] cbfs: Move declarations above functions

2019-08-16 Thread Bin Meng
On Thu, Aug 15, 2019 at 9:56 AM Simon Glass wrote: > > At present this file has a function at the top, above declarations. This > is normally avoided, so fix it. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > fs/cbfs/cbfs.c | 14 +- > 1

[U-Boot] [PATCH v2 2/6] cbfs: Move declarations above functions

2019-08-14 Thread Simon Glass
At present this file has a function at the top, above declarations. This is normally avoided, so fix it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None fs/cbfs/cbfs.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/fs/cbfs/cbfs.c