Re: [U-Boot] [PATCH v2 2/6] cbfs: Move declarations above functions

[Bin Meng]

On Fri, Aug 16, 2019 at 10:42 PM Bin Meng  wrote:
>
> On Thu, Aug 15, 2019 at 9:56 AM Simon Glass  wrote:
> >
> > At present this file has a function at the top, above declarations. This
> > is normally avoided, so fix it.
> >
> > Signed-off-by: Simon Glass 
> > Reviewed-by: Bin Meng 
> > ---
> >
> > Changes in v2: None
> >
> >  fs/cbfs/cbfs.c | 14 +-
> >  1 file changed, 5 insertions(+), 9 deletions(-)
> >
>
> Tested-by: Bin Meng 

applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/6] cbfs: Move declarations above functions

[Bin Meng]

On Thu, Aug 15, 2019 at 9:56 AM Simon Glass  wrote:
>
> At present this file has a function at the top, above declarations. This
> is normally avoided, so fix it.
>
> Signed-off-by: Simon Glass 
> Reviewed-by: Bin Meng 
> ---
>
> Changes in v2: None
>
>  fs/cbfs/cbfs.c | 14 +-
>  1 file changed, 5 insertions(+), 9 deletions(-)
>

Tested-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 2/6] cbfs: Move declarations above functions

[Simon Glass]

At present this file has a function at the top, above declarations. This
is normally avoided, so fix it.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng 
---

Changes in v2: None

 fs/cbfs/cbfs.c | 14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/fs/cbfs/cbfs.c b/fs/cbfs/cbfs.c
index af4d3c5e56..2a9edcc9a0 100644
--- a/fs/cbfs/cbfs.c
+++ b/fs/cbfs/cbfs.c
@@ -9,6 +9,11 @@
 #include 
 
 enum cbfs_result file_cbfs_result;
+static const u32 good_magic = 0x4f524243;
+static const u8 good_file_magic[] = "LARCHIVE";
+static int initialized;
+static struct cbfs_header cbfs_header;
+static struct cbfs_cachenode *file_cache;
 
 const char *file_cbfs_error(void)
 {
@@ -28,15 +33,6 @@ const char *file_cbfs_error(void)
}
 }
 
-
-static const u32 good_magic = 0x4f524243;
-static const u8 good_file_magic[] = "LARCHIVE";
-
-
-static int initialized;
-static struct cbfs_header cbfs_header;
-static struct cbfs_cachenode *file_cache;
-
 /* Do endian conversion on the CBFS header structure. */
 static void swap_header(struct cbfs_header *dest, struct cbfs_header *src)
 {
-- 
2.23.0.rc1.153.gdeed80330f-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot