Re: [U-Boot] [PATCH v2 28/50] x86: sysreset: Separate out the EFI code

On 5/1/19 3:42 PM, Bin Meng wrote: +Heinrich, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: The EFI implementation of reset sits inside the driver and is called directly from outside the driver, breaking the normal driver-model conventions. Worse, it passed NULL as the device pointer,

Re: [U-Boot] [PATCH v2 28/50] x86: sysreset: Separate out the EFI code

+Heinrich, On Fri, Apr 26, 2019 at 12:00 PM Simon Glass wrote: > > The EFI implementation of reset sits inside the driver and is called > directly from outside the driver, breaking the normal driver-model > conventions. Worse, it passed NULL as the device pointer, hoping that > the called

[U-Boot] [PATCH v2 28/50] x86: sysreset: Separate out the EFI code

The EFI implementation of reset sits inside the driver and is called directly from outside the driver, breaking the normal driver-model conventions. Worse, it passed NULL as the device pointer, hoping that the called function won't use it, which breaks as soon as code is added to use it. Separate