Re: [U-Boot] [PATCH v3] Support for multiple SGMII/TBI interfaces for TSEC ethernet

2008-09-15 Thread Peter Tyser
On Mon, 2008-09-15 at 16:13 -0500, Andy Fleming wrote: @@ -299,12 +301,10 @@ static int init_phy(struct eth_device *dev) { struct tsec_private *priv = (struct tsec_private *)dev-priv; struct phy_info *curphy; - volatile tsec_t *phyregs = priv-phyregs;

Re: [U-Boot] [PATCH v3] Support for multiple SGMII/TBI interfaces for TSEC ethernet

2008-09-15 Thread Peter Tyser
Hi Andy, @@ -299,12 +301,10 @@ static int init_phy(struct eth_device *dev) { struct tsec_private *priv = (struct tsec_private *)dev-priv; struct phy_info *curphy; - volatile tsec_t *phyregs = priv-phyregs; volatile tsec_t *regs = priv-regs;

Re: [U-Boot] [PATCH v3] Support for multiple SGMII/TBI interfaces for TSEC ethernet

2008-09-10 Thread Ben Warren
Andy, You're much more qualified than me to accept or reject this, so if you don't mind, please pick it up. regards, Ben Peter Tyser wrote: Fix TBI PHY accesses to use the proper offset in CPU register space. The previous code would incorrectly access the TBI PHY by reading/writing to CPU