Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-09 Thread Ian Campbell
On Tue, 2014-07-08 at 09:47 +0200, Hans de Goede wrote: Have you looked at extending the SPL buildsys bits, which in essence do 2 builds, to do 3 builds for sunxi, so that we simply always build both SPL flavors? I hadn't thought of it. Is it only the SPL binary which differs between FEL and

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-09 Thread Hans de Goede
Hi, On 07/09/2014 10:00 AM, Ian Campbell wrote: On Tue, 2014-07-08 at 09:47 +0200, Hans de Goede wrote: Have you looked at extending the SPL buildsys bits, which in essence do 2 builds, to do 3 builds for sunxi, so that we simply always build both SPL flavors? I hadn't thought of it. Is it

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-09 Thread Henrik Nordström
ons 2014-07-09 klockan 09:00 +0100 skrev Ian Campbell: I hadn't thought of it. Is it only the SPL binary which differs between FEL and non-FEL then? There is also a small difference in the default environment to enable boot-from-RAM in the FEL version of main u-boot. This is not enabled in the

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-09 Thread Hans de Goede
Hi, On 07/09/2014 03:03 PM, Henrik Nordström wrote: ons 2014-07-09 klockan 09:00 +0100 skrev Ian Campbell: I hadn't thought of it. Is it only the SPL binary which differs between FEL and non-FEL then? There is also a small difference in the default environment to enable boot-from-RAM in

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-08 Thread Ian Campbell
On Mon, 2014-07-07 at 16:45 -0400, Tom Rini wrote: On Mon, Jul 07, 2014 at 09:23:13PM +0100, Ian Campbell wrote: On Mon, 2014-07-07 at 12:47 -0400, Tom Rini wrote: That's not how we like things to look however when we can help it. Just toss a __maybe_unused in front of the declaration

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-08 Thread Hans de Goede
Hi, On 07/07/2014 05:13 PM, Ian Campbell wrote: On Mon, 2014-07-07 at 14:53 +0200, Hans de Goede wrote: Hi, On 07/06/2014 09:26 PM, Ian Campbell wrote: On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: adds sun4i and sun5i support Does this series omit FEL mode support or did you

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-08 Thread Hans de Goede
Hi, On 07/07/2014 10:23 PM, Ian Campbell wrote: On Mon, 2014-07-07 at 12:47 -0400, Tom Rini wrote: That's not how we like things to look however when we can help it. Just toss a __maybe_unused in front of the declaration (and make sure we have linux/compiler.h included. OK. How about the

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-08 Thread Tom Rini
On Tue, Jul 08, 2014 at 08:23:11AM +0100, Ian Campbell wrote: On Mon, 2014-07-07 at 16:45 -0400, Tom Rini wrote: On Mon, Jul 07, 2014 at 09:23:13PM +0100, Ian Campbell wrote: On Mon, 2014-07-07 at 12:47 -0400, Tom Rini wrote: That's not how we like things to look however when we can help

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Hans de Goede
Hi Ian, On 07/06/2014 09:12 PM, Ian Campbell wrote: On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: Here is v2 of my patch series to be applied on top of Ian's recently merged basic sun7i support. For the A13-OLinuXinoM and r7-tv-dongle with this series I'm seeing:

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Hans de Goede
Hi, On 07/06/2014 09:26 PM, Ian Campbell wrote: On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: adds sun4i and sun5i support Does this series omit FEL mode support or did you just not include it for the new boards? I just did not include it. I think in general we want a _FEL

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Tom Rini
On Mon, Jul 07, 2014 at 02:53:44PM +0200, Hans de Goede wrote: Hi, On 07/06/2014 09:26 PM, Ian Campbell wrote: On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: adds sun4i and sun5i support Does this series omit FEL mode support or did you just not include it for the new

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Ian Campbell
On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote: AFAIK we will never define both EMAC and GMAC for the same board, If we are sure of this (and I suspect this is the case, since IIRC they share some pins) then I agree with your suggestion. so IMHO a better fix would be to change this

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Ian Campbell
On Mon, 2014-07-07 at 14:53 +0200, Hans de Goede wrote: Hi, On 07/06/2014 09:26 PM, Ian Campbell wrote: On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: adds sun4i and sun5i support Does this series omit FEL mode support or did you just not include it for the new boards? I

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Tom Rini
On Mon, Jul 07, 2014 at 04:10:42PM +0100, Ian Campbell wrote: On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote: AFAIK we will never define both EMAC and GMAC for the same board, If we are sure of this (and I suspect this is the case, since IIRC they share some pins) then I agree with

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Ian Campbell
On Mon, 2014-07-07 at 12:47 -0400, Tom Rini wrote: That's not how we like things to look however when we can help it. Just toss a __maybe_unused in front of the declaration (and make sure we have linux/compiler.h included. OK. How about the following? Hans, BTW, I spotted this issue with:

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-07 Thread Tom Rini
On Mon, Jul 07, 2014 at 09:23:13PM +0100, Ian Campbell wrote: On Mon, 2014-07-07 at 12:47 -0400, Tom Rini wrote: That's not how we like things to look however when we can help it. Just toss a __maybe_unused in front of the declaration (and make sure we have linux/compiler.h included.

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Ian Campbell
On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: Here is v2 of my patch series to be applied on top of Ian's recently merged basic sun7i support. For the A13-OLinuXinoM and r7-tv-dongle with this series I'm seeing: arch/arm/cpu/armv7/sunxi/board.c: In function ‘cpu_eth_init’:

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Albert ARIBAUD
Hi Ian, Slightly off-topic, but... When you provide some code excerpt, you should make sure it doesn't look like a git patch, because if it does, then our Patchwork, which reads the list, will think it is actually a patch submission: http://patchwork.ozlabs.org/patch/367391/ Amicalement,

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Ian Campbell
On Sun, 2014-07-06 at 21:18 +0200, Albert ARIBAUD wrote: Hi Ian, Slightly off-topic, but... When you provide some code excerpt, you should make sure it doesn't look like a git patch, because if it does, then our Patchwork, which reads the list, will think it is actually a patch submission:

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Ian Campbell
On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: adds sun4i and sun5i support Does this series omit FEL mode support or did you just not include it for the new boards? I think in general we want a _FEL variant for every board except the minority which don't have an OTG port etc. Ian.

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Albert ARIBAUD
Hi Ian, On Sun, 06 Jul 2014 20:22:31 +0100, Ian Campbell i...@hellion.org.uk wrote: On Sun, 2014-07-06 at 21:18 +0200, Albert ARIBAUD wrote: Hi Ian, Slightly off-topic, but... When you provide some code excerpt, you should make sure it doesn't look like a git patch, because if it does,

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Ian Campbell
On Sun, 2014-07-06 at 22:54 +0200, Albert ARIBAUD wrote: Hi Ian, On Sun, 06 Jul 2014 20:22:31 +0100, Ian Campbell i...@hellion.org.uk wrote: On Sun, 2014-07-06 at 21:18 +0200, Albert ARIBAUD wrote: Hi Ian, Slightly off-topic, but... When you provide some code excerpt, you

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-07-06 Thread Wolfgang Denk
Dear Ian Campbell, In message 1404682080.11284.33.ca...@dagon.hellion.org.uk you wrote: Oh, I didn't mean to suggest skipping all that good stuff, just that the patch is already in a local branch ready to go when it is acked so I don't need to fetch it from patchwork. It is a very good

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-06-27 Thread Stefan Roese
On 26.06.2014 09:38, Ian Campbell wrote: (re-adding Hans whose CC I seem to have dropped somehow, sorry) On Wed, 2014-06-25 at 20:57 +0100, Ian Campbell wrote: Hi Albert, Any comments on these sunxi series from Hans and myself? I wonder if Hans and I should be applying for a

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-06-26 Thread Ian Campbell
(re-adding Hans whose CC I seem to have dropped somehow, sorry) On Wed, 2014-06-25 at 20:57 +0100, Ian Campbell wrote: Hi Albert, Any comments on these sunxi series from Hans and myself? I wonder if Hans and I should be applying for a u-boot-sunxi.git custodian tree[0]? Ian. [0]

Re: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-06-25 Thread Ian Campbell
Hi Albert, Any comments on these sunxi series from Hans and myself? Thanks, Ian. On Mon, 2014-06-09 at 11:36 +0200, Hans de Goede wrote: Hi All, Here is v2 of my patch series to be applied on top of Ian's recently merged basic sun7i support. This patch series begins with a few bug fixes

[U-Boot] [PATCH v3 00/10] sunxi: Bug fixes, sun4i and sun5i support and network improvements

2014-06-09 Thread Hans de Goede
Hi All, Here is v2 of my patch series to be applied on top of Ian's recently merged basic sun7i support. This patch series begins with a few bug fixes found while working on preparing the rest of the series, adds sun4i and sun5i support and rounds things of with some networking fixes /