Re: [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic

[Maxime Ripard]

On Wed, Feb 28, 2018 at 08:51:42PM +0100, Miquel Raynal wrote:
> Hello,
> 
> This series first adds fixes and enhancements to sunxi NAND drivers (SPL
> and U-Boot). Once this is done, the SPL NAND driver is converted to use
> PIO instead of DMA with the goal to support all SoCs with this IP
> without the need for DMA-related code. Finally, NAND support is added to
> Nintendo NES Classic through Kconfig and DT additions.
> 
> Thanks,
> Miquèl

Merged every thing, thanks for your stubborn^W patience on this one :)

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic

[Maxime Ripard]

On Mon, Mar 12, 2018 at 05:33:57PM -0500, Scott Wood wrote:
> On Wed, 2018-03-07 at 08:57 +0100, Maxime Ripard wrote:
> > Hi Scott,
> > 
> > On Wed, Feb 28, 2018 at 08:51:42PM +0100, Miquel Raynal wrote:
> > > This series first adds fixes and enhancements to sunxi NAND drivers (SPL
> > > and U-Boot). Once this is done, the SPL NAND driver is converted to use
> > > PIO instead of DMA with the goal to support all SoCs with this IP
> > > without the need for DMA-related code. Finally, NAND support is added to
> > > Nintendo NES Classic through Kconfig and DT additions.
> > 
> > Should we merge it through the sunxi tree, or do you want to merge
> > these changes through yours?
> 
> The sunxi tree.  I'm not really involved much with U-Boot these days.

Ok, that works for me, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic

[Scott Wood]

On Wed, 2018-03-07 at 08:57 +0100, Maxime Ripard wrote:
> Hi Scott,
> 
> On Wed, Feb 28, 2018 at 08:51:42PM +0100, Miquel Raynal wrote:
> > This series first adds fixes and enhancements to sunxi NAND drivers (SPL
> > and U-Boot). Once this is done, the SPL NAND driver is converted to use
> > PIO instead of DMA with the goal to support all SoCs with this IP
> > without the need for DMA-related code. Finally, NAND support is added to
> > Nintendo NES Classic through Kconfig and DT additions.
> 
> Should we merge it through the sunxi tree, or do you want to merge
> these changes through yours?

The sunxi tree.  I'm not really involved much with U-Boot these days.

-Scott

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic

[Maxime Ripard]

Hi Scott,

On Wed, Feb 28, 2018 at 08:51:42PM +0100, Miquel Raynal wrote:
> This series first adds fixes and enhancements to sunxi NAND drivers (SPL
> and U-Boot). Once this is done, the SPL NAND driver is converted to use
> PIO instead of DMA with the goal to support all SoCs with this IP
> without the need for DMA-related code. Finally, NAND support is added to
> Nintendo NES Classic through Kconfig and DT additions.

Should we merge it through the sunxi tree, or do you want to merge
these changes through yours?

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic

[Maxime Ripard]

Hi,

On Wed, Feb 28, 2018 at 08:51:42PM +0100, Miquel Raynal wrote:
> This series first adds fixes and enhancements to sunxi NAND drivers (SPL
> and U-Boot). Once this is done, the SPL NAND driver is converted to use
> PIO instead of DMA with the goal to support all SoCs with this IP
> without the need for DMA-related code. Finally, NAND support is added to
> Nintendo NES Classic through Kconfig and DT additions.

For the whole serie,
Acked-by: Maxime Ripard 

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic

[Miquel Raynal]

Hello,

This series first adds fixes and enhancements to sunxi NAND drivers (SPL
and U-Boot). Once this is done, the SPL NAND driver is converted to use
PIO instead of DMA with the goal to support all SoCs with this IP
without the need for DMA-related code. Finally, NAND support is added to
Nintendo NES Classic through Kconfig and DT additions.

Thanks,
Miquèl


Changes since v2:
=
  - Added Boris and Maxime Acked-by tags.
  - Removed extra space in nand_reset_column()
  - Fixed the useless wait period on failure in nand_change_column().
  - Changed the title "sunxi: allow NAND support to be compiled for..."
(removed the "in SPL" precision which is wrong).
  - Enbraced the deassertion of the reset line by #if statements about
the SoCs in use. Wolfgang Denk made a comment on my proposal but I
could not find a better solution, so I kept it for now.
  - s/alwinner,[pin,functions]/[pin,functions]/ in the DT.
  - Change Alwinner-specific parts in the SPL to generic sentences.

Changes since v1:
=

All:

  - Enhance all commit messages.
  - Rebased on top of master branch (I should have done that earlier but
I forgot I was on an old revision).

Fix binman_sym output check
---
  - SPL seems to be broken for a few weeks when using raw NAND, fix it
by changing the error condition.

Fix strength

  - Add comment explaining the added line and moved the line for
clarification on why it is needed.
  - Add forgotten Boris' Suggested-by tag.

Fix second case of modulo by zero  error

  - Added a reference to the first occurence of this issue.

Allow SPL to be compiled for sun8i platforms

  - This commit is not about compiling the SPL, but the NAND support in
the SPL, as corrected by Maxime.

Enhancements and cleaning
-
  - Patch split into several logical chunks, as requested.
  - Removed useless udelay(1), that was added for debugging purpose.
  - Introduced the nand_exec_cmd() helper to mutualize code one step
further.
  - Add an udelay(1) after changing the column to respect the minimum
tCCS delay (Change Column Setup time).
  - Canceled moving to global scope the ecc_strength array.

Use PIO instead of DMA
--
  - Change commit message/title.
  - Cancel removing NFC related definitions: they can be useful as the
this IP is quite under-documented.
  - Merge nand_reset_column and nand_change_column (in another patch).
  - Moved the copy of the data after the check of the ECC status.
  - ECC chunks are read manually, return if the first chunk is empty
only (needed for configuration research), otherwise it should not be
treated as an error.

Add NAND node to sun8i
--
  - U-Boot master branch already has this node, remove the patch.

Enable NAND on NES classic
--
  - Change the DT cells size from 2 to 1.

Add NAND support for NES classic

  - Split in several patches, moving SPL_NAND_SUPPORT and NAND_SUNXI out
of the defconfig files (NES and CHIP pro) to be automatically
selected depending on NAND_SUNXI and ARCH_SUNXI.
  - Moved the NAND parameters to Kconfig (only for SUNXI because the
tool did not work as expected, maybe due to some definitions that
are not "numbers" but multiplications and sometimes use other
definitions (NAND page size, 2K_SZ, etc).


Miquel Raynal (20):
  spl: fix binman_sym output check
  mtd: nand: sunxi: fix ECC strength choice
  spl: nand: sunxi: fix second case of modulo by zero error
  spl: nand: sunxi: fix typo on register name
  spl: nand: sunxi: introduce the nand_wait_int() helper
  spl: nand: sunxi: introduce the nand_wait_cmd_fifo_empty() helper
  spl: nand: sunxi: add missing status clear
  spl: nand: sunxi: create an helper to handle command execution
  spl: nand: sunxi: ensure enough time has passed after changing the
column
  spl: nand: sunxi: make the reset column helper more generic
  sunxi: spl: deassert the NAND controller reset line
  spl: nand: sunxi: declare the ecc_bytes array globally
  spl: nand: sunxi: use PIO instead of DMA
  sunxi: spl: remove DMA related settings of the NAND controller
  sunxi: allow NAND support to be compiled for sun8i platforms
  sunxi: dts: enable NAND on NES classic
  sunxi: automatically select SPL_NAND_SUPPORT in Kconfig
  sunxi: make NAND_SUNXI use ARCH_SUNXI as default in Kconfig
  sunxi: move the NAND parameters to Kconfig
  configs: add NAND support for NES Classic

 arch/arm/dts/sun8i-a23-a33.dtsi|  17 ++
 .../dts/sun8i-r16-nintendo-nes-classic-edition.dts |  14 ++
 arch/arm/include/asm/arch-sunxi/clock_sun6i.h  |   6 +
 board/sunxi/board.c|   7 +-
 common/spl/spl.c   |  10 +-
 configs/CHIP_pro_defconfig