Re: [U-Boot] [PATCH v3 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option

2016-06-08 Thread Igor Grinberg
Hi Heiko,

On 06/07/2016 09:31 AM, Heiko Schocher wrote:
> move CONFIG_BOOTDELAY into a Kconfig option. Used for this
> purpose the moveconfig.py tool in tools.

That's great! Finally, someone did this long long patch!
It has been sitting in my queue for about a year... and I never
had the time to rework it.

> 
> Signed-off-by: Heiko Schocher 
> 
> Reviewed-by: Tom Rini 

Acked-by: Igor Grinberg 

Thanks!

-- 
Regards,
Igor.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v3 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option

2016-06-07 Thread Viresh Kumar
On 07-06-16, 08:31, Heiko Schocher wrote:
> move CONFIG_BOOTDELAY into a Kconfig option. Used for this
> purpose the moveconfig.py tool in tools.
> 
> Signed-off-by: Heiko Schocher 
> 
> Reviewed-by: Tom Rini 
> ---
> 
> Changes in v3:
> - add reviewed-by from Tom Rini and
>   rebase against Prepare v2016.07-rc1 as Tom suggestd:
>   b104b3dc1dd90cdbf67ccf3c51b06e4f1592fe91
> 
> Changes in v2:
> - add comment from Viresh:
>   remove strange ifdef after deleting CONFIG_BOOTDELAY
>   This may change behaviour, but as the define CONFIG_SPEAR_USBTTY
>   is not defined in mainline code, I think, it does not break
>   mainlined boards.
> - add comment from Tom Rini:
>   set default value from CONFIG_BOOTDELAY to 2 seconds.
> 
>  include/configs/spear-common.h |  6 

Acked-by: Viresh Kumar 

-- 
viresh
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot