Re: [U-Boot] [PATCH v3 07/10] samsung: Drop board_enable_audio_codec()

[sjg]

On 12/01/19 10:37, Simon Glass wrote:
> This function is not needed now since the audio codecs have been converted
> to proper drivers. The codec-enable GPIO is handled there.
>
> Signed-off-by: Simon Glass 
> Reviewed-by: Lukasz Majewski 
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  board/samsung/common/exynos5-dt.c | 29 -
>  1 file changed, 29 deletions(-)
>
Applied to u-boot-dm, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 07/10] samsung: Drop board_enable_audio_codec()

[Minkyu Kang]

On 12/01/19 10:37, Simon Glass wrote:
> This function is not needed now since the audio codecs have been converted
> to proper drivers. The codec-enable GPIO is handled there.
> 
> Signed-off-by: Simon Glass 
> Reviewed-by: Lukasz Majewski 
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  board/samsung/common/exynos5-dt.c | 29 -
>  1 file changed, 29 deletions(-)
> 
> diff --git a/board/samsung/common/exynos5-dt.c 
> b/board/samsung/common/exynos5-dt.c
> index c183965b92..87eb381345 100644
> --- a/board/samsung/common/exynos5-dt.c
> +++ b/board/samsung/common/exynos5-dt.c
> @@ -34,37 +34,8 @@
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> -static void board_enable_audio_codec(void)
> -{
> - int node, ret;
> - struct gpio_desc en_gpio;
> -
> - node = fdtdec_next_compatible(gd->fdt_blob, 0,
> - COMPAT_SAMSUNG_EXYNOS5_SOUND);
> - if (node <= 0)
> - return;
> -
> - ret = gpio_request_by_name_nodev(offset_to_ofnode(node),
> -  "codec-enable-gpio", 0, _gpio,
> -  GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
> - if (ret == -FDT_ERR_NOTFOUND)
> - return;
> -
> - /* Turn on the GPIO which connects to the codec's "enable" line. */
> - gpio_set_pull(gpio_get_number(_gpio), S5P_GPIO_PULL_NONE);
> -
> -#ifdef CONFIG_SOUND_MAX98095
> - /* Enable MAX98095 Codec */
> - gpio_request(EXYNOS5_GPIO_X17, "max98095_enable");
> - gpio_direction_output(EXYNOS5_GPIO_X17, 1);
> - gpio_set_pull(EXYNOS5_GPIO_X17, S5P_GPIO_PULL_NONE);
> -#endif
> -}
> -
>  int exynos_init(void)
>  {
> - board_enable_audio_codec();
> -
>   return 0;
>  }
>  
> 

Reviewed-by: Minkyu Kang 

Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v3 07/10] samsung: Drop board_enable_audio_codec()

[Simon Glass]

This function is not needed now since the audio codecs have been converted
to proper drivers. The codec-enable GPIO is handled there.

Signed-off-by: Simon Glass 
Reviewed-by: Lukasz Majewski 
---

Changes in v3: None
Changes in v2: None

 board/samsung/common/exynos5-dt.c | 29 -
 1 file changed, 29 deletions(-)

diff --git a/board/samsung/common/exynos5-dt.c 
b/board/samsung/common/exynos5-dt.c
index c183965b92..87eb381345 100644
--- a/board/samsung/common/exynos5-dt.c
+++ b/board/samsung/common/exynos5-dt.c
@@ -34,37 +34,8 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-static void board_enable_audio_codec(void)
-{
-   int node, ret;
-   struct gpio_desc en_gpio;
-
-   node = fdtdec_next_compatible(gd->fdt_blob, 0,
-   COMPAT_SAMSUNG_EXYNOS5_SOUND);
-   if (node <= 0)
-   return;
-
-   ret = gpio_request_by_name_nodev(offset_to_ofnode(node),
-"codec-enable-gpio", 0, _gpio,
-GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE);
-   if (ret == -FDT_ERR_NOTFOUND)
-   return;
-
-   /* Turn on the GPIO which connects to the codec's "enable" line. */
-   gpio_set_pull(gpio_get_number(_gpio), S5P_GPIO_PULL_NONE);
-
-#ifdef CONFIG_SOUND_MAX98095
-   /* Enable MAX98095 Codec */
-   gpio_request(EXYNOS5_GPIO_X17, "max98095_enable");
-   gpio_direction_output(EXYNOS5_GPIO_X17, 1);
-   gpio_set_pull(EXYNOS5_GPIO_X17, S5P_GPIO_PULL_NONE);
-#endif
-}
-
 int exynos_init(void)
 {
-   board_enable_audio_codec();
-
return 0;
 }
 
-- 
2.20.1.97.g81188d93c3-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot