Re: [U-Boot] [PATCH v3 17/17] odroid: config: enable dm pmic, dm regulator and max77686 driver

2015-04-03 Thread Przemyslaw Marczak

Hello Simon,

On 03/29/2015 03:10 PM, Simon Glass wrote:

On 24 March 2015 at 14:30, Przemyslaw Marczak p.marc...@samsung.com wrote:

This change enables the configs required to init and setup max77686
regulator driver, using the new driver model pmic and regulator API.

This commits enables:
- CONFIG_ERRNO_STR
- CONFIG_DM_PMIC
- CONFIG_DM_PMIC_CMD
- CONFIG_DM_PMIC_MAX77686
- CONFIG_DM_REGULATOR
- CONFIG_DM_REGULATOR_CMD
- CONFIG_DM_REGULATOR_MAX77686

And removes the unused:
- CONFIG_DM_I2C_COMPAT
- CONFIG_POWER
- CONFIG_POWER_I2C
- CONFIG_POWER_MAX77686

Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com


Acked-by: Simon Glass s...@chromium.org

(but pelase rename the commands so that they are CONFIG_CMD_DM_PCI and
CONFIG_CMD_DM_REGULATOR)



Yes, will do this.


---
Changes V2:
- config: enable dm i2c; cleanup
- remove CONFIG_DM_I2C_COMPAT
- enable regulator command

Changes V3:
- move options to defconfig
---
  configs/odroid_defconfig | 8 +++-
  include/configs/odroid.h | 5 -
  2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/configs/odroid_defconfig b/configs/odroid_defconfig
index d32b5b5..1e29abe 100644
--- a/configs/odroid_defconfig
+++ b/configs/odroid_defconfig
@@ -4,5 +4,11 @@ CONFIG_TARGET_ODROID=y
  CONFIG_OF_CONTROL=y
  CONFIG_DEFAULT_DEVICE_TREE=exynos4412-odroid
  CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_ERRNO_STR=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_CMD=y
+CONFIG_DM_PMIC_MAX77686=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_CMD=y
+CONFIG_DM_REGULATOR_MAX77686=y
diff --git a/include/configs/odroid.h b/include/configs/odroid.h
index 5ee0abe..3874baa 100644
--- a/include/configs/odroid.h
+++ b/include/configs/odroid.h
@@ -182,11 +182,6 @@
  #define CONFIG_SYS_I2C_S3C24X0_SPEED   10
  #define CONFIG_SYS_I2C_S3C24X0_SLAVE   0

-/* POWER */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-#define CONFIG_POWER_MAX77686
-
  /* GPT */
  #define CONFIG_RANDOM_UUID

--
1.9.1





Thanks,
--
Przemyslaw Marczak
Samsung RD Institute Poland
Samsung Electronics
p.marc...@samsung.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v3 17/17] odroid: config: enable dm pmic, dm regulator and max77686 driver

2015-03-29 Thread Simon Glass
On 24 March 2015 at 14:30, Przemyslaw Marczak p.marc...@samsung.com wrote:
 This change enables the configs required to init and setup max77686
 regulator driver, using the new driver model pmic and regulator API.

 This commits enables:
 - CONFIG_ERRNO_STR
 - CONFIG_DM_PMIC
 - CONFIG_DM_PMIC_CMD
 - CONFIG_DM_PMIC_MAX77686
 - CONFIG_DM_REGULATOR
 - CONFIG_DM_REGULATOR_CMD
 - CONFIG_DM_REGULATOR_MAX77686

 And removes the unused:
 - CONFIG_DM_I2C_COMPAT
 - CONFIG_POWER
 - CONFIG_POWER_I2C
 - CONFIG_POWER_MAX77686

 Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com

Acked-by: Simon Glass s...@chromium.org

(but pelase rename the commands so that they are CONFIG_CMD_DM_PCI and
CONFIG_CMD_DM_REGULATOR)

 ---
 Changes V2:
 - config: enable dm i2c; cleanup
 - remove CONFIG_DM_I2C_COMPAT
 - enable regulator command

 Changes V3:
 - move options to defconfig
 ---
  configs/odroid_defconfig | 8 +++-
  include/configs/odroid.h | 5 -
  2 files changed, 7 insertions(+), 6 deletions(-)

 diff --git a/configs/odroid_defconfig b/configs/odroid_defconfig
 index d32b5b5..1e29abe 100644
 --- a/configs/odroid_defconfig
 +++ b/configs/odroid_defconfig
 @@ -4,5 +4,11 @@ CONFIG_TARGET_ODROID=y
  CONFIG_OF_CONTROL=y
  CONFIG_DEFAULT_DEVICE_TREE=exynos4412-odroid
  CONFIG_DM_I2C=y
 -CONFIG_DM_I2C_COMPAT=y
  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 +CONFIG_ERRNO_STR=y
 +CONFIG_DM_PMIC=y
 +CONFIG_DM_PMIC_CMD=y
 +CONFIG_DM_PMIC_MAX77686=y
 +CONFIG_DM_REGULATOR=y
 +CONFIG_DM_REGULATOR_CMD=y
 +CONFIG_DM_REGULATOR_MAX77686=y
 diff --git a/include/configs/odroid.h b/include/configs/odroid.h
 index 5ee0abe..3874baa 100644
 --- a/include/configs/odroid.h
 +++ b/include/configs/odroid.h
 @@ -182,11 +182,6 @@
  #define CONFIG_SYS_I2C_S3C24X0_SPEED   10
  #define CONFIG_SYS_I2C_S3C24X0_SLAVE   0

 -/* POWER */
 -#define CONFIG_POWER
 -#define CONFIG_POWER_I2C
 -#define CONFIG_POWER_MAX77686
 -
  /* GPT */
  #define CONFIG_RANDOM_UUID

 --
 1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v3 17/17] odroid: config: enable dm pmic, dm regulator and max77686 driver

2015-03-24 Thread Przemyslaw Marczak
This change enables the configs required to init and setup max77686
regulator driver, using the new driver model pmic and regulator API.

This commits enables:
- CONFIG_ERRNO_STR
- CONFIG_DM_PMIC
- CONFIG_DM_PMIC_CMD
- CONFIG_DM_PMIC_MAX77686
- CONFIG_DM_REGULATOR
- CONFIG_DM_REGULATOR_CMD
- CONFIG_DM_REGULATOR_MAX77686

And removes the unused:
- CONFIG_DM_I2C_COMPAT
- CONFIG_POWER
- CONFIG_POWER_I2C
- CONFIG_POWER_MAX77686

Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com
---
Changes V2:
- config: enable dm i2c; cleanup
- remove CONFIG_DM_I2C_COMPAT
- enable regulator command

Changes V3:
- move options to defconfig
---
 configs/odroid_defconfig | 8 +++-
 include/configs/odroid.h | 5 -
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/configs/odroid_defconfig b/configs/odroid_defconfig
index d32b5b5..1e29abe 100644
--- a/configs/odroid_defconfig
+++ b/configs/odroid_defconfig
@@ -4,5 +4,11 @@ CONFIG_TARGET_ODROID=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE=exynos4412-odroid
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_ERRNO_STR=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_CMD=y
+CONFIG_DM_PMIC_MAX77686=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_CMD=y
+CONFIG_DM_REGULATOR_MAX77686=y
diff --git a/include/configs/odroid.h b/include/configs/odroid.h
index 5ee0abe..3874baa 100644
--- a/include/configs/odroid.h
+++ b/include/configs/odroid.h
@@ -182,11 +182,6 @@
 #define CONFIG_SYS_I2C_S3C24X0_SPEED   10
 #define CONFIG_SYS_I2C_S3C24X0_SLAVE   0
 
-/* POWER */
-#define CONFIG_POWER
-#define CONFIG_POWER_I2C
-#define CONFIG_POWER_MAX77686
-
 /* GPT */
 #define CONFIG_RANDOM_UUID
 
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot