Re: [U-Boot] [PATCH v3 2/4] arm: socfpga: Convert reset manager from struct to defines

2019-10-10 Thread Ley Foon Tan
On Thu, Oct 10, 2019 at 3:14 PM Simon Goldschmidt wrote: > > On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan wrote: > > > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > > to defines. > > A commit message should describe what the commit does. By leaving out the fact > that

Re: [U-Boot] [PATCH v3 2/4] arm: socfpga: Convert reset manager from struct to defines

2019-10-10 Thread Simon Goldschmidt
On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan wrote: > > Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct > to defines. A commit message should describe what the commit does. By leaving out the fact that you're now loading the base address from DTS, you're not describing all

[U-Boot] [PATCH v3 2/4] arm: socfpga: Convert reset manager from struct to defines

2019-10-10 Thread Ley Foon Tan
Convert reset manager for Gen5, Arria 10 and Stratix 10 from struct to defines. Signed-off-by: Ley Foon Tan --- v3: - Remove "No functional change" in commit description. v2: - Get base address from DT - Revert to use writel(), readl(), setbits_le32() and clrbits_le32(). - Add prefix to