Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-11 Thread Doug Anderson
Dear Wolfgang, On Wed, Jan 11, 2012 at 12:11 AM, Wolfgang Denk wrote: > I have to admit that I have no clear opinion here yet. > > The existing code is from a time when all architectures had a pretty > low limit on the command line size - IIRC even PPC had only 256 bytes > by then, hard coded. >

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-11 Thread Wolfgang Denk
Dear Doug, In message you wrote: > > ...I'm still awaiting Wolfgang's suggestion for which of the following > he'd like me to submit instead of this series: > > 1. A stripped down version of the change to use malloc with the caveat > that it's up to the user not to overrun any hardcoded limits

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-10 Thread Mike Frysinger
On Tuesday 10 January 2012 18:48:12 Doug Anderson wrote: > On Tue, Jan 10, 2012 at 3:44 PM, Mike Frysinger wrote: > > On Tuesday 10 January 2012 18:38:07 Doug Anderson wrote: > > getenv returns a writable buffer, so i wonder if things couldn't be > > avoided easily all around. after all, you're j

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-10 Thread Doug Anderson
On Tue, Jan 10, 2012 at 3:44 PM, Mike Frysinger wrote: > On Tuesday 10 January 2012 18:38:07 Doug Anderson wrote: > getenv returns a writable buffer, so i wonder if things couldn't be avoided > easily all around.  after all, you're just deleting bytes here, not adding new > ones. Actually, that's

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-10 Thread Mike Frysinger
On Tuesday 10 January 2012 18:38:07 Doug Anderson wrote: > 3. Something else (?) getenv returns a writable buffer, so i wonder if things couldn't be avoided easily all around. after all, you're just deleting bytes here, not adding new ones. -mike signature.asc Description: This is a digitally

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-10 Thread Doug Anderson
Mike, On Tue, Jan 10, 2012 at 3:27 PM, Mike Frysinger wrote: > not sure why you don't just squash it into 1/3 and never bother defining it ? I was attempting to keep changes isolated as much as possible, but everyone seems to like to do this differently and I'm still getting a feel for what you

Re: [U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-10 Thread Mike Frysinger
On Tuesday 10 January 2012 17:26:22 Doug Anderson wrote: > As Mike Frysinger writes: > We didn't enable silent=1 by default in any of the Blackfin boards > Just made the functionality available to people if they wanted to > test things out with it when prototyping on dev boards. > > --- a/in

[U-Boot] [PATCH v3 3/3] config: Remove Blackfin CONFIG_DEPRECATED_SILENT_LINUX_CONSOLE

2012-01-10 Thread Doug Anderson
As Mike Frysinger writes: We didn't enable silent=1 by default in any of the Blackfin boards Just made the functionality available to people if they wanted to test things out with it when prototyping on dev boards. Signed-off-by: Doug Anderson --- Changes in v3: - Added part 3 of the patch