Re: [U-Boot] [PATCH v3 3/9] clk: actions: Add common clock driver

2019-01-17 Thread André Przywara
On Thu, 17 Jan 2019 20:45:44 +0530 Manivannan Sadhasivam wrote: Hi, > On Tue, Jan 15, 2019 at 12:43:36AM +, André Przywara wrote: > > On 14/01/2019 12:41, Amit Singh Tomar wrote: > > > > Hi, > > > > > CMU block on most of the actions SoC seems to be > > > identical(at-least, S900 and

Re: [U-Boot] [PATCH v3 3/9] clk: actions: Add common clock driver

2019-01-17 Thread Manivannan Sadhasivam
Hi, On Tue, Jan 15, 2019 at 12:43:36AM +, André Przywara wrote: > On 14/01/2019 12:41, Amit Singh Tomar wrote: > > Hi, > > > CMU block on most of the actions SoC seems to be identical(at-least, S900 > > and S700). > > Actually they are not. Not even for the small subset that we implement

Re: [U-Boot] [PATCH v3 3/9] clk: actions: Add common clock driver

2019-01-14 Thread André Przywara
On 14/01/2019 12:41, Amit Singh Tomar wrote: Hi, > CMU block on most of the actions SoC seems to be identical(at-least, S900 and > S700). Actually they are not. Not even for the small subset that we implement here. Try "diff -wu arch/arm/include/asm/arch-owl/regs_s*.h" for a start, plus the

[U-Boot] [PATCH v3 3/9] clk: actions: Add common clock driver

2019-01-14 Thread Amit Singh Tomar
CMU block on most of the actions SoC seems to be identical(at-least, S900 and S700). This patch converts S900 clock driver to something common that can be used for other SoCs, for instance S700(most of clk registres are same). Signed-off-by: Amit Singh Tomar --- Changes since v1: *