Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

2011-01-15 Thread Albert ARIBAUD
Le 12/01/2011 17:49, Alexander Holler a écrit : Signed-off-by: Alexander Holler hol...@ahsoftware.de Signed-off-by: Dirk Behme dirk.be...@googlemail.com Signed-off-by: Wolfgang Denk w...@denx.de Tested-by: Thomas Weber we...@corscience.de Acked-by: Alexander Hollerhol...@ahsoftware.de

Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

2011-01-12 Thread Thomas Weber
Am 09.01.2011 23:19, schrieb Wolfgang Denk: From: Alexander Holler hol...@ahsoftware.de gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Reading C99 6.7.3 8 and the comment 114) there, I think it is a bug of that gcc version to ignore the

Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

2011-01-12 Thread Alexander Holler
Am 09.01.2011 23:19, schrieb Wolfgang Denk: gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Have had a look at the asm generated by gcc 4.5.1, looks good. The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and the writeb in

Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

2011-01-12 Thread Wolfgang Denk
Dear Alexander Holler, In message 4d2dcb18.20...@ahsoftware.de you wrote: Am 09.01.2011 23:19, schrieb Wolfgang Denk: gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Have had a look at the asm generated by gcc 4.5.1, looks good. The

Re: [U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

2011-01-12 Thread Alexander Holler
Am 12.01.2011 17:40, schrieb Wolfgang Denk: Dear Alexander Holler, In message4d2dcb18.20...@ahsoftware.de you wrote: Am 09.01.2011 23:19, schrieb Wolfgang Denk: gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Have had a look at the asm

[U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

2011-01-09 Thread Wolfgang Denk
From: Alexander Holler hol...@ahsoftware.de gcc 4.5.1 seems to ignore (at least some) volatile definitions, avoid that as done in the kernel. Reading C99 6.7.3 8 and the comment 114) there, I think it is a bug of that gcc version to ignore the volatile type qualifier used e.g. in __arch_getl().