Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2016-01-28 Thread Trent Piepho
On Wed, 2016-01-27 at 21:13 +0800, Chin Liang See wrote: > On Wed, 2016-01-27 at 00:01 +, Trent Piepho wrote: > > On Fri, 2015-11-27 at 15:22 +0800, Chin Liang See wrote: > > > Enable SDMMC calibration to determine the best setting for > > > drvsel and smplsel. Calibration will be triggered if

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2016-01-27 Thread Chin Liang See
On Wed, 2016-01-27 at 00:01 +, Trent Piepho wrote: > On Fri, 2015-11-27 at 15:22 +0800, Chin Liang See wrote: > > Enable SDMMC calibration to determine the best setting for > > drvsel and smplsel. Calibration will be triggered if the > > drvsel and smplsel node are not available in DTS. > >

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2016-01-26 Thread Trent Piepho
On Fri, 2015-11-27 at 15:22 +0800, Chin Liang See wrote: > Enable SDMMC calibration to determine the best setting for > drvsel and smplsel. Calibration will be triggered if the > drvsel and smplsel node are not available in DTS. We have a Cyclone V based board and on the latest revision the SD

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-03 Thread Pavel Machek
Hi! > > > OK, this is bad. Originally, if we didn't specify these in the DT, we > > > would > > > use the default values of 0x3 and 0x0 , but now we do the > > > calibration. I wonder, > > > do we care about DT ABI compatibility on the U-Boot level or not ? > > > > If the compatibility failed, it

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-02 Thread Chin Liang See
On Wed, 2015-12-02 at 15:39 +0100, Marek Vasut wrote: > On Wednesday, December 02, 2015 at 06:52:17 AM, Chin Liang See wrote: > > [...] > > > > OK, this is bad. Originally, if we didn't specify these in the > > > DT, we > > > would > > > use the default values of 0x3 and 0x0 , but now we do the

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-02 Thread Marek Vasut
On Wednesday, December 02, 2015 at 04:10:19 PM, Chin Liang See wrote: > On Wed, 2015-12-02 at 15:39 +0100, Marek Vasut wrote: > > On Wednesday, December 02, 2015 at 06:52:17 AM, Chin Liang See wrote: > > > > [...] > > > > > > OK, this is bad. Originally, if we didn't specify these in the > > > >

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-02 Thread Marek Vasut
On Wednesday, December 02, 2015 at 06:52:17 AM, Chin Liang See wrote: [...] > > OK, this is bad. Originally, if we didn't specify these in the DT, we > > would > > use the default values of 0x3 and 0x0 , but now we do the > > calibration. I wonder, > > do we care about DT ABI compatibility on

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-01 Thread Chin Liang See
On Tue, 2015-12-01 at 16:38 +0100, Marek Vasut wrote: > On Tuesday, December 01, 2015 at 04:32:44 PM, Chin Liang See wrote: > > Hi Marek, > > Hi! > > > On Sun, 2015-11-29 at 14:39 +0100, Marek Vasut wrote: > > > On Friday, November 27, 2015 at 08:22:03 AM, Chin Liang See > > > wrote: > > > >

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-01 Thread Marek Vasut
On Tuesday, December 01, 2015 at 04:32:44 PM, Chin Liang See wrote: > Hi Marek, Hi! > On Sun, 2015-11-29 at 14:39 +0100, Marek Vasut wrote: > > On Friday, November 27, 2015 at 08:22:03 AM, Chin Liang See wrote: > > > Enable SDMMC calibration to determine the best setting for > > > drvsel and

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-12-01 Thread Chin Liang See
Hi Marek, On Sun, 2015-11-29 at 14:39 +0100, Marek Vasut wrote: > On Friday, November 27, 2015 at 08:22:03 AM, Chin Liang See wrote: > > Enable SDMMC calibration to determine the best setting for > > drvsel and smplsel. Calibration will be triggered if the > > drvsel and smplsel node are not

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-29 Thread Simon Glass
Hi Marek, On 28 November 2015 at 18:05, Marek Vasut wrote: > On Sunday, November 29, 2015 at 02:59:37 AM, Simon Glass wrote: >> Hi Marek, >> >> On 27 November 2015 at 11:41, Marek Vasut wrote: >> > On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote: >>

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-29 Thread Marek Vasut
On Sunday, November 29, 2015 at 09:19:14 PM, Simon Glass wrote: > Hi Marek, > > On 28 November 2015 at 18:05, Marek Vasut wrote: > > On Sunday, November 29, 2015 at 02:59:37 AM, Simon Glass wrote: > >> Hi Marek, > >> > >> On 27 November 2015 at 11:41, Marek Vasut

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-29 Thread Marek Vasut
On Friday, November 27, 2015 at 08:22:03 AM, Chin Liang See wrote: > Enable SDMMC calibration to determine the best setting for > drvsel and smplsel. Calibration will be triggered if the > drvsel and smplsel node are not available in DTS. > > Signed-off-by: Chin Liang See > Cc:

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-28 Thread Simon Glass
Hi Marek, On 27 November 2015 at 11:41, Marek Vasut wrote: > On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote: >> Hi, >> >> On 26 November 2015 at 23:22, Chin Liang See wrote: >> > Enable SDMMC calibration to determine the best setting for >> >

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-28 Thread Marek Vasut
On Sunday, November 29, 2015 at 02:59:37 AM, Simon Glass wrote: > Hi Marek, > > On 27 November 2015 at 11:41, Marek Vasut wrote: > > On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote: > >> Hi, > >> > >> On 26 November 2015 at 23:22, Chin Liang See

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-27 Thread Simon Glass
Hi, On 26 November 2015 at 23:22, Chin Liang See wrote: > Enable SDMMC calibration to determine the best setting for > drvsel and smplsel. Calibration will be triggered if the > drvsel and smplsel node are not available in DTS. > > Signed-off-by: Chin Liang See

Re: [U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-27 Thread Marek Vasut
On Friday, November 27, 2015 at 07:36:27 PM, Simon Glass wrote: > Hi, > > On 26 November 2015 at 23:22, Chin Liang See wrote: > > Enable SDMMC calibration to determine the best setting for > > drvsel and smplsel. Calibration will be triggered if the > > drvsel and smplsel node

[U-Boot] [PATCH v4] mmc: socfpga_dw_mmc: Enable calibration for drvsel and smplsel

2015-11-26 Thread Chin Liang See
Enable SDMMC calibration to determine the best setting for drvsel and smplsel. Calibration will be triggered if the drvsel and smplsel node are not available in DTS. Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Dinh Nguyen