Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

Hi Wills, On 2015年12月27日 14:28, Wills Wang wrote: +static int ar933x_serial_putc(struct udevice *dev, const char c) +{ +u32 data; + +if (c == '\n') +ar933x_serial_putc(dev, '\r'); remove this, the serial core driver takes care of it + +do { +data =

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

Hi Wills, On 2015年12月26日 21:20, Daniel Schwierzeck wrote: +static int ar933x_serial_probe(struct udevice *dev) +{ + struct ar933x_serial_priv *priv = dev_get_priv(dev); + struct ar933x_serial_platdata *plat = dev_get_platdata(dev); + u32 val; + + priv->regs = plat->regs;

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

Hi Wills, Please note the following, 1. add this uart to drivers/serial/Kconfig . 2. add debug uart support. see include/debug_uart.h . also add it to Kconfig 3. cp linux/Documentation/devicetree/bindings/serial/qca,ar9330-uart.txt u-boot/doc/device-tree-bindings/serial/ 4. to save

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

On 12/26/2015 09:20 PM, Daniel Schwierzeck wrote: Am 25.12.2015 um 19:56 schrieb Wills Wang: Signed-off-by: Wills Wang --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/serial/Makefile| 1 + drivers/serial/serial_ar933x.c | 225

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

Am 26.12.2015 um 17:54 schrieb Wills Wang: > > > On 12/26/2015 09:20 PM, Daniel Schwierzeck wrote: >> >> Am 25.12.2015 um 19:56 schrieb Wills Wang: >>> Signed-off-by: Wills Wang >>> --- >>> >>> Changes in v4: None >>> Changes in v3: None >>> Changes in v2: None >>> >>>

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

Am 25.12.2015 um 19:56 schrieb Wills Wang: > Signed-off-by: Wills Wang > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/serial/Makefile| 1 + > drivers/serial/serial_ar933x.c | 225 >

Re: [U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

On 12/26/2015 09:20 PM, Daniel Schwierzeck wrote: Am 25.12.2015 um 19:56 schrieb Wills Wang: Signed-off-by: Wills Wang --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/serial/Makefile| 1 + drivers/serial/serial_ar933x.c | 225

[U-Boot] [PATCH v4 4/8] mips: ath79: add serial driver for ar933x SOC

Signed-off-by: Wills Wang --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/serial/Makefile| 1 + drivers/serial/serial_ar933x.c | 225 + 2 files changed, 226 insertions(+) create mode 100644