Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-07-02 Thread Scott Wood
Jean-Christophe PLAGNIOL-VILLARD wrote: Scott what do you think? >>> I don't think we should do anything differently from the rest of U-Boot >>> here. >> Well, that's not easy since the rest of U-boot does it in different >> ways, i.e. some boards have the debug stuff and some don't. As an >>

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-07-02 Thread Jean-Christophe PLAGNIOL-VILLARD
On 07:48 Wed 01 Jul , Magnus Lilja wrote: > Hi > > 2009/6/30 Scott Wood : > > Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > +ifeq ($(debug),1) > > +PLATFORM_CPPFLAGS += -DDEBUG > > +endif > > I do not think it's board specific > >>> > >>> And what does that comment

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-30 Thread Magnus Lilja
Hi 2009/6/30 Scott Wood : > Jean-Christophe PLAGNIOL-VILLARD wrote: > > +ifeq ($(debug),1) > +PLATFORM_CPPFLAGS += -DDEBUG > +endif I do not think it's board specific >>> >>> And what does that comment mean? Should I remove this, move it to >>> another file or what? >>> >

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-30 Thread Scott Wood
Jean-Christophe PLAGNIOL-VILLARD wrote: +ifeq ($(debug),1) +PLATFORM_CPPFLAGS += -DDEBUG +endif >>> I do not think it's board specific >> And what does that comment mean? Should I remove this, move it to >> another file or what? >> > Personnaly I'll active it manually in the file not

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:29 Tue 30 Jun , Magnus Lilja wrote: > Hi > > 2009/6/30 Jean-Christophe PLAGNIOL-VILLARD : > >> >> + > >> >> +#include > >> >> +#include > >> >> + > >> >> +#define CCM_CCMR_SETUP               0x074B0BF5 > >> >> +#define CCM_PDR0_SETUP_532MHZ        (PDR0_CSI_PODF(0x1ff) | > >> >> PDR0

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-30 Thread Magnus Lilja
Hi 2009/6/30 Jean-Christophe PLAGNIOL-VILLARD : >> >> + >> >> +#include >> >> +#include >> >> + >> >> +#define CCM_CCMR_SETUP               0x074B0BF5 >> >> +#define CCM_PDR0_SETUP_532MHZ        (PDR0_CSI_PODF(0x1ff) | >> >> PDR0_PER_PODF(7) | \ >> >> +                              PDR0_HSP_POD

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-30 Thread Jean-Christophe PLAGNIOL-VILLARD
> >> + > >> +#include > >> +#include > >> + > >> +#define CCM_CCMR_SETUP               0x074B0BF5 > >> +#define CCM_PDR0_SETUP_532MHZ        (PDR0_CSI_PODF(0x1ff) | > >> PDR0_PER_PODF(7) | \ > >> +                              PDR0_HSP_PODF(3) | PDR0_NFC_PODF(5) |     \ > >> +                  

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-29 Thread Magnus Lilja
Hi 2009/6/29 Jean-Christophe PLAGNIOL-VILLARD : > On 20:50 Sat 13 Jun     , Magnus Lilja wrote: >> Signed-off-by: Magnus Lilja >> --- >>  MAKEALL                                     |    1 + >>  Makefile                                    |   14 +++- >>  board/freescale/mx31pdk/config.mk        

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 20:50 Sat 13 Jun , Magnus Lilja wrote: > Signed-off-by: Magnus Lilja > --- > MAKEALL |1 + > Makefile| 14 +++- > board/freescale/mx31pdk/config.mk |4 + > board/freescale/mx31pdk/lowlevel_init.S

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-29 Thread Magnus Lilja
2009/6/29 Jean-Christophe PLAGNIOL-VILLARD : > On 21:11 Mon 29 Jun     , Magnus Lilja wrote: >> Jean-Christpohe, >> >> Seems like you missed the last part in my series, could you apply this >> one as well? > I've not I've ask Fabio ack before continue the review as you put it as board > Maintainer

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:11 Mon 29 Jun , Magnus Lilja wrote: > Jean-Christpohe, > > Seems like you missed the last part in my series, could you apply this > one as well? I've not I've ask Fabio ack before continue the review as you put it as board Maintainer Best Regards, J.

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-29 Thread Magnus Lilja
Jean-Christpohe, Seems like you missed the last part in my series, could you apply this one as well? Regards, Magnus 2009/6/13 Magnus Lilja : > Signed-off-by: Magnus Lilja > --- >  MAKEALL                                     |    1 + >  Makefile                                    |   14 +++- >

Re: [U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-23 Thread Magnus Lilja
Hi 2009/6/22 Ulrich Gerster : > Hello, > > I'm trying to boot from my board with a i.MX31 and small page (512Byte) NAND > Flash. I applied the patches in v4 which introduce the CONFIG_PRELOADER > macro. The only example I found where this macro is used is in part 6/6 of > the patch. There a sep

[U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-22 Thread Ulrich Gerster
Hello, I'm trying to boot from my board with a i.MX31 and small page (512Byte) NAND Flash. I applied the patches in v4 which introduce the CONFIG_PRELOADER macro. The only example I found where this macro is used is in part 6/6 of the patch. There a separate folder structure in nand_spl for the

[U-Boot] [PATCH v4 6/6] MX31: Add NAND SPL boot support to i.MX31 PDK board.

2009-06-13 Thread Magnus Lilja
Signed-off-by: Magnus Lilja --- MAKEALL |1 + Makefile| 14 +++- board/freescale/mx31pdk/config.mk |4 + board/freescale/mx31pdk/lowlevel_init.S | 114 +++ include/asm-arm/arch