Re: [U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
Dear Simon Glass, On 06/10/14 03:39, Simon Glass wrote: Hi Minkyu, On 1 October 2014 21:44, Simon Glass s...@chromium.org wrote: Hi Minkyu, On 1 October 2014 21:43, Simon Glass s...@chromium.org wrote: This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos4. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these rudimentary of device tree files based on feedback. This series has the side-effect of getting the EC interface working properly on Pit, so the keyboard works. It also provides access to the TPS65090 PMIC, which means that the backlight is enabled. Changes in v5: - Rebase on top of samsung/master Please check this and see if it works for what you need. I suppose the merge will be Albert's problem, but I will do a patch once I know the detla. Actually I see that Albert has pulled this in. So v4 should work for you now. I just tried applying it on u-boot-arm/master and it worked OK. Regards, Simon Hm, I tried to apply. but failed.. Applying: Exynos: Use 900MHz ARM frequency in SPL for peach_pit Applying: exynos5: Enable data cache Applying: cros_ec: power: Add a tunnelled version of the tps65090 driver Applying: cros_ec: exynos: Use the correct tps65090 driver in each case Applying: dm: exynos: Split out the cros_ec drivers Applying: exynos: dts: Add device tree node for cros_ec keyboard Applying: exynos: Rename -dt config files to -common Applying: exynos: Move common exynos settings into a common file Applying: exynos: Move common smdk5420 things to common file Applying: exynos: config: Move cros_ec and tps65090 out of smdk boards Applying: config: Move arndale to use common exynos5250 file Applying: config: Move smdkv310 to use common exynos4 file Applying: samsung: Enable device tree for s5p_goni error: patch failed: arch/arm/Kconfig:547 error: arch/arm/Kconfig: patch does not apply Patch failed at 0013 samsung: Enable device tree for s5p_goni Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
Hi Minkyu, On 7 October 2014 05:24, Minkyu Kang mk7.k...@samsung.com wrote: Dear Simon Glass, On 06/10/14 03:39, Simon Glass wrote: Hi Minkyu, On 1 October 2014 21:44, Simon Glass s...@chromium.org wrote: Hi Minkyu, On 1 October 2014 21:43, Simon Glass s...@chromium.org wrote: This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos4. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these rudimentary of device tree files based on feedback. This series has the side-effect of getting the EC interface working properly on Pit, so the keyboard works. It also provides access to the TPS65090 PMIC, which means that the backlight is enabled. Changes in v5: - Rebase on top of samsung/master Please check this and see if it works for what you need. I suppose the merge will be Albert's problem, but I will do a patch once I know the detla. Actually I see that Albert has pulled this in. So v4 should work for you now. I just tried applying it on u-boot-arm/master and it worked OK. Regards, Simon Hm, I tried to apply. but failed.. Applying: Exynos: Use 900MHz ARM frequency in SPL for peach_pit Applying: exynos5: Enable data cache Applying: cros_ec: power: Add a tunnelled version of the tps65090 driver Applying: cros_ec: exynos: Use the correct tps65090 driver in each case Applying: dm: exynos: Split out the cros_ec drivers Applying: exynos: dts: Add device tree node for cros_ec keyboard Applying: exynos: Rename -dt config files to -common Applying: exynos: Move common exynos settings into a common file Applying: exynos: Move common smdk5420 things to common file Applying: exynos: config: Move cros_ec and tps65090 out of smdk boards Applying: config: Move arndale to use common exynos5250 file Applying: config: Move smdkv310 to use common exynos4 file Applying: samsung: Enable device tree for s5p_goni error: patch failed: arch/arm/Kconfig:547 error: arch/arm/Kconfig: patch does not apply Patch failed at 0013 samsung: Enable device tree for s5p_goni It looks like you still haven't synced up with the ARM tree? In particular there are these patches there that are needed: f1ef2b6 kconfig: move CONFIG_DEFAULT_DEVICE_TREE to kconfig 783e6a7 kconfig: move CONFIG_OF_* to Kconfig I put a bundle here: http://patchwork.ozlabs.org/bundle/sjg/pitv4/ This should apply OK once you sync up with arm again. If you still have problems then, please let me know. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
On 08/10/14 00:14, Simon Glass wrote: Hi Minkyu, On 7 October 2014 05:24, Minkyu Kang mk7.k...@samsung.com wrote: Dear Simon Glass, On 06/10/14 03:39, Simon Glass wrote: Hi Minkyu, On 1 October 2014 21:44, Simon Glass s...@chromium.org wrote: Hi Minkyu, On 1 October 2014 21:43, Simon Glass s...@chromium.org wrote: This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos4. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these rudimentary of device tree files based on feedback. This series has the side-effect of getting the EC interface working properly on Pit, so the keyboard works. It also provides access to the TPS65090 PMIC, which means that the backlight is enabled. Changes in v5: - Rebase on top of samsung/master Please check this and see if it works for what you need. I suppose the merge will be Albert's problem, but I will do a patch once I know the detla. Actually I see that Albert has pulled this in. So v4 should work for you now. I just tried applying it on u-boot-arm/master and it worked OK. Regards, Simon Hm, I tried to apply. but failed.. Applying: Exynos: Use 900MHz ARM frequency in SPL for peach_pit Applying: exynos5: Enable data cache Applying: cros_ec: power: Add a tunnelled version of the tps65090 driver Applying: cros_ec: exynos: Use the correct tps65090 driver in each case Applying: dm: exynos: Split out the cros_ec drivers Applying: exynos: dts: Add device tree node for cros_ec keyboard Applying: exynos: Rename -dt config files to -common Applying: exynos: Move common exynos settings into a common file Applying: exynos: Move common smdk5420 things to common file Applying: exynos: config: Move cros_ec and tps65090 out of smdk boards Applying: config: Move arndale to use common exynos5250 file Applying: config: Move smdkv310 to use common exynos4 file Applying: samsung: Enable device tree for s5p_goni error: patch failed: arch/arm/Kconfig:547 error: arch/arm/Kconfig: patch does not apply Patch failed at 0013 samsung: Enable device tree for s5p_goni It looks like you still haven't synced up with the ARM tree? In particular there are these patches there that are needed: f1ef2b6 kconfig: move CONFIG_DEFAULT_DEVICE_TREE to kconfig 783e6a7 kconfig: move CONFIG_OF_* to Kconfig I put a bundle here: http://patchwork.ozlabs.org/bundle/sjg/pitv4/ This should apply OK once you sync up with arm again. If you still have problems then, please let me know. No. I've sync with arm tree but it failed. and I tried to apply on arm tree directly, it also failed. Please test it. Thanks, Minkyu Kang. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
Hi Minkyu, On 7 October 2014 19:09, Minkyu Kang mk7.k...@samsung.com wrote: On 08/10/14 00:14, Simon Glass wrote: Hi Minkyu, On 7 October 2014 05:24, Minkyu Kang mk7.k...@samsung.com wrote: Dear Simon Glass, On 06/10/14 03:39, Simon Glass wrote: Hi Minkyu, On 1 October 2014 21:44, Simon Glass s...@chromium.org wrote: Hi Minkyu, On 1 October 2014 21:43, Simon Glass s...@chromium.org wrote: This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos4. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these rudimentary of device tree files based on feedback. This series has the side-effect of getting the EC interface working properly on Pit, so the keyboard works. It also provides access to the TPS65090 PMIC, which means that the backlight is enabled. Changes in v5: - Rebase on top of samsung/master Please check this and see if it works for what you need. I suppose the merge will be Albert's problem, but I will do a patch once I know the detla. Actually I see that Albert has pulled this in. So v4 should work for you now. I just tried applying it on u-boot-arm/master and it worked OK. Regards, Simon Hm, I tried to apply. but failed.. Applying: Exynos: Use 900MHz ARM frequency in SPL for peach_pit Applying: exynos5: Enable data cache Applying: cros_ec: power: Add a tunnelled version of the tps65090 driver Applying: cros_ec: exynos: Use the correct tps65090 driver in each case Applying: dm: exynos: Split out the cros_ec drivers Applying: exynos: dts: Add device tree node for cros_ec keyboard Applying: exynos: Rename -dt config files to -common Applying: exynos: Move common exynos settings into a common file Applying: exynos: Move common smdk5420 things to common file Applying: exynos: config: Move cros_ec and tps65090 out of smdk boards Applying: config: Move arndale to use common exynos5250 file Applying: config: Move smdkv310 to use common exynos4 file Applying: samsung: Enable device tree for s5p_goni error: patch failed: arch/arm/Kconfig:547 error: arch/arm/Kconfig: patch does not apply Patch failed at 0013 samsung: Enable device tree for s5p_goni It looks like you still haven't synced up with the ARM tree? In particular there are these patches there that are needed: f1ef2b6 kconfig: move CONFIG_DEFAULT_DEVICE_TREE to kconfig 783e6a7 kconfig: move CONFIG_OF_* to Kconfig I put a bundle here: http://patchwork.ozlabs.org/bundle/sjg/pitv4/ This should apply OK once you sync up with arm again. If you still have problems then, please let me know. No. I've sync with arm tree but it failed. and I tried to apply on arm tree directly, it also failed. Please test it. Having a bit of a guess at what you are doing, since samsung/master still is not synced with arm/master. I tried this: git checkout -b try-samsung samsung/master git pull upstream-arm master and then applied the patches on top of this without errors. Maybe git is automatically fixing them up? I'll send a v6 second with the resulting patches, If that doesn't work, can I ask you please to push your branch to samsung/master so I can be sure of what your base is? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
Hi Minkyu, On 1 October 2014 21:44, Simon Glass s...@chromium.org wrote: Hi Minkyu, On 1 October 2014 21:43, Simon Glass s...@chromium.org wrote: This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos4. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these rudimentary of device tree files based on feedback. This series has the side-effect of getting the EC interface working properly on Pit, so the keyboard works. It also provides access to the TPS65090 PMIC, which means that the backlight is enabled. Changes in v5: - Rebase on top of samsung/master Please check this and see if it works for what you need. I suppose the merge will be Albert's problem, but I will do a patch once I know the detla. Actually I see that Albert has pulled this in. So v4 should work for you now. I just tried applying it on u-boot-arm/master and it worked OK. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
This series tries to unify the Samsung board configs into a few header
files for exynos5 and exynos4.
The purpose is to make it easier to move to driver model. In that case
I would like things like the GPIO drivers and serial drivers to work in
a standard way, and not need to support device tree and platform data at
the same time. That would be quite painful.
Another reason is that the Chrome OS EC drivers are currently included in
boards that don't have a Chrome OS EC. This concern was raised by the
Samsung maintainer (Minkyu) a while back.
There are still a few boards that don't use CONFIG_OF_CONTROL so I have
updated these rudimentary of device tree files based on feedback.
This series has the side-effect of getting the EC interface working
properly on Pit, so the keyboard works. It also provides access to the
TPS65090 PMIC, which means that the backlight is enabled.
Changes in v5:
- Rebase on top of samsung/master
Changes in v4:
- Address review nits from Minkyu
- Make this driver more like the one it came from
- Rebase on top of master (CONFIG_OF settings moved to Kconfig)
- Remove special FET_ERR_NOT_READY etc. as use standard errors
Changes in v3:
- Adjust device tree file based on Robert Baldyga's example
Changes in v2:
- Add new patch to enable keyboard on pit
- Add new patch to split out cros_ec drivers
- Add new patch to use 900MHz ARM frequeny in SPL for peach_pit
- Avoid using a common file, and just add a device tree
- Don't enable the cros_ec on smdk5420
- Fix 'cashe' typo in commit subject
- Fix device tree base addresses
- Leave CONFIG_SERIAL3 in the individual board files
- Leave in a few configs which are not in fact common to all boards
- Reduce the number of common elements to avoid needing #undefs later
- Slightly reword the commit message
Simon Glass (15):
Exynos: Use 900MHz ARM frequency in SPL for peach_pit
exynos5: Enable data cache
cros_ec: power: Add a tunnelled version of the tps65090 driver
cros_ec: exynos: Use the correct tps65090 driver in each case
dm: exynos: Split out the cros_ec drivers
exynos: dts: Add device tree node for cros_ec keyboard
exynos: Rename -dt config files to -common
exynos: Move common exynos settings into a common file
exynos: Move common smdk5420 things to common file
exynos: config: Move cros_ec and tps65090 out of smdk boards
config: Move arndale to use common exynos5250 file
config: Move smdkv310 to use common exynos4 file
samsung: Enable device tree for s5p_goni
samsung: Enable device tree for smdkc100
exynos: Enable pre-relocation malloc()
arch/arm/Kconfig | 13 +-
arch/arm/cpu/armv7/s5pc1xx/Kconfig | 24 +++
arch/arm/dts/Makefile | 3 +
arch/arm/dts/exynos4210-smdkv310.dts | 21 ++
arch/arm/dts/exynos5420-peach-pit.dts | 57 +-
arch/arm/dts/s5pc1xx-goni.dts | 28 +++
arch/arm/dts/s5pc1xx-smdkc100.dts | 29 +++
arch/arm/include/asm/arch-s5pc1xx/periph.h | 61 ++
arch/arm/include/asm/arch-s5pc1xx/pinmux.h | 50 +
configs/s5p_goni_defconfig | 1 +
configs/smdkc100_defconfig | 1 +
drivers/mmc/s5p_sdhci.c| 2 -
drivers/power/pmic/Makefile| 3 +-
drivers/power/pmic/pmic_tps65090_ec.c | 218 +
include/configs/arndale.h | 197 +--
include/configs/{exynos4-dt.h = exynos-common.h} | 110 +++
include/configs/exynos4-common.h | 71 +++
include/configs/{exynos5-dt.h = exynos5-common.h} | 126 ++--
include/configs/exynos5-dt-common.h| 35
.../{exynos5250-dt.h = exynos5250-common.h} | 7 +-
.../configs/{exynos5420.h = exynos5420-common.h} | 22 ++-
include/configs/odroid.h | 4 +-
include/configs/origen.h | 5 +-
include/configs/peach-pit.h| 16 +-
include/configs/s5p_goni.h | 12 +-
include/configs/s5pc210_universal.h| 5 +-
include/configs/smdk5250.h | 23 ++-
include/configs/smdk5420.h | 5 +-
include/configs/smdkc100.h | 9 +
include/configs/smdkv310.h | 63 ++
include/configs/snow.h | 25 ++-
include/configs/trats.h| 6 +-
include/configs/trats2.h | 6 +-
33 files changed, 764 insertions(+), 494 deletions(-)
create mode 100644 arch/arm/cpu/armv7/s5pc1xx/Kconfig
create mode 100644 arch/arm/dts/exynos4210-smdkv310.dts
create mode 100644 arch/arm/dts/s5pc1xx-goni.dts
create mode 100644 arch/arm/dts/s5pc1xx-smdkc100.dts
create mode 100644
Re: [U-Boot] [PATCH v5 0/15] samsung: Use common config files with Samsung boards
Hi Minkyu, On 1 October 2014 21:43, Simon Glass s...@chromium.org wrote: This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos4. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these rudimentary of device tree files based on feedback. This series has the side-effect of getting the EC interface working properly on Pit, so the keyboard works. It also provides access to the TPS65090 PMIC, which means that the backlight is enabled. Changes in v5: - Rebase on top of samsung/master Please check this and see if it works for what you need. I suppose the merge will be Albert's problem, but I will do a patch once I know the detla. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
