Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Ilya Yanok
Hi Joe, On Thu, Aug 30, 2012 at 1:25 AM, Joe Hershberger joe.hershber...@gmail.comwrote: diff --git a/arch/arm/cpu/armv7/omap-common/Makefile b/arch/arm/cpu/armv7/omap-common/Makefile index d37b22d..f042078 100644 --- a/arch/arm/cpu/armv7/omap-common/Makefile +++

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 02:55, Ilya Yanok wrote: Hi Joe, On Thu, Aug 30, 2012 at 1:25 AM, Joe Hershberger joe.hershber...@gmail.com mailto:joe.hershber...@gmail.com wrote: [snip] diff --git a/net/net.c b/net/net.c index e8ff066..bbd1a6d 100644 ---

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Ilya Yanok
Hi Tom, On Mon, Sep 17, 2012 at 9:04 PM, Tom Rini tr...@ti.com wrote: I agree it's not the best place... config_cmd_spl.h sounds a little bit crazy as we don't have any commands at all in SPL... How about config_uncmd_spl.h then and a nice big comment up top Well, it will be at least

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:54, Ilya Yanok wrote: Hi Tom, On Mon, Sep 17, 2012 at 9:04 PM, Tom Rini tr...@ti.com mailto:tr...@ti.com wrote: I agree it's not the best place... config_cmd_spl.h sounds a little bit crazy as we don't have any commands at all

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Ilya Yanok
On Mon, Sep 17, 2012 at 10:07 PM, Tom Rini tr...@ti.com wrote: That's not really about garbage collection in this case (net-spl). I want to disable some functionality of generic net code not some stuff used only by commands implementation. The confusion comes from the fact that this code

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Ilya Yanok
BTW, I'm going to repost this serie soon. Shouldn't I rebase it on top of your SPL rework patches? Where can I find the tree? Regards, Ilya. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 11:10, Ilya Yanok wrote: On Mon, Sep 17, 2012 at 10:07 PM, Tom Rini tr...@ti.com mailto:tr...@ti.com wrote: That's not really about garbage collection in this case (net-spl). I want to disable some functionality of generic net

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-09-17 Thread Ilya Yanok
On Mon, Sep 17, 2012 at 1:55 PM, Ilya Yanok ilya.ya...@cogentembedded.comwrote: +#include common.h +#include net.h +#include asm/omap_common.h What in here needs this header? Looks like it's unneeded. Thanks, I'll remove it. Nope, it's needed for spl_parse_image_header. Regards,

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-08-29 Thread Joe Hershberger
Hi Ilya, On Tue, Aug 7, 2012 at 3:07 AM, Ilya Yanok ilya.ya...@cogentembedded.com wrote: This patch adds support for networking in SPL. Some devices are capable of loading SPL via network so it makes sense to load the main U-Boot binary via network too. This patch tries to use existing

Re: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-08-29 Thread Tom Rini
On 08/29/2012 02:25 PM, Joe Hershberger wrote: [snip] #include common.h +#ifdef CONFIG_SPL_BUILD +/* SPL needs only BOOTP + TFTP so undefine other stuff to save space */ +#undef CONFIG_CMD_DHCP +#undef CONFIG_CMD_CDP +#undef CONFIG_CMD_DNS +#undef CONFIG_CMD_LINK_LOCAL +#undef

[U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL

2012-08-07 Thread Ilya Yanok
This patch adds support for networking in SPL. Some devices are capable of loading SPL via network so it makes sense to load the main U-Boot binary via network too. This patch tries to use existing network code as much as possible. Unfortunately, it depends on environment which in turn depends on