Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-17 Thread Jean-Jacques Hiblot
On 16/05/2018 17:21, Tom Rini wrote: On Wed, May 16, 2018 at 11:04:18AM +0200, Marek Vasut wrote: On 05/16/2018 11:00 AM, Jean-Jacques Hiblot wrote: On 16/05/2018 00:13, Marek Vasut wrote: On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Tom Rini
On Wed, May 16, 2018 at 11:04:18AM +0200, Marek Vasut wrote: > On 05/16/2018 11:00 AM, Jean-Jacques Hiblot wrote: > > > > > > On 16/05/2018 00:13, Marek Vasut wrote: > >> On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: > >>> Hi Marek, > >>> > >>> > >>> On 04/05/2018 21:06, Marek Vasut wrote: >

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Jean-Jacques Hiblot
On 16/05/2018 11:04, Marek Vasut wrote: On 05/16/2018 11:00 AM, Jean-Jacques Hiblot wrote: On 16/05/2018 00:13, Marek Vasut wrote: On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clo

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Marek Vasut
On 05/16/2018 11:00 AM, Jean-Jacques Hiblot wrote: > > > On 16/05/2018 00:13, Marek Vasut wrote: >> On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: >>> Hi Marek, >>> >>> >>> On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? >>> AFAIK there is no clock drive

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Tom Rini
On Wed, May 16, 2018 at 11:00:54AM +0200, Jean-Jacques Hiblot wrote: > > > On 16/05/2018 00:13, Marek Vasut wrote: > >On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: > >>Hi Marek, > >> > >> > >>On 04/05/2018 21:06, Marek Vasut wrote: > >>>Shouldnt the driver turn this on? > >>AFAIK the

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-16 Thread Jean-Jacques Hiblot
On 16/05/2018 00:13, Marek Vasut wrote: On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to i

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-15 Thread Marek Vasut
On 05/15/2018 06:10 PM, Jean-Jacques Hiblot wrote: > Hi Marek, > > > On 04/05/2018 21:06, Marek Vasut wrote: >> >> Shouldnt the driver turn this on? > AFAIK there is no clock driver for the OMAP. So we have to do it > before > the driver is probed. Maybe it's time to impl

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-15 Thread Jean-Jacques Hiblot
+Lokesh On 15/05/2018 18:10, Jean-Jacques Hiblot wrote: Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to implement it instead of piling up t

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-15 Thread Jean-Jacques Hiblot
Hi Marek, On 04/05/2018 21:06, Marek Vasut wrote: Shouldnt the driver turn this on? AFAIK there is no clock driver for the OMAP. So we have to do it before the driver is probed. Maybe it's time to implement it instead of piling up those hacks ? I was thinking along the same lines at some po

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Marek Vasut
On 05/04/2018 07:58 PM, Jean-Jacques Hiblot wrote: > > > On 04/05/2018 17:43, Marek Vasut wrote: >> On 05/04/2018 04:42 PM, Jean-Jacques Hiblot wrote: >>> >>> On 04/05/2018 16:38, Marek Vasut wrote: On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: > For USB ports that use the Driver Mo

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Jean-Jacques Hiblot
On 04/05/2018 17:43, Marek Vasut wrote: On 05/04/2018 04:42 PM, Jean-Jacques Hiblot wrote: On 04/05/2018 16:38, Marek Vasut wrote: On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Marek Vasut
On 05/04/2018 04:42 PM, Jean-Jacques Hiblot wrote: > > > On 04/05/2018 16:38, Marek Vasut wrote: >> On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: >>> For USB ports that use the Driver Model, turn on the clocks during the >>> late init stage. >>> >>> Signed-off-by: Jean-Jacques Hiblot >>> Re

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Jean-Jacques Hiblot
On 04/05/2018 16:38, Marek Vasut wrote: On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tom Rini --- Changes in v5: None Changes in v4: None Changes in

Re: [U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Marek Vasut
On 05/04/2018 04:34 PM, Jean-Jacques Hiblot wrote: > For USB ports that use the Driver Model, turn on the clocks during the > late init stage. > > Signed-off-by: Jean-Jacques Hiblot > Reviewed-by: Tom Rini > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2

[U-Boot] [PATCH v5 4/9] board: ti: dra7xx-evm: turn on USB clocks in late init stage

2018-05-04 Thread Jean-Jacques Hiblot
For USB ports that use the Driver Model, turn on the clocks during the late init stage. Signed-off-by: Jean-Jacques Hiblot Reviewed-by: Tom Rini --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None board/ti/dra7xx/evm.c | 19 +++ 1 file changed,