Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Dr. Philipp Tomsich]

Good catch.  I had a few merge-conflicts when merging that series.
That one might have gotten lost.

> On 8 May 2018, at 12:31, Jonathan Gray  wrote:
> 
> On Tue, May 08, 2018 at 09:41:32AM +0200, Dr. Philipp Tomsich wrote:
>> Kever,
>> 
>> Could you analyse and provide (against master) a patch for this?
>> We???ll need to catch any left-overs from your changes at the start of the 
>> cycle
>> before we try to merge any of the more invasive changes you have in-flight.
>> 
>> Thanks,
>> Philipp.
> 
> The patch in https://patchwork.ozlabs.org/patch/900546/ had a change in
> include/configs/rockchip-common.h which was not included in the commit
> that made it into to tree as c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
> 
> After adding that back it works.
> 
> diff --git a/include/configs/rockchip-common.h 
> b/include/configs/rockchip-common.h
> index dee82ca99d..68e1105a4b 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -7,6 +7,8 @@
> #define _ROCKCHIP_COMMON_H_
> #include 
> 
> +#define CONFIG_SYS_NS16550_MEM32
> +
> #ifndef CONFIG_SPL_BUILD
> 
> /* First try to boot from SD (index 0), then eMMC (index 1) */

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Jonathan Gray]

On Tue, May 08, 2018 at 09:41:32AM +0200, Dr. Philipp Tomsich wrote:
> Kever,
> 
> Could you analyse and provide (against master) a patch for this?
> We???ll need to catch any left-overs from your changes at the start of the 
> cycle
> before we try to merge any of the more invasive changes you have in-flight.
> 
> Thanks,
> Philipp.

The patch in https://patchwork.ozlabs.org/patch/900546/ had a change in
include/configs/rockchip-common.h which was not included in the commit
that made it into to tree as c3c0331db1fb7b1f4ff41e144fc04353b37c785c.

After adding that back it works.

diff --git a/include/configs/rockchip-common.h 
b/include/configs/rockchip-common.h
index dee82ca99d..68e1105a4b 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -7,6 +7,8 @@
 #define _ROCKCHIP_COMMON_H_
 #include 
 
+#define CONFIG_SYS_NS16550_MEM32
+
 #ifndef CONFIG_SPL_BUILD
 
 /* First try to boot from SD (index 0), then eMMC (index 1) */
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Dr. Philipp Tomsich]

Kever,

Could you analyse and provide (against master) a patch for this?
We’ll need to catch any left-overs from your changes at the start of the cycle
before we try to merge any of the more invasive changes you have in-flight.

Thanks,
Philipp.

> On 8 May 2018, at 09:30, Jonathan Gray  wrote:
> 
> On Thu, Apr 26, 2018 at 09:05:37AM +0200, Philipp Tomsich wrote:
>>> All rockchip SoCs can use ns16550 driver, enable it for all
>>> and set SYS_NS16550_MEM32 for all SoCs.
>>> 
>>> Version-changes: 2
>>> - use imply instead of select
>>> 
>>> Signed-off-by: Kever Yang 
>>> Acked-by: Philipp Tomsich 
>>> Reviewed-by: Philipp Tomsich 
>>> ---
>>> 
>>> Changes in v2: None
>>> 
>>> arch/arm/Kconfig  | 1 +
>>> arch/arm/mach-rockchip/Kconfig| 1 -
>>> include/configs/rk3036_common.h   | 3 ---
>>> include/configs/rk3128_common.h   | 2 --
>>> include/configs/rk3188_common.h   | 2 --
>>> include/configs/rk322x_common.h   | 1 -
>>> include/configs/rk3288_common.h   | 2 --
>>> include/configs/rk3328_common.h   | 2 --
>>> include/configs/rk3368_common.h   | 2 --
>>> include/configs/rk3399_common.h   | 2 --
>>> include/configs/rockchip-common.h | 2 ++
>>> include/configs/rv1108_common.h   | 3 ---
>>> 12 files changed, 3 insertions(+), 20 deletions(-)
>>> 
>> 
>> Applied to u-boot-rockchip, thanks!
> 
> With U-Boot 2018.05 there is no serial console output on tinker-rk3288,
> a regression from 2018.03.  I have bisected it to this commit.
> 
> Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and
> eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with
> 2018.05.
> 
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit
> commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c
> Author: Kever Yang  >
> Date:   Thu Apr 19 11:37:09 2018 +0800
> 
>rockchip: enable SYS_NS16550 for all SoCs by default
> 
>All rockchip SoCs can use ns16550 driver, enable it for all
>and set SYS_NS16550_MEM32 for all SoCs.
> 
>Version-changes: 2
>- use imply instead of select
> 
>Signed-off-by: Kever Yang  >
>Acked-by: Philipp Tomsich  >
>Reviewed-by: Philipp Tomsich  >
> 
> :04 04 f7cc8b28ae8179fdc15896bbb55279f205a54008 
> d07108bbf467735f31f31c083a9068dff71da247 M  arch
> :04 04 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 
> 33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M  include

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Jonathan Gray]

On Thu, Apr 26, 2018 at 09:05:37AM +0200, Philipp Tomsich wrote:
> > All rockchip SoCs can use ns16550 driver, enable it for all
> > and set SYS_NS16550_MEM32 for all SoCs.
> > 
> > Version-changes: 2
> > - use imply instead of select
> > 
> > Signed-off-by: Kever Yang 
> > Acked-by: Philipp Tomsich 
> > Reviewed-by: Philipp Tomsich 
> > ---
> > 
> > Changes in v2: None
> > 
> >  arch/arm/Kconfig  | 1 +
> >  arch/arm/mach-rockchip/Kconfig| 1 -
> >  include/configs/rk3036_common.h   | 3 ---
> >  include/configs/rk3128_common.h   | 2 --
> >  include/configs/rk3188_common.h   | 2 --
> >  include/configs/rk322x_common.h   | 1 -
> >  include/configs/rk3288_common.h   | 2 --
> >  include/configs/rk3328_common.h   | 2 --
> >  include/configs/rk3368_common.h   | 2 --
> >  include/configs/rk3399_common.h   | 2 --
> >  include/configs/rockchip-common.h | 2 ++
> >  include/configs/rv1108_common.h   | 3 ---
> >  12 files changed, 3 insertions(+), 20 deletions(-)
> > 
> 
> Applied to u-boot-rockchip, thanks!

With U-Boot 2018.05 there is no serial console output on tinker-rk3288,
a regression from 2018.03.  I have bisected it to this commit.

Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and
eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with
2018.05.

c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit
commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c
Author: Kever Yang 
Date:   Thu Apr 19 11:37:09 2018 +0800

rockchip: enable SYS_NS16550 for all SoCs by default

All rockchip SoCs can use ns16550 driver, enable it for all
and set SYS_NS16550_MEM32 for all SoCs.

Version-changes: 2
- use imply instead of select

Signed-off-by: Kever Yang 
Acked-by: Philipp Tomsich 
Reviewed-by: Philipp Tomsich 

:04 04 f7cc8b28ae8179fdc15896bbb55279f205a54008 
d07108bbf467735f31f31c083a9068dff71da247 M  arch
:04 04 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 
33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M  include
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Philipp Tomsich]

> All rockchip SoCs can use ns16550 driver, enable it for all
> and set SYS_NS16550_MEM32 for all SoCs.
> 
> Version-changes: 2
> - use imply instead of select
> 
> Signed-off-by: Kever Yang 
> Acked-by: Philipp Tomsich 
> Reviewed-by: Philipp Tomsich 
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig  | 1 +
>  arch/arm/mach-rockchip/Kconfig| 1 -
>  include/configs/rk3036_common.h   | 3 ---
>  include/configs/rk3128_common.h   | 2 --
>  include/configs/rk3188_common.h   | 2 --
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 2 --
>  include/configs/rk3328_common.h   | 2 --
>  include/configs/rk3368_common.h   | 2 --
>  include/configs/rk3399_common.h   | 2 --
>  include/configs/rockchip-common.h | 2 ++
>  include/configs/rv1108_common.h   | 3 ---
>  12 files changed, 3 insertions(+), 20 deletions(-)
> 

Applied to u-boot-rockchip, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Philipp Tomsich]

> All rockchip SoCs can use ns16550 driver, enable it for all
> and set SYS_NS16550_MEM32 for all SoCs.
> 
> Version-changes: 2
> - use imply instead of select
> 
> Signed-off-by: Kever Yang 
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig  | 1 +
>  arch/arm/mach-rockchip/Kconfig| 1 -
>  include/configs/rk3036_common.h   | 3 ---
>  include/configs/rk3128_common.h   | 2 --
>  include/configs/rk3188_common.h   | 2 --
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 2 --
>  include/configs/rk3328_common.h   | 2 --
>  include/configs/rk3368_common.h   | 2 --
>  include/configs/rk3399_common.h   | 2 --
>  include/configs/rockchip-common.h | 2 ++
>  include/configs/rv1108_common.h   | 3 ---
>  12 files changed, 3 insertions(+), 20 deletions(-)
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

[Philipp Tomsich]

> All rockchip SoCs can use ns16550 driver, enable it for all
> and set SYS_NS16550_MEM32 for all SoCs.
> 
> Version-changes: 2
> - use imply instead of select
> 
> Signed-off-by: Kever Yang 
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig  | 1 +
>  arch/arm/mach-rockchip/Kconfig| 1 -
>  include/configs/rk3036_common.h   | 3 ---
>  include/configs/rk3128_common.h   | 2 --
>  include/configs/rk3188_common.h   | 2 --
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 2 --
>  include/configs/rk3328_common.h   | 2 --
>  include/configs/rk3368_common.h   | 2 --
>  include/configs/rk3399_common.h   | 2 --
>  include/configs/rockchip-common.h | 2 ++
>  include/configs/rv1108_common.h   | 3 ---
>  12 files changed, 3 insertions(+), 20 deletions(-)
> 

Reviewed-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot