Re: [U-Boot] [i.MX8MM+CCF 08/41] clk: export mux/divider ops
> Subject: Re: [i.MX8MM+CCF 08/41] clk: export mux/divider ops
>
> On Tue, 7 May 2019 13:25:00 +
> Peng Fan wrote:
>
> > > Subject: Re: [i.MX8MM+CCF 08/41] clk: export mux/divider ops
> > >
> > > On Tue, 30 Apr 2019 10:17:58 +
> > > Peng Fan wrote:
> > >
> > > > Export mux/divider ops for composite usage
> > > >
> > > > Signed-off-by: Peng Fan
> > > > ---
> > > > include/linux/clk-provider.h | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/include/linux/clk-provider.h
> > > > b/include/linux/clk-provider.h index 216095d28c..a60cf6e833 100644
> > > > --- a/include/linux/clk-provider.h
> > > > +++ b/include/linux/clk-provider.h
> > > > @@ -83,6 +83,7 @@ struct clk_divider {
> > > > #define CLK_DIVIDER_ROUND_CLOSEST BIT(4)
> > > > #define CLK_DIVIDER_READ_ONLY BIT(5)
> > > > #define CLK_DIVIDER_MAX_AT_ZEROBIT(6)
> > > > +extern const struct clk_ops clk_divider_ops;
> > > >
> > >
> > > Why do we need to export clk_divider_ops? Why iMX8MM requires it?
> >
> >
> > The composite driver will use that to set ops for divider clk inside
> > composite clk.
>
> Please then write a detailed rationale for this change in commit message or a
> comment in the header file.
>
> The one from the original message seems to be not enough.
Will fix in new version.
Thanks,
Peng.
>
>
> > The Linux CCF also exports it.
> >
> > You could check the clk-composite-imx8m and clk-composite driver in
> > this patchset.
> >
> > Regards,
> > Peng.
> >
> > >
> > > > struct clk_fixed_factor {
> > > > struct clk clk;
> > >
> > >
> > >
> > >
> > > Best regards,
> > >
> > > Lukasz Majewski
> > >
> > > --
> > >
> > > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > > lu...@denx.de
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lu...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [i.MX8MM+CCF 08/41] clk: export mux/divider ops
On Tue, 7 May 2019 13:25:00 +
Peng Fan wrote:
> > Subject: Re: [i.MX8MM+CCF 08/41] clk: export mux/divider ops
> >
> > On Tue, 30 Apr 2019 10:17:58 +
> > Peng Fan wrote:
> >
> > > Export mux/divider ops for composite usage
> > >
> > > Signed-off-by: Peng Fan
> > > ---
> > > include/linux/clk-provider.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/linux/clk-provider.h
> > > b/include/linux/clk-provider.h index 216095d28c..a60cf6e833 100644
> > > --- a/include/linux/clk-provider.h
> > > +++ b/include/linux/clk-provider.h
> > > @@ -83,6 +83,7 @@ struct clk_divider {
> > > #define CLK_DIVIDER_ROUND_CLOSESTBIT(4)
> > > #define CLK_DIVIDER_READ_ONLYBIT(5)
> > > #define CLK_DIVIDER_MAX_AT_ZERO BIT(6)
> > > +extern const struct clk_ops clk_divider_ops;
> > >
> >
> > Why do we need to export clk_divider_ops? Why iMX8MM requires it?
>
>
> The composite driver will use that to set ops for divider clk inside
> composite clk.
Please then write a detailed rationale for this change in commit
message or a comment in the header file.
The one from the original message seems to be not enough.
> The Linux CCF also exports it.
>
> You could check the clk-composite-imx8m and clk-composite driver in
> this patchset.
>
> Regards,
> Peng.
>
> >
> > > struct clk_fixed_factor {
> > > struct clk clk;
> >
> >
> >
> >
> > Best regards,
> >
> > Lukasz Majewski
> >
> > --
> >
> > DENX Software Engineering GmbH, Managing Director: Wolfgang
> > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > lu...@denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpGZNo2Ydz6T.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [i.MX8MM+CCF 08/41] clk: export mux/divider ops
> Subject: Re: [i.MX8MM+CCF 08/41] clk: export mux/divider ops
>
> On Tue, 30 Apr 2019 10:17:58 +
> Peng Fan wrote:
>
> > Export mux/divider ops for composite usage
> >
> > Signed-off-by: Peng Fan
> > ---
> > include/linux/clk-provider.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/clk-provider.h
> > b/include/linux/clk-provider.h index 216095d28c..a60cf6e833 100644
> > --- a/include/linux/clk-provider.h
> > +++ b/include/linux/clk-provider.h
> > @@ -83,6 +83,7 @@ struct clk_divider {
> > #define CLK_DIVIDER_ROUND_CLOSEST BIT(4)
> > #define CLK_DIVIDER_READ_ONLY BIT(5)
> > #define CLK_DIVIDER_MAX_AT_ZEROBIT(6)
> > +extern const struct clk_ops clk_divider_ops;
> >
>
> Why do we need to export clk_divider_ops? Why iMX8MM requires it?
The composite driver will use that to set ops for divider clk inside composite
clk.
The Linux CCF also exports it.
You could check the clk-composite-imx8m and clk-composite driver in this
patchset.
Regards,
Peng.
>
> > struct clk_fixed_factor {
> > struct clk clk;
>
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lu...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [i.MX8MM+CCF 08/41] clk: export mux/divider ops
On Tue, 30 Apr 2019 10:17:58 +
Peng Fan wrote:
> Export mux/divider ops for composite usage
>
> Signed-off-by: Peng Fan
> ---
> include/linux/clk-provider.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/clk-provider.h
> b/include/linux/clk-provider.h index 216095d28c..a60cf6e833 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -83,6 +83,7 @@ struct clk_divider {
> #define CLK_DIVIDER_ROUND_CLOSESTBIT(4)
> #define CLK_DIVIDER_READ_ONLYBIT(5)
> #define CLK_DIVIDER_MAX_AT_ZERO BIT(6)
> +extern const struct clk_ops clk_divider_ops;
>
Why do we need to export clk_divider_ops? Why iMX8MM requires it?
> struct clk_fixed_factor {
> struct clk clk;
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgp9RDMflKahU.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [i.MX8MM+CCF 08/41] clk: export mux/divider ops
Export mux/divider ops for composite usage
Signed-off-by: Peng Fan
---
include/linux/clk-provider.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 216095d28c..a60cf6e833 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -83,6 +83,7 @@ struct clk_divider {
#define CLK_DIVIDER_ROUND_CLOSEST BIT(4)
#define CLK_DIVIDER_READ_ONLY BIT(5)
#define CLK_DIVIDER_MAX_AT_ZEROBIT(6)
+extern const struct clk_ops clk_divider_ops;
struct clk_fixed_factor {
struct clk clk;
--
2.16.4
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
