Re: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Wolfgang Denk
Dear Bo Shen, In message <5452ead4.7080...@atmel.com> you wrote: > > I am thinking, whether it be better to keep this file as two copy? This > will remove #ifdef, although a little code duplication. I agree that we should try and minimize #ifdef's, but code duplication is even worse. Best reg

Re: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Heiko Schocher
Hello Bo, Am 31.10.2014 02:50, schrieb Bo Shen: Hi Heiko, On 10/30/2014 04:15 PM, Heiko Schocher wrote: diff --git a/arch/arm/cpu/at91-common/spl.c b/arch/arm/cpu/at91-common/spl.c index 674a470..5c9a3ad 100644 --- a/arch/arm/cpu/at91-common/spl.c +++ b/arch/arm/cpu/at91-common/spl.c I am th

Re: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Bo Shen
Hi Heiko, On 10/30/2014 07:41 PM, Heiko Schocher wrote: Hello Bo, Am 30.10.2014 11:17, schrieb Bo Shen: Hi Heiko, On 10/30/2014 04:15 PM, Heiko Schocher wrote: diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h index 27331ff..5f64583 100644 ---

Re: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Bo Shen
Hi Heiko, On 10/30/2014 04:15 PM, Heiko Schocher wrote: diff --git a/arch/arm/cpu/at91-common/spl.c b/arch/arm/cpu/at91-common/spl.c index 674a470..5c9a3ad 100644 --- a/arch/arm/cpu/at91-common/spl.c +++ b/arch/arm/cpu/at91-common/spl.c I am thinking, whether it be better to keep this file as

Re: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Heiko Schocher
Hello Bo, Am 30.10.2014 11:17, schrieb Bo Shen: Hi Heiko, On 10/30/2014 04:15 PM, Heiko Schocher wrote: diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h index 27331ff..5f64583 100644 --- a/arch/arm/include/asm/arch-at91/at91_pmc.h +++ b/arch/a

Re: [U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Bo Shen
Hi Heiko, On 10/30/2014 04:15 PM, Heiko Schocher wrote: diff --git a/arch/arm/include/asm/arch-at91/at91_pmc.h b/arch/arm/include/asm/arch-at91/at91_pmc.h index 27331ff..5f64583 100644 --- a/arch/arm/include/asm/arch-at91/at91_pmc.h +++ b/arch/arm/include/asm/arch-at91/at91_pmc.h @@ -95,7 +95,7

[U-Boot] [v2 PATCH 10/12] arm, spl, at91: add at91sam9260 and at91sam9g45 spl support

2014-10-30 Thread Heiko Schocher
add support for using spl code on at91sam9260 and at91sam9g45 based boards. Signed-off-by: Heiko Schocher --- Changes in v2: None arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c | 22 +++ arch/arm/cpu/arm926ejs/at91/clock.c| 60 +++ arch/arm/cpu/armv7/at91/clock.c