Re: [U-Boot] Possible bug in s5p_sdhci.c

Hi Matt, On Feb 19, 2015, at 20:31 , Matt Reimer mrei...@sdgsystems.com wrote: The use of SDHCI_CTRL2_SELBASECLK_SHIFT in s5p_sdhci_set_control_reg() seems wrong, because a shifting offset is being used as a mask, not to generate a mask. It's unclear what the original intent was. Below

[U-Boot] Possible bug in s5p_sdhci.c

The use of SDHCI_CTRL2_SELBASECLK_SHIFT in s5p_sdhci_set_control_reg() seems wrong, because a shifting offset is being used as a mask, not to generate a mask. It's unclear what the original intent was. Below is my suggested fix. What think ye? Matt diff --git a/drivers/mmc/s5p_sdhci.c