Re: [U-Boot] doing anything about "bad" Kbuild configuration options?

2019-04-22 Thread Tom Rini
On Fri, Apr 12, 2019 at 12:32:12PM -0400, Robert P. J. Day wrote: > > only a few months ago, i jumped into a discussion regarding Kbuild > config options that were defined in some Kconfig* file, but were > unused anywhere in the source tree: > >

Re: [U-Boot] doing anything about "bad" Kbuild configuration options?

2019-04-12 Thread Robert P. J. Day
On Sat, 13 Apr 2019, Chris Packham wrote: > > On Sat, 13 Apr 2019, 4:56 AM Robert P. J. Day, wrote: >   one of the worst culprits appears to be CONFIG_SPL_BUILD, which > appears all over the tree, but one can see a recent commit that takes > that into account: > > > That's not

Re: [U-Boot] doing anything about "bad" Kbuild configuration options?

2019-04-12 Thread Chris Packham
On Sat, 13 Apr 2019, 4:56 AM Robert P. J. Day, wrote: > one of the worst culprits appears to be CONFIG_SPL_BUILD, which > appears all over the tree, but one can see a recent commit that takes > that into account: > That's not quite right. CONFIG_SPL_BUILD is defined for the Makefile just not

Re: [U-Boot] doing anything about "bad" Kbuild configuration options?

2019-04-12 Thread Robert P. J. Day
at risk of boring, i'll mention a couple more scripts i have for locating oddities or inconsistencies in the Kbuild structure, which people are welcome to play with. the first is called "find_badref_selects.sh", which specifically locates "select" directives in Kconfig files that are

[U-Boot] doing anything about "bad" Kbuild configuration options?

2019-04-12 Thread Robert P. J. Day
only a few months ago, i jumped into a discussion regarding Kbuild config options that were defined in some Kconfig* file, but were unused anywhere in the source tree: http://u-boot.10912.n7.nabble.com/policy-regarding-unused-code-td351802.html#a351835 many years ago, i wrote a script to