Re: [U-Boot] policy regarding unused code

2018-12-14 Thread Neil Armstrong
On 11/12/2018 16:46, Jean-Jacques Hiblot wrote: > > On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: >> Hi Tom, >> >> Is there such a policy described somewhere ? >> >> There are quite a pieces of code that are not used/compiled because no >> config enables it. >> >> A random pick among many other

Re: [U-Boot] policy regarding unused code

2018-12-12 Thread Rick Chen
> > From: Jean-Jacques Hiblot [mailto:jjhib...@ti.com] > > Sent: Wednesday, December 12, 2018 8:00 PM > > To: Tom Rini > > Cc: U-Boot; Rick Jian-Zhi Chen(陳建志) > > Subject: Re: [U-Boot] policy regarding unused code > > > > Tom, Rick, > > > > On

Re: [U-Boot] policy regarding unused code

2018-12-12 Thread Jean-Jacques Hiblot
I suspect this splits into three categories: - Dead symbols and code to drop. - Typos/thinkos - Mistake in your grep? I see CONFIG_VIRTIO_SANDBOX is used today for example. what did you run to get that list of CONFIG_* symbols? years ago, i This is small python script that I wrote (see

Re: [U-Boot] policy regarding unused code

2018-12-12 Thread Jean-Jacques Hiblot
Tom, Rick, On 11/12/2018 19:17, Tom Rini wrote: On Tue, Dec 11, 2018 at 06:01:23PM +0100, Jean-Jacques Hiblot wrote: On 11/12/2018 17:35, Tom Rini wrote: On Tue, Dec 11, 2018 at 04:46:01PM +0100, Jean-Jacques Hiblot wrote: On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: Hi Tom, Is there suc

Re: [U-Boot] policy regarding unused code

2018-12-11 Thread Lukasz Majewski
On Tue, 11 Dec 2018 16:46:01 +0100 Jean-Jacques Hiblot wrote: > On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: > > Hi Tom, > > > > Is there such a policy described somewhere ? > > > > There are quite a pieces of code that are not used/compiled because > > no config enables it. > > > > A random p

Re: [U-Boot] policy regarding unused code

2018-12-11 Thread Robert P. J. Day
On Tue, 11 Dec 2018, Tom Rini wrote: ... snip ... > > This is not a small list and a lot of them we probably want to keep. > > > > ['CONFIG_MX8M', 'CONFIG_POWER_PMIC_MAX77693', 'CONFIG_TPM2_TIS_SANDBOX', > > 'CONFIG_TPM_ST33ZP24_SPI', 'CONFIG_USB_SL811HS', 'CONFIG_RAM_SUPPORT', > > 'CONFIG_BCM283

Re: [U-Boot] policy regarding unused code

2018-12-11 Thread Tom Rini
On Tue, Dec 11, 2018 at 06:01:23PM +0100, Jean-Jacques Hiblot wrote: > > On 11/12/2018 17:35, Tom Rini wrote: > >On Tue, Dec 11, 2018 at 04:46:01PM +0100, Jean-Jacques Hiblot wrote: > >>On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: > >>>Hi Tom, > >>> > >>>Is there such a policy described somewhe

Re: [U-Boot] policy regarding unused code

2018-12-11 Thread Jean-Jacques Hiblot
On 11/12/2018 17:35, Tom Rini wrote: On Tue, Dec 11, 2018 at 04:46:01PM +0100, Jean-Jacques Hiblot wrote: On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: Hi Tom, Is there such a policy described somewhere ? There are quite a pieces of code that are not used/compiled because no config enables

Re: [U-Boot] policy regarding unused code

2018-12-11 Thread Tom Rini
On Tue, Dec 11, 2018 at 04:46:01PM +0100, Jean-Jacques Hiblot wrote: > > On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: > >Hi Tom, > > > >Is there such a policy described somewhere ? > > > >There are quite a pieces of code that are not used/compiled because no > >config enables it. > > > >A rando

Re: [U-Boot] policy regarding unused code

2018-12-11 Thread Jean-Jacques Hiblot
On 11/12/2018 16:25, Jean-Jacques Hiblot wrote: Hi Tom, Is there such a policy described somewhere ? There are quite a pieces of code that are not used/compiled because no config enables it. A random pick among many others: - CONFIG_FPGA_LATTICE - CONFIG_MESON_SPIFC - CONFIG_POWER_BATTER

[U-Boot] policy regarding unused code

2018-12-11 Thread Jean-Jacques Hiblot
Hi Tom, Is there such a policy described somewhere ? There are quite a pieces of code that are not used/compiled because no config enables it. A random pick among many others: - CONFIG_FPGA_LATTICE - CONFIG_MESON_SPIFC - CONFIG_POWER_BATTERY_TRATS2 - CONFIG_UPDATE_TFTP JJ _