Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-11-13 Thread Kever Yang
On 2020/10/31 上午2:20, Arnaud Patard (Rtp) wrote: Kever Yang writes: Hi Arnaud,     Thanks for your patch.     Please use module name as subject prefix instead of a file name, eg. "rockchip: video: vop". ok. will fix. On 2020/10/27 下午9:21, Arnaud Patard (Rtp) wrote: The current code

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-30 Thread Rtp
Kever Yang writes: > Hi Arnaud, > >     Thanks for your patch. > >     Please use module name as subject prefix instead of a file name, > eg. "rockchip: video: vop". > ok. will fix. > On 2020/10/27 下午9:21, Arnaud Patard (Rtp) wrote: >> The current code is using an hard coded enum and the of

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-30 Thread Kever Yang
Hi Arnaud,     Thanks for your patch.     Please use module name as subject prefix instead of a file name, eg. "rockchip: video: vop". On 2020/10/27 下午9:21, Arnaud Patard (Rtp) wrote: The current code is using an hard coded enum and the of node reg value of endpoint to find out if the

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > The current code is using an hard coded enum and the of node reg value of > endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order > is different between rk3288, rk3399 vop little, rk3399 vop big. > > A possible solution would be

[patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-27 Thread Rtp
The current code is using an hard coded enum and the of node reg value of endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order is different between rk3288, rk3399 vop little, rk3399 vop big. A possible solution would be to make sure that the rk3288.dtsi and rk3399.dtsi files