[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2022-09-06 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Tue, 06 Sep 2022 01:07:45 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2022-05-09 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Mon, 09 May 2022 17:01:24 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2022-04-25 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Mon, 25 Apr 2022 23:38:10 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2022-03-05 Thread Tom Rini
So I've updated to the latest tool and that's why there's so many new defects found in old code. - Forwarded message from scan-ad...@coverity.com - Date: Sat, 05 Mar 2022 17:28:09 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2022-02-15 Thread Tom Rini
Hey all, Here's the latest report. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 14 Feb 2022 22:13:51 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2022-01-31 Thread Tom Rini
Hey folks, Here's the latest report and I think some of these are new tests rather than new code. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 31 Jan 2022 23:09:01 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-11-15 Thread Tom Rini
Now I'm not 100% sure if this is actually new or due to the code moving, since there's a new helper function involved, and I also know I had to hand-merge this section due to the zboot related changes. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 15 Nov 2021 17:10:36

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-11-02 Thread Tom Rini
There's a whole lot of new defects here because I noticed yesterday that there was a new stable version of the scanner, after running yesterdays normal post-RC scan. So here's a new scan done on current master. - Forwarded message from scan-ad...@coverity.com - Date: Tue, 02 Nov 2021

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-11-01 Thread Tom Rini
Here's the list of new defects from v2022.01-rc1 - Forwarded message from scan-ad...@coverity.com - Date: Mon, 01 Nov 2021 19:29:37 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-09-15 Thread Tom Rini
Hey all, Just a minor issue to fix from the latest scan. A fixes tag on 19f7a34a4642e25aa8b80c6d75129fe7848a158d would be appropriate. Thanks! - Forwarded message from scan-ad...@coverity.com - Date: Tue, 14 Sep 2021 23:10:58 + (UTC) From: scan-ad...@coverity.com To:

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-09-06 Thread Tom Rini
On Mon, Sep 06, 2021 at 05:05:40PM +0300, Oleh Kravchenko wrote: > Hello Tom! > > Looks like it a false positive detection. > info and dev_desc are validated in few lines above: > > 609 |    if (!info.name[0] && > 610 |        fastboot_mmc_get_part_info(cmd, _desc, , response) > < 0) > 611 |   

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-09-06 Thread Oleh Kravchenko
Hello Tom! Looks like it a false positive detection. info and dev_desc are validated in few lines above: 609 |    if (!info.name[0] && 610 |        fastboot_mmc_get_part_info(cmd, _desc, , response) < 0) 611 |        return; 30.08.21 20:39, Tom Rini пише: > Hey all, > > Here's the latest

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-31 Thread Oleh Kravchenko
I will take a look on it? 30.08.21 20:39, Tom Rini пише: > Hey all, > > Here's the latest report. > > - Forwarded message from scan-ad...@coverity.com - > > Date: Mon, 30 Aug 2021 16:58:54 + (UTC) > From: scan-ad...@coverity.com > To: tom.r...@gmail.com > Subject: New Defects reported

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-30 Thread Tom Rini
Hey all, Here's the latest report. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 30 Aug 2021 16:58:54 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-16 Thread Tom Rini
On Mon, Aug 16, 2021 at 10:15:49PM +0200, Pali Rohár wrote: > + Stefan and Marek > > On Monday 16 August 2021 15:57:26 Tom Rini wrote: > > Hey all, > > > > Can people please take a look? I can mark as intentional anything that > > really is intentional, thanks. > > Hello Tom! > > These

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-16 Thread Pali Rohár
+ Stefan and Marek On Monday 16 August 2021 15:57:26 Tom Rini wrote: > Hey all, > > Can people please take a look? I can mark as intentional anything that > really is intentional, thanks. Hello Tom! These kwbimage issues look to be a real issues. But I do not think that anybody touched these

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-08-16 Thread Tom Rini
Hey all, Can people please take a look? I can mark as intentional anything that really is intentional, thanks. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 16 Aug 2021 18:33:32 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-07-27 Thread Tom Rini
On Mon, Jul 26, 2021 at 11:26:39PM -0400, Sean Anderson wrote: > On 7/26/21 10:52 PM, Tom Rini wrote: > > - Forwarded message from scan-ad...@coverity.com - > > > > Date: Tue, 27 Jul 2021 01:10:27 + (UTC) > > From: scan-ad...@coverity.com > > To: tom.r...@gmail.com > > Subject: New

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-07-26 Thread Sean Anderson
On 7/26/21 10:52 PM, Tom Rini wrote: - Forwarded message from scan-ad...@coverity.com - Date: Tue, 27 Jul 2021 01:10:27 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-07-26 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Tue, 27 Jul 2021 01:10:27 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-05-26 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Tue, 25 May 2021 01:05:20 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

Re: 【外部邮件!】[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-05-13 Thread 陈冠桥
Hi Sorry, A null pointer detection is missing here, I will fix it later. On May 13, 2021, at 6:30 AM, Tom Rini mailto:tr...@konsulko.com>> wrote: - Forwarded message from scan-ad...@coverity.com - Date: Mon, 10 May 2021 21:17:32 + (UTC) From:

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-05-12 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Mon, 10 May 2021 21:17:32 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-04-20 Thread Dario Binacchi
Hi Tom, > Il 19/04/2021 14:20 Tom Rini ha scritto: > > > Hey all, > > Here's the latest report. > > - Forwarded message from scan-ad...@coverity.com - > > Date: Mon, 19 Apr 2021 01:18:55 + (UTC) > From: scan-ad...@coverity.com > To: tom.r...@gmail.com > Subject: New Defects

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-04-19 Thread Tom Rini
On Tue, Apr 20, 2021 at 12:58:28AM +, Asherah Connor wrote: > Looking at cmd/qfw.c as I touched it last: > > On 21/04/19 08:04:p, Tom Rini wrote: > > ** CID 331156: Incorrect expression (UNUSED_VALUE) > > /cmd/qfw.c: 40 in qemu_fwcfg_cmd_setup_kernel() > > > > > >

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-04-19 Thread Asherah Connor
Looking at cmd/qfw.c as I touched it last: On 21/04/19 08:04:p, Tom Rini wrote: > ** CID 331156: Incorrect expression (UNUSED_VALUE) > /cmd/qfw.c: 40 in qemu_fwcfg_cmd_setup_kernel() > > >

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-04-19 Thread Tom Rini
Hey all, Here's the latest report. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 19 Apr 2021 01:18:55 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-03-30 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Mon, 29 Mar 2021 21:36:46 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-03-02 Thread Tom Rini
Here's the new issues from the last time I ran Coverity. - Forwarded message from scan-ad...@coverity.com - Date: Tue, 02 Mar 2021 13:31:05 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-02-23 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Mon, 22 Feb 2021 16:03:35 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-02-01 Thread Tom Rini
- Forwarded message from scan-ad...@coverity.com - Date: Mon, 01 Feb 2021 16:18:03 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-26 Thread Tom Rini
On Thu, Jan 21, 2021 at 11:09:16AM +0900, AKASHI Takahiro wrote: > Tom, > > Regarding EFI capsule update, [snip] > > > ** CID 316360: Uninitialized variables (UNINIT) > > > /tools/mkeficapsule.c: 298 in create_fwbin() > > > > > > > > >

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-26 Thread Tom Rini
One new issue since the last time I ran this, and I think after reading the code myself, argc counting / sanity checking should be handled a little more clearly as well. I'm going to take a quick attempt at updating this. - Forwarded message from scan-ad...@coverity.com - Date: Tue, 26

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-22 Thread Heinrich Schuchardt
Am 22. Januar 2021 09:54:20 MEZ schrieb Sughosh Ganu : >On Thu, 21 Jan 2021 at 19:14, Heinrich Schuchardt >wrote: > >> On 21.01.21 12:36, Sughosh Ganu wrote: >> > >> > >> > On Thu, 21 Jan 2021 at 00:34, Tom Rini > > > wrote: >> > >> > I decided to run Coverity

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-22 Thread Sughosh Ganu
On Thu, 21 Jan 2021 at 19:14, Heinrich Schuchardt wrote: > On 21.01.21 12:36, Sughosh Ganu wrote: > > > > > > On Thu, 21 Jan 2021 at 00:34, Tom Rini > > wrote: > > > > I decided to run Coverity part-way through the merge window this time > > and here's what's

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-21 Thread Heinrich Schuchardt
On 21.01.21 12:36, Sughosh Ganu wrote: > > > On Thu, 21 Jan 2021 at 00:34, Tom Rini > wrote: > > I decided to run Coverity part-way through the merge window this time > and here's what's been found so far. > > - Forwarded message from

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-21 Thread Sughosh Ganu
On Thu, 21 Jan 2021 at 00:34, Tom Rini wrote: > I decided to run Coverity part-way through the merge window this time > and here's what's been found so far. > > - Forwarded message from scan-ad...@coverity.com - > > Date: Mon, 18 Jan 2021 17:53:19 + (UTC) > From:

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-20 Thread AKASHI Takahiro
Tom, Regarding EFI capsule update, On Wed, Jan 20, 2021 at 09:43:57PM +0100, Heinrich Schuchardt wrote: > On 1/20/21 8:04 PM, Tom Rini wrote: > > CC: Takahiro > > > I decided to run Coverity part-way through the merge window this time > > and here's what's been found so far. > > > > -

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-20 Thread Heinrich Schuchardt
Dear Tom, thanks for providing the Coverity results. I hope Sugosh and Takahiro will take care of the EFI capsule stuff. Find my comments for some other findings below. On 1/20/21 9:43 PM, Heinrich Schuchardt wrote: On 1/20/21 8:04 PM, Tom Rini wrote: CC: Takahiro I decided to run

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-20 Thread Tom Rini
On Wed, Jan 20, 2021 at 09:03:40PM +, Andre Przywara wrote: > On Wed, 20 Jan 2021 14:04:18 -0500 > Tom Rini wrote: > > Hi Tom, > > > I decided to run Coverity part-way through the merge window this time > > and here's what's been found so far. > > Thanks for that! > > > > - Forwarded

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-20 Thread Andre Przywara
On Wed, 20 Jan 2021 14:04:18 -0500 Tom Rini wrote: Hi Tom, > I decided to run Coverity part-way through the merge window this time > and here's what's been found so far. Thanks for that! > > - Forwarded message from scan-ad...@coverity.com - > > Date: Mon, 18 Jan 2021 17:53:19 +

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-20 Thread Heinrich Schuchardt
On 1/20/21 8:04 PM, Tom Rini wrote: CC: Takahiro I decided to run Coverity part-way through the merge window this time and here's what's been found so far. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 18 Jan 2021 17:53:19 + (UTC) From: scan-ad...@coverity.com To:

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2021-01-20 Thread Tom Rini
I decided to run Coverity part-way through the merge window this time and here's what's been found so far. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 18 Jan 2021 17:53:19 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2020-12-03 Thread Tom Rini
This latest run also closed a number of open defects (the CIDs of which are sadly not in the summary). - Forwarded message from scan-ad...@coverity.com - Date: Mon, 30 Nov 2020 18:33:34 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com Subject: New Defects reported by

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2020-11-10 Thread Tom Rini
Sadly, when we eliminate defects it doesn't say which ones in an email. -rc2 eliminated one defect and introduced these two new ones. - Forwarded message from scan-ad...@coverity.com - Date: Mon, 09 Nov 2020 22:31:55 + (UTC) From: scan-ad...@coverity.com To: tom.r...@gmail.com

Re: [scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2020-11-02 Thread Pratyush Yadav
[Copy-pasting my reply to the off-list thread]. Hi, On 30/10/20 10:45AM, Tom Rini wrote: > Hey all, > > Here's the latest report from Coverity on new issues. Please take a > look and let me know if any of these are false positives or things > that we should try and adopt a Coverity model to

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2020-10-30 Thread Tom Rini
Here's the latest report from Coverity scan. I think it's more helpful to send these to the list so that anyone can help advise on solutions than to send it only to people that may have introduced the problem, as I have previously been forwarding to. I don't recall why I got in the habit to