Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-22 Thread Marek Vasut
On 9/21/20 7:29 PM, Biju Das wrote: [...] >> There might be even better way. Look at rmobile_get_cpu_type() , that is a >> weak function. So if you can implement one for RZG2 , then that function can >> return CPU_TYPE_RZG2_something ; and rmobile_get_cpu_type() for RZG2 >> can be implemented

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-22 Thread Biju Das
Hi Marek, > > > Subject: Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC > > > > > > On 9/21/20 12:30 PM, Biju Das wrote: > > > > > > [...] > > > > > > >> I don't think you need to modify anything then, the DT passed &g

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-22 Thread Biju Das
Hi Marek, > -Original Message- > From: Biju Das > Sent: 21 September 2020 18:30 > To: Marek Vasut ; Nobuhiro Iwamatsu > > Cc: u-boot@lists.denx.de; Chris Paterson ; > Prabhakar Mahadev Lad > Subject: RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC &g

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-21 Thread Biju Das
Hi Marek, Thanks for the feedback. > Subject: Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC > > On 9/21/20 12:30 PM, Biju Das wrote: > > [...] > > >> I don't think you need to modify anything then, the DT passed from > >> TFA would contain the

Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-21 Thread Marek Vasut
On 9/21/20 12:30 PM, Biju Das wrote: [...] >> I don't think you need to modify anything then, the DT passed from TFA >> would contain the correct compatible string in / node, and that gets merged >> into the U-Boot control DT early on in fdtdec_board_setup() in: >>

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-21 Thread Biju Das
Hi Marek, Thanks for the feedback. > Subject: Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC > > On 9/19/20 8:35 PM, Biju Das wrote: > > Hi, > > [...] > > >>>>> +static const struct udevice_id *of_soc_match_compatible(void) { > >>>

Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-19 Thread Marek Vasut
On 9/19/20 8:35 PM, Biju Das wrote: Hi, [...] > +static const struct udevice_id *of_soc_match_compatible(void) { > +const struct udevice_id *of_match = soc_ids; int i; > + > +for (i = 0; i < ARRAY_SIZE(soc_ids); i++) { if > +(!fdt_node_check_compatible(gd->fdt_blob, 0, >

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-19 Thread Biju Das
Hi Marek, Thanks for the feedback. > Subject: Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC > > On 9/19/20 1:37 PM, Biju Das wrote: > [...] > >>> +static const struct udevice_id *of_soc_match_compatible(void) { > >>> +const struct udevice_id *of_match = soc_i

Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-19 Thread Marek Vasut
On 9/19/20 1:37 PM, Biju Das wrote: [...] >>> +static const struct udevice_id *of_soc_match_compatible(void) { >>> +const struct udevice_id *of_match = soc_ids; >>> +int i; >>> + >>> +for (i = 0; i < ARRAY_SIZE(soc_ids); i++) { >>> +if (!fdt_node_check_compatible(gd->fdt_blob, 0, >>> +

RE: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-19 Thread Biju Das
Hi Marek, Thanks for the feedback. > Subject: Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC > > On 9/18/20 6:03 PM, Biju Das wrote: > > Add CPU and PRR IDs for R8A774A1(a.k.a RZ/G2M) SoC. > > [...] > > > +static const struct udevice_id *of_soc_match_compatible(void)

Re: [PATCH 1/2] arm: rmobile: Add RZ/G2M SoC

2020-09-18 Thread Marek Vasut
On 9/18/20 6:03 PM, Biju Das wrote: > Add CPU and PRR IDs for R8A774A1(a.k.a RZ/G2M) SoC. [...] > +static const struct udevice_id *of_soc_match_compatible(void) > +{ > + const struct udevice_id *of_match = soc_ids; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(soc_ids); i++) { > +