Re: [PATCH 5/5] ARM: dts: stm32: Add DH Electronics DHCOM SoM and PDK2 board
On 1/17/20 5:32 PM, Patrick DELAUNAY wrote: > Hi Marek, Hi, >> From: Patrick DELAUNAY >> Sent: lundi 13 janvier 2020 15:05 >> >> Hi Marek, >> >>> From: Marek Vasut >>> Sent: vendredi 10 janvier 2020 01:29 >>> >>> Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. >>> This is an SoM with STM32MP157C and an evaluation kit. The baseboard >>> provides Ethernet, UART, USB, CAN and optional display. >>> Signed-off-by: Marek Vasut >>> Cc: Patrick Delaunay >>> Cc: Patrice Chotard >>> --- > > For information, I merge the serie, except this patch 5/5 on master brach and > I sent a pull request for u-boot-stm32-20200117. > > For this patch, I propose a rebase and also many modification liked to my > previous remark > (I remove ST only parts for stboard command, and also led and key management) > . > > This proposal is present in the branch > https://gitlab.denx.de/u-boot/custodians/u-boot-stm/tree/next > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm/commit/db48e11b1eccf23f3f9ba26e886a798e74df6a01 > > your initial patch is in applied > https://gitlab.denx.de/u-boot/custodians/u-boot-stm/tree/dh > > > Can you test the "next" branch and check the difference with your initial > patch ( applied in dh branch > https://gitlab.denx.de/u-boot/custodians/u-boot-stm/tree/dh > => > https://gitlab.denx.de/u-boot/custodians/u-boot-stm/commit/0ab3ce72f82b946ac0924dfcdc082792f325eb68 > ) > > I hope that I don't remove something really present on the SOM. > > If you are OK, can you send a V2 version with the "next" branch content and I > will integrate it in master branch for next pull request. Will do. I will rebase on master once your PR is in and then send V2. [...]
RE: [PATCH 5/5] ARM: dts: stm32: Add DH Electronics DHCOM SoM and PDK2 board
Hi Marek,
> From: Patrick DELAUNAY
> Sent: lundi 13 janvier 2020 15:05
>
> Hi Marek,
>
> > From: Marek Vasut
> > Sent: vendredi 10 janvier 2020 01:29
> >
> > Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board.
> > This is an SoM with STM32MP157C and an evaluation kit. The baseboard
> > provides Ethernet, UART, USB, CAN and optional display.
> > Signed-off-by: Marek Vasut
> > Cc: Patrick Delaunay
> > Cc: Patrice Chotard
> > ---
For information, I merge the serie, except this patch 5/5 on master brach and I
sent a pull request for u-boot-stm32-20200117.
For this patch, I propose a rebase and also many modification liked to my
previous remark
(I remove ST only parts for stboard command, and also led and key management) .
This proposal is present in the branch
https://gitlab.denx.de/u-boot/custodians/u-boot-stm/tree/next
https://gitlab.denx.de/u-boot/custodians/u-boot-stm/commit/db48e11b1eccf23f3f9ba26e886a798e74df6a01
your initial patch is in applied
https://gitlab.denx.de/u-boot/custodians/u-boot-stm/tree/dh
Can you test the "next" branch and check the difference with your initial patch
( applied in dh branch
https://gitlab.denx.de/u-boot/custodians/u-boot-stm/tree/dh
=>
https://gitlab.denx.de/u-boot/custodians/u-boot-stm/commit/0ab3ce72f82b946ac0924dfcdc082792f325eb68
)
I hope that I don't remove something really present on the SOM.
If you are OK, can you send a V2 version with the "next" branch content and I
will integrate it in master branch for next pull request.
Thanks,
Patrick
> > arch/arm/dts/Makefile | 1 +
> > .../arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts | 7 +
> > arch/arm/dts/stm32mp157c-dhcom-pdk2.dts | 88 ++
> > arch/arm/dts/stm32mp157c-dhcom-u-boot.dtsi| 238 ++
> > arch/arm/dts/stm32mp157c-dhcom.dtsi | 379 +
> > arch/arm/mach-stm32mp/Kconfig | 1 +
> > board/dhelectronics/dh_stm32mp1/Kconfig | 25 +
> > board/dhelectronics/dh_stm32mp1/MAINTAINERS | 7 +
> > board/dhelectronics/dh_stm32mp1/Makefile | 12 +
> > board/dhelectronics/dh_stm32mp1/board.c | 777 ++
> > configs/stm32mp15_dhcom_basic_defconfig | 140
> > 11 files changed, 1675 insertions(+)
> > create mode 100644 arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> > create mode 100644 arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> > create mode 100644 arch/arm/dts/stm32mp157c-dhcom-u-boot.dtsi
> > create mode 100644 arch/arm/dts/stm32mp157c-dhcom.dtsi
> > create mode 100644 board/dhelectronics/dh_stm32mp1/Kconfig
> > create mode 100644 board/dhelectronics/dh_stm32mp1/MAINTAINERS
> > create mode 100644 board/dhelectronics/dh_stm32mp1/Makefile
> > create mode 100644 board/dhelectronics/dh_stm32mp1/board.c
> > create mode 100644 configs/stm32mp15_dhcom_basic_defconfig
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> > 983e235f44..82489bc09c 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -859,6 +859,7 @@ dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
> > dtb-$(CONFIG_TARGET_STM32MP1) += \
> > stm32mp157a-dk1.dtb \
> > stm32mp157a-avenger96.dtb \
> > + stm32mp157c-dhcom-pdk2-u-boot.dtb \
> > stm32mp157c-dk2.dtb \
> > stm32mp157c-ed1.dtb \
> > stm32mp157c-ev1.dtb
> > diff --git a/arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> > b/arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> > new file mode 100644
> > index 00..fd99988570
> > --- /dev/null
> > +++ b/arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> > @@ -0,0 +1,7 @@
> > +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> > +/*
> > + * Copyright (C) 2019 Marek Vasut */
> > +
> > +#include "stm32mp157c-dhcom-pdk2.dts"
> > +#include "stm32mp157c-dhcom-u-boot.dtsi"
> > diff --git a/arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> > b/arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> > new file mode 100644
> > index 00..05aa545f55
> > --- /dev/null
> > +++ b/arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> > @@ -0,0 +1,88 @@
> > +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> > +/*
> > + * Copyright (C) 2019 Marek Vasut */
> > +
> > +#include "stm32mp157c-dhcom.dtsi"
> > +
> > +/ {
> > + model = "STMicroelectronics STM32MP157C DHCOM Premium
> > Developer Kit (2)";
> > + compatible = "dh,stm32mp157c-dhcom-pdk2", "st,stm32mp157";
> > +
> > + aliases {
> > + serial0 =
> > + ethernet0 =
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +
> > + ethernet_vio: vioregulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vio";
> > + regulator-min-microvolt = <330>;
> > + regulator-max-microvolt = <330>;
> > + gpio = < 3 GPIO_ACTIVE_LOW>;
> > + regulator-always-on;
> > + regulator-boot-on;
> > + };
> > +};
> > +
> > + {
> > + status = "okay";
RE: [PATCH 5/5] ARM: dts: stm32: Add DH Electronics DHCOM SoM and PDK2 board
Hi Marek,
> From: Marek Vasut
> Sent: vendredi 10 janvier 2020 01:29
> To: u-boot@lists.denx.de
> Cc: Marek Vasut ; Patrick DELAUNAY
> ; Patrice CHOTARD
> Subject: [PATCH 5/5] ARM: dts: stm32: Add DH Electronics DHCOM SoM and
> PDK2 board
> Importance: High
>
> Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board.
> This is an SoM with STM32MP157C and an evaluation kit. The baseboard
> provides Ethernet, UART, USB, CAN and optional display.
> Signed-off-by: Marek Vasut
> Cc: Patrick Delaunay
> Cc: Patrice Chotard
> ---
> arch/arm/dts/Makefile | 1 +
> .../arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts | 7 +
> arch/arm/dts/stm32mp157c-dhcom-pdk2.dts | 88 ++
> arch/arm/dts/stm32mp157c-dhcom-u-boot.dtsi| 238 ++
> arch/arm/dts/stm32mp157c-dhcom.dtsi | 379 +
> arch/arm/mach-stm32mp/Kconfig | 1 +
> board/dhelectronics/dh_stm32mp1/Kconfig | 25 +
> board/dhelectronics/dh_stm32mp1/MAINTAINERS | 7 +
> board/dhelectronics/dh_stm32mp1/Makefile | 12 +
> board/dhelectronics/dh_stm32mp1/board.c | 777 ++
> configs/stm32mp15_dhcom_basic_defconfig | 140
> 11 files changed, 1675 insertions(+)
> create mode 100644 arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> create mode 100644 arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> create mode 100644 arch/arm/dts/stm32mp157c-dhcom-u-boot.dtsi
> create mode 100644 arch/arm/dts/stm32mp157c-dhcom.dtsi
> create mode 100644 board/dhelectronics/dh_stm32mp1/Kconfig
> create mode 100644 board/dhelectronics/dh_stm32mp1/MAINTAINERS
> create mode 100644 board/dhelectronics/dh_stm32mp1/Makefile
> create mode 100644 board/dhelectronics/dh_stm32mp1/board.c
> create mode 100644 configs/stm32mp15_dhcom_basic_defconfig
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> 983e235f44..82489bc09c 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -859,6 +859,7 @@ dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
> dtb-$(CONFIG_TARGET_STM32MP1) += \
> stm32mp157a-dk1.dtb \
> stm32mp157a-avenger96.dtb \
> + stm32mp157c-dhcom-pdk2-u-boot.dtb \
> stm32mp157c-dk2.dtb \
> stm32mp157c-ed1.dtb \
> stm32mp157c-ev1.dtb
> diff --git a/arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> b/arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> new file mode 100644
> index 00..fd99988570
> --- /dev/null
> +++ b/arch/arm/dts/stm32mp157c-dhcom-pdk2-u-boot.dts
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> +/*
> + * Copyright (C) 2019 Marek Vasut */
> +
> +#include "stm32mp157c-dhcom-pdk2.dts"
> +#include "stm32mp157c-dhcom-u-boot.dtsi"
> diff --git a/arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> b/arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> new file mode 100644
> index 00..05aa545f55
> --- /dev/null
> +++ b/arch/arm/dts/stm32mp157c-dhcom-pdk2.dts
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> +/*
> + * Copyright (C) 2019 Marek Vasut */
> +
> +#include "stm32mp157c-dhcom.dtsi"
> +
> +/ {
> + model = "STMicroelectronics STM32MP157C DHCOM Premium
> Developer Kit (2)";
> + compatible = "dh,stm32mp157c-dhcom-pdk2", "st,stm32mp157";
> +
> + aliases {
> + serial0 =
> + ethernet0 =
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + ethernet_vio: vioregulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vio";
> + regulator-min-microvolt = <330>;
> + regulator-max-microvolt = <330>;
> + gpio = < 3 GPIO_ACTIVE_LOW>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +};
> +
> + {
> + status = "okay";
> + pinctrl-0 = <_rmii_pins_a>;
> + pinctrl-1 = <_rmii_pins_sleep_a>;
> + pinctrl-names = "default", "sleep";
> + phy-mode = "rmii";
> + max-speed = <100>;
> + phy-handle = <>;
> + st,eth_ref_clk_sel;
> + phy-reset-gpios = < 15 GPIO_ACTIVE_LOW>;
> +
> + mdio0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "snps,dwmac-mdio";
> +
> + phy0: ethernet-phy@1 {
> + reg = <1>;
> + };
> + };
> +};
> +
> + {
> + ethernet0_rmii_pins_a: rmii-0 {
> + pins1 {
> + pinmux = , /*
> ETH1_RMII_TXD0 */
> + , /*
> ETH1_RMII_TXD1 */
> + , /*
> ETH1_RMII_TX_EN */
> + , /*
> ETH1_RMII_REF_CLK */
> + , /* ETH1_MDIO
> */
> + ; /* ETH1_MDC
> */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <2>;
> + };
> + pins2 {
> + pinmux
