RE: [PATCH next v4 09/11] configs: ast2600-evb: Enable SPL FIT support
Hi Tom, > From: Tom Rini > Sent: Monday, October 4, 2021 2:41 AM > > On Thu, Sep 16, 2021 at 04:52:19PM +0800, Chia-Wei Wang wrote: > > > Enable SPL FIT image load and verification support. > > The HW accelerated SHA is also available with the newly added support > > of the HACE HW hash engine. > > > > The SPL thumb build is also enabled to keep the binary less than 64KB > > to fit into the Aspeed secure boot design. > > > > Signed-off-by: Chia-Wei Wang > > This causes the board to fail to build: >arm: + evb-ast2600 > +(evb-ast2600) common/image-fit.c: In function 'calculate_hash': > +(evb-ast2600) common/image-fit.c:1232:46: error: 'algo' undeclared (first use > in this function) > +(evb-ast2600) 1232 | hash_algo = > hash_algo_lookup_by_name(algo); > +(evb-ast2600) | > ^~~~ > +(evb-ast2600) common/image-fit.c:1232:46: note: each undeclared > +identifier is reported only once for each function it appears in > +(evb-ast2600) make[2]: *** [common/image-fit.o] Error 1 > +(evb-ast2600) make[1]: *** [common] Error 2 > +(evb-ast2600) make: *** [sub-make] Error 2 > > Please rebase and repost the series, thanks! Thanks! Will rebase to fix and send v5 ASAP. Regards, Chiawei
Re: [PATCH next v4 09/11] configs: ast2600-evb: Enable SPL FIT support
On Thu, Sep 16, 2021 at 04:52:19PM +0800, Chia-Wei Wang wrote: > Enable SPL FIT image load and verification support. > The HW accelerated SHA is also available with the > newly added support of the HACE HW hash engine. > > The SPL thumb build is also enabled to keep the binary > less than 64KB to fit into the Aspeed secure boot design. > > Signed-off-by: Chia-Wei Wang This causes the board to fail to build: arm: + evb-ast2600 +(evb-ast2600) common/image-fit.c: In function 'calculate_hash': +(evb-ast2600) common/image-fit.c:1232:46: error: 'algo' undeclared (first use in this function) +(evb-ast2600) 1232 | hash_algo = hash_algo_lookup_by_name(algo); +(evb-ast2600) | ^~~~ +(evb-ast2600) common/image-fit.c:1232:46: note: each undeclared identifier is reported only once for each function it appears in +(evb-ast2600) make[2]: *** [common/image-fit.o] Error 1 +(evb-ast2600) make[1]: *** [common] Error 2 +(evb-ast2600) make: *** [sub-make] Error 2 Please rebase and repost the series, thanks! -- Tom signature.asc Description: PGP signature
