Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Heinrich Schuchardt
On 11/16/23 02:39, Simon Glass wrote: Hi Heinrich, On Wed, 15 Nov 2023 at 15:47, Heinrich Schuchardt wrote: Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : Hi Shantur, On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: Hi Simon, I have figured out the cause of the crash. It

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 18:25, Heinrich Schuchardt wrote: > > On 11/15/23 23:46, Heinrich Schuchardt wrote: > > > > > > Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : > >> Hi Shantur, > >> > >> On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: > >>> > >>> Hi Simon, > >>>

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Heinrich, On Wed, 15 Nov 2023 at 15:47, Heinrich Schuchardt wrote: > > > > Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : > >Hi Shantur, > > > >On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: > >> > >> Hi Simon, > >> > >> I have figured out the cause of the crash. > >> It

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Heinrich Schuchardt
On 11/15/23 23:46, Heinrich Schuchardt wrote: Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : Hi Shantur, On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: Hi Simon, I have figured out the cause of the crash. It happens here -

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Heinrich Schuchardt
Am 15. November 2023 23:15:46 MEZ schrieb Simon Glass : >Hi Shantur, > >On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: >> >> Hi Simon, >> >> I have figured out the cause of the crash. >> It happens here - >> https://github.com/u-boot/u-boot/blob/master/boot/bootflow.c#L470 >> while doing

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 15:13, Shantur Rathore wrote: > > Hi Simon, > > I have figured out the cause of the crash. > It happens here - > https://github.com/u-boot/u-boot/blob/master/boot/bootflow.c#L470 > while doing - free(bflow->buf) > > As I understand it, > - Just before starting

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi Simon, I have figured out the cause of the crash. It happens here - https://github.com/u-boot/u-boot/blob/master/boot/bootflow.c#L470 while doing - free(bflow->buf) As I understand it, - Just before starting kernel EFI binary calls usb-uclass->usb_stop() - This starts removing all devices in

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 08:23, Shantur Rathore wrote: > > Hi Simon, > > > > > Is this the blue port on top of the USB-C connector? > > > Yes, that's correct. > For my drive I needed - > https://patchwork.ozlabs.org/project/uboot/patch/20231110141311.512334-...@shantur.com/ > > > > >

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi Simon, > > Is this the blue port on top of the USB-C connector? > Yes, that's correct. For my drive I needed - https://patchwork.ozlabs.org/project/uboot/patch/20231110141311.512334-...@shantur.com/ > > Which version of Armbian / download link? >

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 07:50, Shantur Rathore wrote: > > Hi Simon, > > I did some testing on the USB 3.0 port and it seems like bootflow > causes something to happen to the USB. > It seems to be only reproducible on the USB3.0 port. > > I am using an AMicro AM8180 NVME to USB

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
Hi Shantur, On Wed, 15 Nov 2023 at 07:12, Shantur Rathore wrote: > > HI Simon, > > Thanks for the speedy reply. > I can confirm patch [2] fixes the problem - at least on the USB2.0 > port on RockPro64. > I see some issue with the USB disk being unable to provide its size on > the USB3.0 port but

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi Simon, I did some testing on the USB 3.0 port and it seems like bootflow causes something to happen to the USB. It seems to be only reproducible on the USB3.0 port. I am using an AMicro AM8180 NVME to USB adapter on the USB3.0 port of RockPro64. Booting the Armbian installation using =>

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
HI Simon, Thanks for the speedy reply. I can confirm patch [2] fixes the problem - at least on the USB2.0 port on RockPro64. I see some issue with the USB disk being unable to provide its size on the USB3.0 port but that might not be linked to bootflow. PS - Also tested with

Re: bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Simon Glass
+Heinrich Schuchardt Hi Shantur, On Wed, 15 Nov 2023 at 05:59, Shantur Rathore wrote: > > Hi all, > > I am facing an issue with bootflow where grub efi crashes only when > bootflow is selected manually. > > Board - RockPro64 > OS - Armbian Bookworm CLI > U-boot : 2024.01-rc2 > Built and

bug - bootflow: grub efi crashes when bootflow selected explicitly

2023-11-15 Thread Shantur Rathore
Hi all, I am facing an issue with bootflow where grub efi crashes only when bootflow is selected manually. Board - RockPro64 OS - Armbian Bookworm CLI U-boot : 2024.01-rc2 Built and installed in SPI Boot Device = USB drive connected to USB 2.0 port Success scenario : => setenv boot_targets usb