[U-Boot-Users] [PATCH] common/cmd_load.c - Minor Code Style update code cleanup

- os_data_header Variable is a carry over feature unused. So removed all instance of this variable - Minor Code Style Update Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED] --- common/cmd_load.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/common

Re: [U-Boot-Users] NFS TFTP problem

Hi, TFTP Server running on your system needs to be configured when you change the directory. If you have installed xinetd, the configuration files are stored in /etc/xinetd.d/ folder edit /etc/xinetd.d/tftp change the server_args to pint to new directory [root @linux]# vi

Re: [U-Boot-Users] Please Help me to Setup Send Patch using M$ Office

Hi all, Hurray I found the solution to linewrap issue in M$ office. http://support.microsoft.com/?id=823921 Thanks for all the feedback and support. Regards Gururaja -- View this message in context:

[U-Boot-Users] Resubmit : [PATCH] Correct ARM Versatile Timer Initialization

- According to ARM Dual-Timer Module (SP804) TRM (ARM DDI0271), -- Timer Value Register @ TIMER Base + 4 is Read-only. -- Prescale Value (Bits 3-2 of TIMER Control register) can only be one of 00,01,10. 11 is undefined. Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED] --- cpu

[U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

- Add ARM AMBA PL031 RTC Support Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED] --- drivers/rtc/Makefile|1 + drivers/rtc/rtc_pl031.c | 123 +++ 2 files changed, 124 insertions(+), 0 deletions(-) create mode 100755 drivers/rtc/rtc_pl031.c

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

Hi, The original source file has nothing to do with this problem. Yes, but that is NOT the problem. The problem is that your mailer is wrapping long lines when it sends your patch, thus corrpting it. The source line may be long, but it is not broken. It is your mailer which corrupts the patch by

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

Hi, In message [EMAIL PROTECTED] you wrote: Yes. Sorry for the mistake. It was my M$ Office which was wrapping the mail @ column 76 hence the issue. I have changed it to 81 i have Re-Submitted the Patch. Hopefully. Its Corrected Now. Changed it to 81? I don't understand.

[U-Boot-Users] Please Help me to Setup Send Patch using M$ Office

Hi all, Since last 2 weeks i am trying to send Patches to Uboot List and its failing again again because of line wrap issue. I have setup M$ office to Automatically Wrap text at 82 Chars when i send mails which is less than 81 chars, it still wraps the text somewhere around 65 chars. I een

Re: [U-Boot-Users] Please Help me to Setup Send Patch using M$ Office

Hi, Type: man git-send-email But i am using a company email address and it uses Microsoft Exchange server. I will check about configuring it but not sure. TIA Regards Gururaja - This SF.Net email is sponsored by the

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

Hi, In message [EMAIL PROTECTED] you wrote: Hi, @@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D3D CFG_TIMER_RELOAD; /*=20 TimerLoad */ ^ - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D3D CFG_TIMER_RELOAD;

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

Hi, Please move such comments *below* the '---' line. Anything ABOVE '---' will become the commit message that goes into the repository, only stuff below the '---' gets ignores as comment. Yes i will do re-submit drivers/rtc/Makefile|1 + drivers/rtc/rtc_pl031.c | 123

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

Hi, Why do we need the #ifdef's here? It seems this is a board specific configuration anyway, i. e. we don't expect for example other RTC chips to be used on this board, or do we? Also I Just Checked u-boot-1.3.3/board/bc3450/bc3450.c. Even here it has a declaration for RTC @ line 47 #ifdef

[U-Boot-Users] Resubmit : [PATCH] Correct ARM Versatile Timer Initialization

Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED] --- cpu/arm926ejs/versatile/timer.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/cpu/arm926ejs/versatile/timer.c b/cpu/arm926ejs/versatile/timer.c index 32872d2..9659b67 100644 --- a/cpu/arm926ejs/versatile/timer.c

Re: [U-Boot-Users] Re submit : [PATCH] Correct ARM Versatile Timer Initialization

Hi, The above is Because of Below Reasons. - According to ARM Dual-Timer Module (SP804) TRM (ARM DDI0271), ---Timer Value Register @ TIMER Base + 4 is Read-only. So removed code which writes to this register ---Prescale Value (Bits 3-2 of TIMER Control register) can only be one of

Re: [U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

Hi, @@ -50,8 +50,7 @@ static ulong lastdec; int timer_init (void) { *(volatile ulong *)(CFG_TIMERBASE + 0) =3D CFG_TIMER_RELOAD; /* TimerLoad */ ^ - *(volatile ulong *)(CFG_TIMERBASE + 4) =3D CFG_TIMER_RELOAD; /* TimerValue */ ^ Your patch is line-wrapped and

[U-Boot-Users] [PATCH] Correct ARM Versatile Timer Initialization

of TIMER Control register) can only be one of 00,01,10. 11 is undefined. So bringing Correcting the same to point to 00. Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED] blocked::mailto:[EMAIL PROTECTED] --- cpu/arm926ejs/versatile/timer.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

to start pl031 rtc if enabled from versatile.c - Define rtc base address and date command support in versatile.h - Coding Style Changes/Updates Signed-off-by: Gururaja Hebbar [EMAIL PROTECTED] --- drivers/rtc/Makefile|1 + drivers/rtc/rtc_pl031.c | 123

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

-1.3.3/drivers/rtc/ uboot/drivers/rtc/ Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL PROTECTED] - Add support to the ARM AMBA PL031 RTC Chip. - remove the call to rtc_init from lib_arm/board.c boot sequence as per wd advice. - check for pl031 rtc initialization. Initialize if it hasnt yet

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

Hi, Are you going to add a board which will use it? Right now i am using it on arm Versatile board. Should i send a patch to that also If you do I can test it Regards Peter Please find attached my changes to arm versatile config board file to enable rtc module This is for test

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

Hi j, Could you please send your patch as inline, otherwise it's really difficult to comment use git-send-email as example and also please read this http://www.denx.de/wiki/UBoot/Patches and http://lwn.net/Articles/139918/ Sorry for the whitespace mistakes. i have now corrected it. But

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

file mode 100755 index 000..7136fed --- /dev/null +++ b/drivers/rtc/rtc_pl031.c @@ -0,0 +1,121 @@ +/* + * (C) Copyright 2008 + * Gururaja Hebbar [EMAIL PROTECTED] + * + * reference linux-2.6.20.6/drivers/rtc/rtc-pl031.c + * + * See file CREDITS for list of people who contributed to this + * project

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport Hi, Hello First your patch is line wrapped by your mailler. That's why i had also attached the respective patch file. that i generated using git-diff command. Secondly

[U-Boot-Users] How to call rtc_init from arm boot sequence in uboot

HI all, I am working on customized arm9 versatile board. I am trying to write a driver for arm amba pl031 rtc module. i need to setup rtc controller to enable it. I need to call it during boot sequence. But in lib_arm/board.c we do not have a call to rtc_init func. i checked blackfin boot up

Re: [U-Boot-Users] [PATCH] ADD ARM AMBA PL031 RTC Support

HI, Dont apply this patch. i need to change the call to rtc_init to a different place. since wd has mentioned in other thread that uboot doesnt initialize hardware/devices that board doesnt need. so i will change and re-send/re-submit Regards Gururaja -- View this message in context:

[U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

in this directory whereas only 1 files is changed and 1 file is added. Kindly help me to correct the same. Right now i have manually changed it in the patch file. $ git-diff -p --summary --stat u-boot-1.3.3/drivers/rtc/ uboot/drivers/rtc/ Regards Gururaja Signed off by: Gururaja Hebbar

[U-Boot-Users] [PATCH] (Resubmit) : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Hi, Sorry i had generated the patch from with uboot/lib_arm directory and hence i think it failed. now i have created the diff for the root directory where the uboot-1.3.3 folder resides. sorry for the trouble. Thanks in advance. Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL

[U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Hi, This patch removes an unused part of the code. This code is only used in lib_avr32/bootm.c and in lib_arm/bootm.c it is under #if 0 Comments are welcome. Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL PROTECTED] --- bootm_orig.c2008-07-15 16:51:03.296875000 -0700

Re: [U-Boot-Users] [PATCH] : Remove unused code from uboot-1.3.3/lib_arm/bootm.c

Hi, Sorry i had generated the patch from with uboot/lib_arm directory and hence i think it failed. now i have created the diff for the root directory where the uboot-1.3.3 folder resides. sorry for the trouble. Thanks in advance. Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL

Re: [U-Boot-Users] Re locating code problem

Hi, I have a problem durinf relocating of code from sdram. The uboot hangs. My sdram initialization is correct as it has passed ddr test. Kindly help me in solving this. I am using Jtag to download uboot to flash. Uboot version ? Platform/Processor ? Do u see any Uboot Init or startup

Re: [U-Boot-Users] [PATCH v2] MMC: Consolidate MMC/SD command

Hi Haavard Skinnemoen, while you are working on atmel mci mmc driver, i would like to know whether you can tell me anything about the bug mentioned here Possible Bug in at32ap mmc driver atmel_mci.c related to incorrect usage of variables.

[U-Boot-Users] [PATCH] Remove gaps and whitespaces in README file

Hi, Remove gaps and whitespaces in README file Here in my company i cannot use git and hence no git-patch or git-mail. Will see if i can convince them to allow git. sorry till then Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL PROTECTED] diff -purN u-boot-1.3.3/README u-boot

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

use git and hence no git-patch or git-mail. sorry for that.. Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL PROTECTED] diff -purN u-boot-1.3.3/common/usb.c u-boot-1.3.3-modified/common/usb.c --- u-boot-1.3.3/common/usb.c 2008-05-19 03:47:11.0 -0700 +++ u-boot-1.3.3-modified

Re: [U-Boot-Users] [PATCH] Remove gaps and whitespaces in README file

Rejected. You corrupt the nice alignment which IMHO makes the code more readable. But few corrections in them doesnt break the alignment like the below ones @ -608,7 +608,7 @@ The following options need to be configu CONFIG_CMD_NAND * NAND support

Re: [U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

Thanks. Had to apply manually, as your patch is line-wrapped. Please fix your mailer to not wrap lines! I sent the patch from nabble forum becuase i thought microsoft outlook will line wrap the mails. Also i uploaded patch along with the mail rom nable forum. What could you prevent from

Re: [U-Boot-Users] [PATCH]:arm926ejs: Regression to remove inappropriate LED control code from arch init start.S

Hi, Removed code to LED init since it is not specific to the ARM CPU, but rather should go in the board/platform specific files. I second that Regards Gururaja -- View this message in context:

[U-Boot-Users] [PATCH] remove error meesage in usb_ohci.c when debug is enabled

/drivers/usb' make: *** [/home/guru/project/u_boot/Ubuild/drivers/usb/libusb.a] Error 2 This is due to a missing } for function ohci_dump @ line 408. Below patch corrects the same. Comments are welcome. Regards Gururaja Signed off by: Gururaja Hebbar [EMAIL PROTECTED] --- usb_ohci_orig.c

[U-Boot-Users] ARM march architecture version for arm926ejs in config.mk

Hi, i have seen questions on the mailing list about march for arm926ejs being mentioned as -march=armv4. http://www.nabble.com/-PATCH--ARM%3A-Fix-arm-architecture-version-for-ar m926ejs-td5195486.html#a5210157 http://www.nabble.com/-patch-u-boot-git-2-3--better-ARM9-compiler-option

[U-Boot-Users] [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

Hi, In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations. @line 77 and @line 112. Below patch removes them for code size savings. comments welcome. Thanks in advance Signed-off-by: gururaja hebbar [EMAIL PROTECTED] --- usb_orig.c 2007-12-06 01:21:19.0 -0800

[U-Boot-Users] how to enable if, then command support in uboot

Hi all, I am trying to execute some commands stored in environment as below #define CONFIG_EXTRA_ENV_SETTINGS \ boot_mmc= \ if mmcinit \ fatload mmc 0 ${ramfs_addr} ${ramfs_file} \ fatload

Re: [U-Boot-Users] how to enable if, then command support in uboot

add missing info Uboot version : 1.3.1 for ARM926EJS processor based board using arm toolchain from CodeSourcery Regards Gururaja -Original Message- From: Gururaja Hebbar K R Sent: Friday, March 28, 2008 6:37 PM To: 'u-boot-users@lists.sourceforge.net' Subject: how to enable

[U-Boot-Users] multiple definition of __udivsi3 when using divide operation on unsigned long numbers

Hi, I am trying to compile uboot 1.3.1 for arm926ejs processor. i am using CodeSourcery arm-none-linux-gnueabi toolchain (gcc version 4.2.1 (CodeSourcery Sourcery G++ Lite 2007q3-51)) . i am trying to write a driver for our on board mmc controller. i need to do multiply and divide operation as

Re: [U-Boot-Users] multiple definition of __udivsi3 when using divide operation on unsigned long numbers

Hi Dirk, Thanks for the information. i looked at he nand_util.c and used the same do_div in my code and was able to compile without any issues. Regards Gururaja Don't do this. Compiler/Linker then tries to use math from libraries coming with your tool chain. Normally, U-Boot should be

[U-Boot-Users] Possible Bug in at32ap mmc driver atmel_mci.c

Hi, I am trying to port mmc driver to my board with little assistance from atmel_mci driver. While i was trying to understand the mmc_cmd function, i think i found a bug in it. File - uboot-1.3.1\cpu\at32ap\atmel_mci.c Function - static int mmc_cmd(unsigned long cmd, unsigned long arg,

Re: [U-Boot-Users] [PATCH] ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Hi, I went through cpu/arm920t/start.S file and found that this is what this patch is doing. This patch places the entire cpu_init_crit function definition inside ifndef same as in arm920t/start.S. Sorry if i havent understood you. Present cpu/arm926ejs/start.S _start_armboot: .word

[U-Boot-Users] how to Relocate arm startup code

Hi, I am working on a customized arm926ejs versatile board. My board has SDRAM at reset vector i.e., @ 0x00 and FLASH is located at a different higher lcoation. At Boot up, SDRAm is mapped to Flash. I have to enable few register and enable sdram chip. @ reset the arm uboot startup code has b

Re: [U-Boot-Users] [PATCH] ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

Hi Wolfgang , At Present the call to cpu_init_crit in uboot/cpu/arm926ejs/start.S (142) is under ifndef #ifndef CONFIG_SKIP_LOWLEVEL_INIT bl cpu_init_crit #endif But the function definition (203) isn't under this ifndef. So irrespective of CONFIG_SKIP_LOWLEVEL_INIT, this