Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-15 Thread Detlev Zundel
Hi Grant, > Ugh, please don't continue down that path. Dataflash is a serial > flash technology, but the driver pretends that it is memory mapped. > It is not a good abstraction that I really think needs to be removed. > I don't think it is a good idea to add that mis-feature into new > commands.

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Bartlomiej Sieka
Grant Likely wrote: > On Feb 13, 2008 12:55 PM, Bartlomiej Sieka <[EMAIL PROTECTED]> wrote: >> Kumar Gala wrote: >>> On Feb 13, 2008, at 4:11 AM, Bartlomiej Sieka wrote: >>> Kumar Gala wrote: > 'imload' provides a more direct means to load from an image file. > Also created a load_imag

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 7:13 PM, Grant Likely wrote: > On Feb 13, 2008 12:55 PM, Bartlomiej Sieka <[EMAIL PROTECTED]> wrote: >> Kumar Gala wrote: >>> >>> On Feb 13, 2008, at 4:11 AM, Bartlomiej Sieka wrote: >>> Kumar Gala wrote: > 'imload' provides a more direct means to load from an image f

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
>> +switch (image_get_comp (hdr)) { >> +case IH_COMP_NONE: >> +if (dst == (ulong)hdr) { >> +printf (" XIP %s ... ", type_name); > > This is an ugly hack in the old code that should be removed by the new > implementation. can you explain this further, I'm h

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Grant Likely
On Feb 13, 2008 12:55 PM, Bartlomiej Sieka <[EMAIL PROTECTED]> wrote: > Kumar Gala wrote: > > > > On Feb 13, 2008, at 4:11 AM, Bartlomiej Sieka wrote: > > > >> Kumar Gala wrote: > >>> 'imload' provides a more direct means to load from an image file. > >>> Also created a load_image routine out of th

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 6:37 PM, Wolfgang Denk wrote: > In message <3192541E-1FBD-4638- > [EMAIL PROTECTED]> you wrote: >> >>> Why just uImage? >> >> what other image formats do we support? I assume we'll extend it for >> the new format style once that exists. > > uImage means "OS Kernel Image" (IH

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > > Why just uImage? > > what other image formats do we support? I assume we'll extend it for > the new format style once that exists. uImage means "OS Kernel Image" (IH_TYPE_KERNEL in include/image.h). > I feel like I'm missing something here. I

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 5:01 PM, Wolfgang Denk wrote: > In message <7DB626E7-34A4-4EAA-B470- > [EMAIL PROTECTED]> you wrote: >> >>> What exactly is an "image file" here (which sorts of images are >>> allowed?) and what does "load" mean (which actions are performed on >>> the file)? >> >> its suppose

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > > What exactly is an "image file" here (which sorts of images are > > allowed?) and what does "load" mean (which actions are performed on > > the file)? > > its suppose to be a 'uImage' not sure what the base way to refer to > that is. Why just uIm

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 4:31 PM, Wolfgang Denk wrote: > In message [EMAIL PROTECTED]> you wrote: >> 'imload' provides a more direct means to load from an image file. > > What exactly is an "image file" here (which sorts of images are > allowed?) and what does "load" mean (which actions are performed

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > 'imload' provides a more direct means to load from an image file. What exactly is an "image file" here (which sorts of images are allowed?) and what does "load" mean (which actions are performed on the file)? > Also created a load_image routine out of t

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 2:22 PM, Bartlomiej Sieka wrote: > Kumar Gala wrote: > [...] > - The load_image routine (and consequently imload commad) will > not work when the image is stored in Data Flash. what's the issue here? >>> >>> Please have a look at code under CONFIG_HAS_DATAFLASH

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Bartlomiej Sieka
Kumar Gala wrote: [...] - The load_image routine (and consequently imload commad) will not work when the image is stored in Data Flash. >>> what's the issue here? >> >> Please have a look at code under CONFIG_HAS_DATAFLASH in get_kernel() >> (formerly in do_bootm()), especially the read_

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 1:55 PM, Bartlomiej Sieka wrote: > Kumar Gala wrote: >> On Feb 13, 2008, at 4:11 AM, Bartlomiej Sieka wrote: >>> Kumar Gala wrote: 'imload' provides a more direct means to load from an image file. Also created a load_image routine out of the code in do_bootm()

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Bartlomiej Sieka
Kumar Gala wrote: > > On Feb 13, 2008, at 4:11 AM, Bartlomiej Sieka wrote: > >> Kumar Gala wrote: >>> 'imload' provides a more direct means to load from an image file. >>> Also created a load_image routine out of the code in do_bootm() that >>> is shared between do_bootm() and do_imload(). >>> Si

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Kumar Gala
On Feb 13, 2008, at 4:11 AM, Bartlomiej Sieka wrote: > Kumar Gala wrote: >> 'imload' provides a more direct means to load from an image file. >> Also created a load_image routine out of the code in do_bootm() that >> is shared between do_bootm() and do_imload(). >> Signed-off-by: Kumar Gala <[EMA

Re: [U-Boot-Users] [PATCH] Add 'imload' command

2008-02-13 Thread Bartlomiej Sieka
Kumar Gala wrote: > 'imload' provides a more direct means to load from an image file. > > Also created a load_image routine out of the code in do_bootm() that > is shared between do_bootm() and do_imload(). > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> > --- > > Note, this is against the u-b

[U-Boot-Users] [PATCH] Add 'imload' command

2008-02-12 Thread Kumar Gala
'imload' provides a more direct means to load from an image file. Also created a load_image routine out of the code in do_bootm() that is shared between do_bootm() and do_imload(). Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Note, this is against the u-boot-testing new-image branch. comm