Re: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-04-06 Thread Haavard Skinnemoen
On Sun, 30 Mar 2008 19:41:52 -0400 Ben Warren <[EMAIL PROTECTED]> wrote: > I have a patch that will be submitted tomorrow that puts a call to > board_eth_init() here, so you don't need to. If this is already in the > AVR32 repo no big deal. FWIW, it's not in the AVR32 repo yet. I think the patc

Re: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-03-30 Thread Ben Warren
Hi Alex, Alex wrote: > Hi > > Sorry, as you might have guessed I did not run MAKEALL to check my patch :-( > Worse, It would have broken existing code... Sorry again. > > I try to avoid such things in future. > > I corrected the patch. I tried to run MAKEALL, but it fails, as I don't have > all t

Re: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-03-26 Thread Haavard Skinnemoen
Hi Alex, Please see below for some (delayed) review comments. On Mon, 17 Mar 2008 11:31:42 +0100 Alex <[EMAIL PROTECTED]> wrote: > I corrected the patch. I tried to run MAKEALL, but it fails, as I don't have > all those cross-compilers > installed. Am I missing something? Do I need to install t

Re: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-03-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:31 Mon 17 Mar , Alex wrote: > Hi > > Sorry, as you might have guessed I did not run MAKEALL to check my patch :-( > Worse, It would have broken existing code... Sorry again. > > I try to avoid such things in future. > > I corrected the patch. I tried to run MAKEALL, but it fails, as I

Re: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-03-17 Thread Alex
Hi Sorry, as you might have guessed I did not run MAKEALL to check my patch :-( Worse, It would have broken existing code... Sorry again. I try to avoid such things in future. I corrected the patch. I tried to run MAKEALL, but it fails, as I don't have all those cross-compilers installed. Am I

Re: [U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-03-14 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > This patch adds support for our new AVR32 based board. ... > diff -Nur old/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c > new/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c > --- old/u-boot-avr32/cpu/at32ap/at32ap700x/gpio.c 2008-03-14 > 14:40:30.

[U-Boot-Users] [PATCH] Add support for hammerhead AVR32 board

2008-03-14 Thread Alex
Hi This patch adds support for our new AVR32 based board. It is against the latest u-boot-avr32.git. As suggested I removed 'flash.c'. And as Ben Warren suggested I named my network initialization 'board_eth_initialize( ... )'. Like this I don't need to ifdef the call to this function, right?