Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Hugo Villeneuve wrote: > Either way, I think my patch, or a variation of it, should need to be > applied to get rid of that ugly 6400%. Agreed -- the patch in mtd-2.6.22.1 takes care of the percentage issue at the same time as issuing the warning. -Scott

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Scott Wood wrote: > Hugo Villeneuve wrote: >> Scott Wood wrote: >>> Hugo Villeneuve wrote: I would be perfectly happy if the mtd driver reported a warning when the requested erase size is not an exact multiple of the block size, and allow the whole block erase to proceed. Then my >>>

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Hugo Villeneuve wrote: > Scott Wood wrote: >> Hugo Villeneuve wrote: >>> I would be perfectly happy if the mtd driver reported a warning when >>> the requested erase size is not an exact multiple of the block size, >>> and allow the whole block erase to proceed. Then my patch would make >>> sense.

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Scott Wood wrote: > Hugo Villeneuve wrote: >> I would be perfectly happy if the mtd driver reported a warning when >> the requested erase size is not an exact multiple of the block size, >> and allow the whole block erase to proceed. Then my patch would make >> sense. > > That's what the mtd-2.6.

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Hugo Villeneuve wrote: > I would be perfectly happy if the mtd driver reported a warning when the > requested erase size is not an exact multiple of the block size, and > allow the whole block erase to proceed. Then my patch would make sense. That's what the mtd-2.6.22.1 branch in the NAND reposit

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Scott Wood wrote: > Hugo Villeneuve wrote: >> Scott Wood wrote: >>> That should be an error. >> >> What should be an error, the fact that 6400% is displayed, or the >> fact that the user is trying to erase less than a block? :) > > The latter. It should tell the user what the erase block size is

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Hugo Villeneuve wrote: > Scott Wood wrote: >> That should be an error. > > What should be an error, the fact that 6400% is displayed, or the fact > that the user is trying to erase less than a block? :) The latter. It should tell the user what the erase block size is, and abort. -Scott --

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

Scott Wood wrote: > On Fri, May 16, 2008 at 02:39:17PM -0400, Hugo Villeneuve wrote: >> This patch fixes an error when reporting the NAND erase progress as >> in this example: U-Boot > nand erase 800 >> NAND erase: device 0 offset 0x0, size 0x800 >> Erasing at 0x0 -- 6400% complete. > >

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

On Fri, May 16, 2008 at 02:39:17PM -0400, Hugo Villeneuve wrote: > This patch fixes an error when reporting the NAND erase > progress as in this example: > U-Boot > nand erase 800 > NAND erase: device 0 offset 0x0, size 0x800 > Erasing at 0x0 -- 6400% complete. So the problem is when tr

[U-Boot-Users] [PATCH] Fix NAND erase progress error

This patch fixes an error when reporting the NAND erase progress as in this example: U-Boot > nand erase 800 NAND erase: device 0 offset 0x0, size 0x800 Erasing at 0x0 -- 6400% complete. Signed-off-by: Hugo Villeneuve <[EMAIL PROTECTED]> --- drivers/mtd/nand/nand_util.c | 11 +++

Re: [U-Boot-Users] [PATCH] Fix NAND erase progress error

In message <[EMAIL PROTECTED]> you wrote: > diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c > index 6c5624a..bd21e04 100644 > --- a/drivers/mtd/nand/nand_util.c > +++ b/drivers/mtd/nand/nand_util.c Please describe what the error is, nd add your signed-off-by line. Best re

[U-Boot-Users] [PATCH] Fix NAND erase progress error

diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c index 6c5624a..bd21e04 100644 --- a/drivers/mtd/nand/nand_util.c +++ b/drivers/mtd/nand/nand_util.c @@ -209,10 +209,15 @@ int nand_erase_opts(nand_info_t *meminfo, const nand_erase_options_t *opts) }